[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12107 ) Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. IMPALA-7213: Use separate network plane for DataStream and Control services This change is a follow up for a review comment in https://gerrit.cloudera.org/#/c/10855/ about separating the TCP connections of DataStream and Control services so that control commands don't get blocked behind large payloads being sent in the DataStream services. Testing done: exhaustive build Change-Id: I774f4a0e2cfedc4dba72cde4f5d28898cdbdc236 Reviewed-on: http://gerrit.cloudera.org:8080/12107 Reviewed-by: Michael Ho Tested-by: Impala Public Jenkins --- M be/src/service/control-service.cc M be/src/service/data-stream-service.cc 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Michael Ho: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I774f4a0e2cfedc4dba72cde4f5d28898cdbdc236 Gerrit-Change-Number: 12107 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Marshall
[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12107 ) Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I774f4a0e2cfedc4dba72cde4f5d28898cdbdc236 Gerrit-Change-Number: 12107 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Wed, 19 Dec 2018 23:37:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12107 ) Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1649/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I774f4a0e2cfedc4dba72cde4f5d28898cdbdc236 Gerrit-Change-Number: 12107 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Wed, 19 Dec 2018 20:20:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12107 ) Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3588/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/12107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I774f4a0e2cfedc4dba72cde4f5d28898cdbdc236 Gerrit-Change-Number: 12107 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Wed, 19 Dec 2018 19:34:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services
Michael Ho has posted comments on this change. (
http://gerrit.cloudera.org:8080/12107 )
Change subject: IMPALA-7213: Use separate network plane for DataStream and
Control services
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12107/1/be/src/service/control-service.cc
File be/src/service/control-service.cc:
http://gerrit.cloudera.org:8080/#/c/12107/1/be/src/service/control-service.cc@83
PS1, Line 83: (*proxy)->set_network_plane("control");
> Maybe add a brief comment about the motivation here
Done
--
To view, visit http://gerrit.cloudera.org:8080/12107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I774f4a0e2cfedc4dba72cde4f5d28898cdbdc236
Gerrit-Change-Number: 12107
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Thomas Marshall
Gerrit-Comment-Date: Wed, 19 Dec 2018 19:30:40 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12107 ) Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. Patch Set 2: Code-Review+2 Carry Thomas' +2. -- To view, visit http://gerrit.cloudera.org:8080/12107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I774f4a0e2cfedc4dba72cde4f5d28898cdbdc236 Gerrit-Change-Number: 12107 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Wed, 19 Dec 2018 19:30:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services
Hello Thomas Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12107 to look at the new patch set (#2). Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. IMPALA-7213: Use separate network plane for DataStream and Control services This change is a follow up for a review comment in https://gerrit.cloudera.org/#/c/10855/ about separating the TCP connections of DataStream and Control services so that control commands don't get blocked behind large payloads being sent in the DataStream services. Testing done: exhaustive build Change-Id: I774f4a0e2cfedc4dba72cde4f5d28898cdbdc236 --- M be/src/service/control-service.cc M be/src/service/data-stream-service.cc 2 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/12107/2 -- To view, visit http://gerrit.cloudera.org:8080/12107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I774f4a0e2cfedc4dba72cde4f5d28898cdbdc236 Gerrit-Change-Number: 12107 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall
[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12107 ) Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1639/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I774f4a0e2cfedc4dba72cde4f5d28898cdbdc236 Gerrit-Change-Number: 12107 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Marshall Gerrit-Comment-Date: Tue, 18 Dec 2018 19:16:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7213: Use separate network plane for DataStream and Control services
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12107 Change subject: IMPALA-7213: Use separate network plane for DataStream and Control services .. IMPALA-7213: Use separate network plane for DataStream and Control services This change is a follow up for a review comment in https://gerrit.cloudera.org/#/c/10855/ about separating the TCP connections of DataStream and Control services so that control commands don't get blocked behind large payloads being sent in the DataStream services. Testing done: exhaustive build Change-Id: I774f4a0e2cfedc4dba72cde4f5d28898cdbdc236 --- M be/src/service/control-service.cc M be/src/service/data-stream-service.cc 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/12107/1 -- To view, visit http://gerrit.cloudera.org:8080/12107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I774f4a0e2cfedc4dba72cde4f5d28898cdbdc236 Gerrit-Change-Number: 12107 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho
