[Impala-ASF-CR] IMPALA-7218: [DOCS] Support column list in ALTER VIEW
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11043 ) Change subject: IMPALA-7218: [DOCS] Support column list in ALTER VIEW .. Patch Set 3: I did not see Pooja's comments before submitting this. I will create another review request with the fix. -- To view, visit http://gerrit.cloudera.org:8080/11043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 Gerrit-Change-Number: 11043 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Wed, 25 Jul 2018 19:36:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7218: [DOCS] Support column list in ALTER VIEW
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11043 ) Change subject: IMPALA-7218: [DOCS] Support column list in ALTER VIEW .. IMPALA-7218: [DOCS] Support column list in ALTER VIEW Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 Reviewed-on: http://gerrit.cloudera.org:8080/11043 Reviewed-by: Fredy Wijaya Tested-by: Impala Public Jenkins --- M docs/topics/impala_alter_view.xml 1 file changed, 53 insertions(+), 36 deletions(-) Approvals: Fredy Wijaya: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 Gerrit-Change-Number: 11043 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar
[Impala-ASF-CR] IMPALA-7218: [DOCS] Support column list in ALTER VIEW
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11043 ) Change subject: IMPALA-7218: [DOCS] Support column list in ALTER VIEW .. Patch Set 3: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/8/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/11043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 Gerrit-Change-Number: 11043 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Wed, 25 Jul 2018 18:06:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7218: [DOCS] Support column list in ALTER VIEW
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11043 ) Change subject: IMPALA-7218: [DOCS] Support column list in ALTER VIEW .. Patch Set 2: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/7/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/11043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 Gerrit-Change-Number: 11043 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Wed, 25 Jul 2018 18:05:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7218: [DOCS] Support column list in ALTER VIEW
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11043 ) Change subject: IMPALA-7218: [DOCS] Support column list in ALTER VIEW .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/11043/3/docs/topics/impala_alter_view.xml File docs/topics/impala_alter_view.xml: http://gerrit.cloudera.org:8080/#/c/11043/3/docs/topics/impala_alter_view.xml@82 PS3, Line 82: c3 Please remove this. Since the select statement has two columns (x, s), the column definition list should also have two columns. http://gerrit.cloudera.org:8080/#/c/11043/3/docs/topics/impala_alter_view.xml@105 PS3, Line 105: Nit: Please remove the new line. http://gerrit.cloudera.org:8080/#/c/11043/3/docs/topics/impala_alter_view.xml@118 PS3, Line 118: Nit: Please remove the new line. http://gerrit.cloudera.org:8080/#/c/11043/3/docs/topics/impala_alter_view.xml@120 PS3, Line 120: Nit: Please remove the new line. -- To view, visit http://gerrit.cloudera.org:8080/11043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 Gerrit-Change-Number: 11043 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Wed, 25 Jul 2018 18:04:35 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7218: [DOCS] Support column list in ALTER VIEW
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11043 ) Change subject: IMPALA-7218: [DOCS] Support column list in ALTER VIEW .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 Gerrit-Change-Number: 11043 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Wed, 25 Jul 2018 18:00:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7218: [DOCS] Support column list in ALTER VIEW
Hello Pooja Nilangekar, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11043 to look at the new patch set (#3). Change subject: IMPALA-7218: [DOCS] Support column list in ALTER VIEW .. IMPALA-7218: [DOCS] Support column list in ALTER VIEW Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 --- M docs/topics/impala_alter_view.xml 1 file changed, 53 insertions(+), 36 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/11043/3 -- To view, visit http://gerrit.cloudera.org:8080/11043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 Gerrit-Change-Number: 11043 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar
[Impala-ASF-CR] IMPALA-7218: [DOCS] Support column list in ALTER VIEW
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11043 ) Change subject: IMPALA-7218: [DOCS] Support column list in ALTER VIEW .. Patch Set 3: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/8/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 Gerrit-Change-Number: 11043 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Wed, 25 Jul 2018 17:57:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7218: [DOCS] Support column list in ALTER VIEW
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11043 ) Change subject: IMPALA-7218: [DOCS] Support column list in ALTER VIEW .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11043/1/docs/topics/impala_alter_view.xml File docs/topics/impala_alter_view.xml: http://gerrit.cloudera.org:8080/#/c/11043/1/docs/topics/impala_alter_view.xml@74 PS1, Line 74: An optional list of column names can be specified with or without the column-level : comments. > Add two more examples that include column names with comments and column na Done http://gerrit.cloudera.org:8080/#/c/11043/1/docs/topics/impala_alter_view.xml@85 PS1, Line 85: The RENAME TO clause changes the name of the view, moves the view to a : different database, or both. > Also give two more examples that does a rename (e.g. ALTER VIEW db1.v1 RENA Done -- To view, visit http://gerrit.cloudera.org:8080/11043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 Gerrit-Change-Number: 11043 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Wed, 25 Jul 2018 17:55:42 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7218: [DOCS] Support column list in ALTER VIEW
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11043 ) Change subject: IMPALA-7218: [DOCS] Support column list in ALTER VIEW .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/7/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 Gerrit-Change-Number: 11043 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Wed, 25 Jul 2018 17:55:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7218: [DOCS] Support column list in ALTER VIEW
Hello Pooja Nilangekar, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11043 to look at the new patch set (#2). Change subject: IMPALA-7218: [DOCS] Support column list in ALTER VIEW .. IMPALA-7218: [DOCS] Support column list in ALTER VIEW Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 --- M docs/topics/impala_alter_view.xml 1 file changed, 50 insertions(+), 36 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/11043/2 -- To view, visit http://gerrit.cloudera.org:8080/11043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 Gerrit-Change-Number: 11043 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar
[Impala-ASF-CR] IMPALA-7218: [DOCS] Support column list in ALTER VIEW
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11043 ) Change subject: IMPALA-7218: [DOCS] Support column list in ALTER VIEW .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11043/1/docs/topics/impala_alter_view.xml File docs/topics/impala_alter_view.xml: http://gerrit.cloudera.org:8080/#/c/11043/1/docs/topics/impala_alter_view.xml@85 PS1, Line 85: The RENAME TO clause changes the name of the view, moves the view to a : different database, or both. Also give two more examples that does a rename (e.g. ALTER VIEW db1.v1 RENAME to db1.v2) and move (e.g. ALTER VIEW db1.v1 RENAME to db2.v1) -- To view, visit http://gerrit.cloudera.org:8080/11043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 Gerrit-Change-Number: 11043 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Wed, 25 Jul 2018 16:07:45 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7218: [DOCS] Support column list in ALTER VIEW
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11043 ) Change subject: IMPALA-7218: [DOCS] Support column list in ALTER VIEW .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11043/1/docs/topics/impala_alter_view.xml File docs/topics/impala_alter_view.xml: http://gerrit.cloudera.org:8080/#/c/11043/1/docs/topics/impala_alter_view.xml@74 PS1, Line 74: An optional list of column names can be specified with or without the column-level : comments. Add two more examples that include column names with comments and column names without comments. It'll be clearer I think. -- To view, visit http://gerrit.cloudera.org:8080/11043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 Gerrit-Change-Number: 11043 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Wed, 25 Jul 2018 16:05:28 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7218: [DOCS] Support column list in ALTER VIEW
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11043 ) Change subject: IMPALA-7218: [DOCS] Support column list in ALTER VIEW .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/5/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/11043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 Gerrit-Change-Number: 11043 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Pooja Nilangekar Gerrit-Comment-Date: Wed, 25 Jul 2018 00:35:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7218: [DOCS] Support column list in ALTER VIEW
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11043 ) Change subject: IMPALA-7218: [DOCS] Support column list in ALTER VIEW .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/5/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/11043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 Gerrit-Change-Number: 11043 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 25 Jul 2018 00:23:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7218: [DOCS] Support column list in ALTER VIEW
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11043 Change subject: IMPALA-7218: [DOCS] Support column list in ALTER VIEW .. IMPALA-7218: [DOCS] Support column list in ALTER VIEW Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 --- M docs/topics/impala_alter_view.xml 1 file changed, 47 insertions(+), 36 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/11043/1 -- To view, visit http://gerrit.cloudera.org:8080/11043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I19e5cf97302a46738fd832344415fb7ad4ca0e41 Gerrit-Change-Number: 11043 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
