[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-31 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..

IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

Previously, the ReadVLong() function would read a byte and use it
after subsequent calls to ReadBytes() function. As a result, the
value was invalidated depending on the contents of the
boundary_buffer_. This change ensures that all the functions on
the buffer are invoked before subsequent calls to ReadBytes().

Testing:
Enabled test_tpch_scan_ranges() for sequence files and ran it
multiple times to ensure it always produces the desired result.
Manually verified the buffer usage of other calls to ReadBytes()
and GetBytes().

Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Reviewed-on: http://gerrit.cloudera.org:8080/11828
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M be/src/exec/scanner-context.h
M be/src/exec/scanner-context.inline.h
M tests/query_test/test_scanners.py
3 files changed, 11 insertions(+), 11 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 7
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-31 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..


Patch Set 6: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 6
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 01 Nov 2018 04:41:00 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-31 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..


Patch Set 6: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 6
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 01 Nov 2018 00:45:20 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-31 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..


Patch Set 6:

Hit the OpenJDK version issue


--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 6
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 01 Nov 2018 00:45:47 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-31 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3396/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 6
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 01 Nov 2018 00:45:21 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-31 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..


Patch Set 5: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3391/


--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 5
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 01 Nov 2018 00:42:28 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-31 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 5
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 31 Oct 2018 20:48:56 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-31 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3391/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 5
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 31 Oct 2018 20:48:57 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-31 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3385/


--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 4
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 31 Oct 2018 08:09:30 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-30 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3385/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 4
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 31 Oct 2018 04:21:16 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-30 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 4
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 31 Oct 2018 04:21:15 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-30 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3382/


--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 31 Oct 2018 04:04:05 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-30 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/1223/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 31 Oct 2018 00:43:57 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-30 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3382/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 31 Oct 2018 00:10:35 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-30 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 31 Oct 2018 00:10:23 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-30 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 31 Oct 2018 00:10:34 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-30 Thread Pooja Nilangekar (Code Review) 
Pooja Nilangekar has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..

IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

Previously, the ReadVLong() function would read a byte and use it
after subsequent calls to ReadBytes() function. As a result, the
value was invalidated depending on the contents of the
boundary_buffer_. This change ensures that all the functions on
the buffer are invoked before subsequent calls to ReadBytes().

Testing:
Enabled test_tpch_scan_ranges() for sequence files and ran it
multiple times to ensure it always produces the desired result.
Manually verified the buffer usage of other calls to ReadBytes()
and GetBytes().

Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
---
M be/src/exec/scanner-context.h
M be/src/exec/scanner-context.inline.h
M tests/query_test/test_scanners.py
3 files changed, 11 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/11828/2
--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-30 Thread Pooja Nilangekar (Code Review) 
Pooja Nilangekar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11828/1/be/src/exec/scanner-context.inline.h
File be/src/exec/scanner-context.inline.h:

http://gerrit.cloudera.org:8080/#/c/11828/1/be/src/exec/scanner-context.inline.h@169
PS1, Line 169:   if (is_negative) *value = *value ^ (static_cast(-1));
> nit: could put conditional on one line.
Done



--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 30 Oct 2018 23:54:20 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-30 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11828/1/be/src/exec/scanner-context.inline.h
File be/src/exec/scanner-context.inline.h:

http://gerrit.cloudera.org:8080/#/c/11828/1/be/src/exec/scanner-context.inline.h@169
PS1, Line 169:   if (is_negative) {
nit: could put conditional on one line.



--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 30 Oct 2018 23:47:59 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-30 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11828 )

Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/1218/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 30 Oct 2018 22:51:33 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

2018-10-30 Thread Pooja Nilangekar (Code Review) 
Pooja Nilangekar has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/11828


Change subject: IMPALA-7363: Fix buffer usage in 
ScannerContext::Stream::ReadVLong()
..

IMPALA-7363: Fix buffer usage in ScannerContext::Stream::ReadVLong()

Previously, the ReadVLong() function would read a byte and use it
after subsequent calls to ReadBytes() function. As a result, the
value was invalidated depending on the contents of the
boundary_buffer_. This change ensures that all the functions on
the buffer are invoked before subsequent calls to ReadBytes().

Testing:
Enabled test_tpch_scan_ranges() for sequence files and ran it
multiple times to ensure it always produces the desired result.
Manually verified the buffer usage of other calls to ReadBytes()
and GetBytes().

Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
---
M be/src/exec/scanner-context.h
M be/src/exec/scanner-context.inline.h
M tests/query_test/test_scanners.py
3 files changed, 10 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/11828/1
--
To view, visit http://gerrit.cloudera.org:8080/11828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2b2ffe4b1d67c63cfcea2baedbeff48e65ca417
Gerrit-Change-Number: 11828
Gerrit-PatchSet: 1
Gerrit-Owner: Pooja Nilangekar