[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 Gerrit-Change-Number: 11786 Gerrit-PatchSet: 5 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 26 Oct 2018 20:54:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException The problem was acache consistency issue between impalad and catalogd. Because a Sentry refresh was occuring during an update to privileges from the alter table set owner, impalad had the correct privileges, which allowed the "show grant role" to succeed but the privileges in catalogd were being overwritten from the sentry refresh. Added a delay in the drop call to ensure privileges are updated. This is a workaround to get the tests to pass with the existing behaviour and should be reassessed if IMPALA-7763 is implemented. This would add a lock to possibly prevent this, but will need it's own assessment. Testing: - Ran custom cluster tests 50 times Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 Reviewed-on: http://gerrit.cloudera.org:8080/11786 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M tests/authorization/test_owner_privileges.py 1 file changed, 21 insertions(+), 16 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/11786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 Gerrit-Change-Number: 11786 Gerrit-PatchSet: 6 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 Gerrit-Change-Number: 11786 Gerrit-PatchSet: 5 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 26 Oct 2018 16:59:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3365/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/11786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 Gerrit-Change-Number: 11786 Gerrit-PatchSet: 5 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 26 Oct 2018 16:59:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 Gerrit-Change-Number: 11786 Gerrit-PatchSet: 4 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 26 Oct 2018 16:41:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1170/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 Gerrit-Change-Number: 11786 Gerrit-PatchSet: 4 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 26 Oct 2018 03:52:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Adam Holley has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException The problem was acache consistency issue between impalad and catalogd. Because a Sentry refresh was occuring during an update to privileges from the alter table set owner, impalad had the correct privileges, which allowed the "show grant role" to succeed but the privileges in catalogd were being overwritten from the sentry refresh. Added a delay in the drop call to ensure privileges are updated. This is a workaround to get the tests to pass with the existing behaviour and should be reassessed if IMPALA-7763 is implemented. This would add a lock to possibly prevent this, but will need it's own assessment. Testing: - Ran custom cluster tests 50 times Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 --- M tests/authorization/test_owner_privileges.py 1 file changed, 21 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/11786/4 -- To view, visit http://gerrit.cloudera.org:8080/11786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 Gerrit-Change-Number: 11786 Gerrit-PatchSet: 4 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11786/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11786/3//COMMIT_MSG@15 PS3, Line 15: updated. something here is unclear about whether the feature is working as intended but the test was incorrect or if something needs to improve w/ the feature (perhaps link to the jira that discusses solving some of these issues w/ a lock?). -- To view, visit http://gerrit.cloudera.org:8080/11786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 Gerrit-Change-Number: 11786 Gerrit-PatchSet: 3 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 25 Oct 2018 21:16:50 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1165/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 Gerrit-Change-Number: 11786 Gerrit-PatchSet: 3 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 25 Oct 2018 19:11:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 2: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/1160/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/11786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 Gerrit-Change-Number: 11786 Gerrit-PatchSet: 2 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 25 Oct 2018 18:11:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 2: Code-Review+1 Vuk, can you take another look at this? -- To view, visit http://gerrit.cloudera.org:8080/11786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 Gerrit-Change-Number: 11786 Gerrit-PatchSet: 2 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 25 Oct 2018 18:04:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Adam Holley has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException The problem was another cache consistency issue between Impalad and Catalogd. Because a Sentry refresh was occuring during an update to privileges from the alter table set owner, Impalad had the correct privileges, which allowed the "show grant role" to succeed but the privileges in catalogd were being overwritten from the sentry refresh. Added a delay in the drop call to ensure privileges are updated. Testing: - Ran custom cluster tests 50 times Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 --- M tests/authorization/test_owner_privileges.py 1 file changed, 21 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/11786/2 -- To view, visit http://gerrit.cloudera.org:8080/11786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 Gerrit-Change-Number: 11786 Gerrit-PatchSet: 2 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11786/1/tests/authorization/test_owner_privileges.py File tests/authorization/test_owner_privileges.py: http://gerrit.cloudera.org:8080/#/c/11786/1/tests/authorization/test_owner_privileges.py@95 PS1, Line 95: return self.count_user_privileges(result) == count: : : def _test_clea > Can be simplified to return self.count_user_privileges_result) Done -- To view, visit http://gerrit.cloudera.org:8080/11786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 Gerrit-Change-Number: 11786 Gerrit-PatchSet: 2 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 25 Oct 2018 17:36:25 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1155/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 Gerrit-Change-Number: 11786 Gerrit-PatchSet: 1 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 25 Oct 2018 16:22:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11723 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1154/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8bb2e1fba334ba26e6ae25fbb04c1a5785ac677 Gerrit-Change-Number: 11723 Gerrit-PatchSet: 2 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 25 Oct 2018 16:14:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11786/1/tests/authorization/test_owner_privileges.py File tests/authorization/test_owner_privileges.py: http://gerrit.cloudera.org:8080/#/c/11786/1/tests/authorization/test_owner_privileges.py@95 PS1, Line 95: if self.count_user_privileges(result) == count: : return True : return False Can be simplified to return self.count_user_privileges_result) -- To view, visit http://gerrit.cloudera.org:8080/11786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 Gerrit-Change-Number: 11786 Gerrit-PatchSet: 1 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Comment-Date: Thu, 25 Oct 2018 16:03:57 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11786 Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException The problem was another cache consistency issue between Impalad and Catalogd. Because a Sentry refresh was occuring during an update to privileges from the alter table set owner, Impalad had the correct privileges, which allowed the "show grant role" to succeed but the privileges in catalogd were being overwritten from the sentry refresh. Added a delay in the drop call to ensure privileges are updated. Testing: - Ran custom cluster tests 50 times Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 --- M tests/authorization/test_owner_privileges.py 1 file changed, 22 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/11786/1 -- To view, visit http://gerrit.cloudera.org:8080/11786 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5a1babd3dcbb94ffaa1f3e6ef2cebf1a1d391219 Gerrit-Change-Number: 11786 Gerrit-PatchSet: 1 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Adam Holley has abandoned this change. ( http://gerrit.cloudera.org:8080/11723 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/11723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: If8bb2e1fba334ba26e6ae25fbb04c1a5785ac677 Gerrit-Change-Number: 11723 Gerrit-PatchSet: 2 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Adam Holley has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11723 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException The problem was another cache consistency issue between Impalad and Catalogd. Because a Sentry refresh was occuring during an update to privileges from the alter table set owner, Impalad had the correct privileges, which allowed the "show grant role" to succeed but the privileges in catalogd were being overwritten from the sentry refresh. Added a delay in the drop call to ensure privileges are updated. Testing: - Ran custom cluster tests Change-Id: If8bb2e1fba334ba26e6ae25fbb04c1a5785ac677 --- M tests/authorization/test_owner_privileges.py 1 file changed, 22 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/11723/2 -- To view, visit http://gerrit.cloudera.org:8080/11723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If8bb2e1fba334ba26e6ae25fbb04c1a5785ac677 Gerrit-Change-Number: 11723 Gerrit-PatchSet: 2 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11723 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11723/1/tests/authorization/test_owner_privileges.py File tests/authorization/test_owner_privileges.py: http://gerrit.cloudera.org:8080/#/c/11723/1/tests/authorization/test_owner_privileges.py@229 PS1, Line 229: test_obj.obj_name), user="oo_user1", delay_s=sentry_refresh_timeout_s) > I was not able to reproduce manually but reviewing the failed builds, this Since this is a flaky test, let's spend some time figuring out the root case instead of fixing something that we may think is the fix, but end up having to fix it again. -- To view, visit http://gerrit.cloudera.org:8080/11723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8bb2e1fba334ba26e6ae25fbb04c1a5785ac677 Gerrit-Change-Number: 11723 Gerrit-PatchSet: 1 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 19 Oct 2018 15:43:18 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11723 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1089/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8bb2e1fba334ba26e6ae25fbb04c1a5785ac677 Gerrit-Change-Number: 11723 Gerrit-PatchSet: 1 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 18 Oct 2018 15:59:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11723 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11723/1/tests/authorization/test_owner_privileges.py File tests/authorization/test_owner_privileges.py: http://gerrit.cloudera.org:8080/#/c/11723/1/tests/authorization/test_owner_privileges.py@229 PS1, Line 229: test_obj.obj_name), user="oo_user1", delay_s=sentry_refresh_timeout_s) > Are you able to reproduce the issue? We have bunch of calls to self.user_qu I was not able to reproduce manually but reviewing the failed builds, this seems to be specific to alter set owner. I don't want to put the delay on each user_query call because of the additional overhead. I created https://issues.apache.org/jira/browse/IMPALA-7722 to further investigate. -- To view, visit http://gerrit.cloudera.org:8080/11723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8bb2e1fba334ba26e6ae25fbb04c1a5785ac677 Gerrit-Change-Number: 11723 Gerrit-PatchSet: 1 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Comment-Date: Thu, 18 Oct 2018 15:33:04 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11723 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11723/1/tests/authorization/test_owner_privileges.py File tests/authorization/test_owner_privileges.py: http://gerrit.cloudera.org:8080/#/c/11723/1/tests/authorization/test_owner_privileges.py@229 PS1, Line 229: test_obj.obj_name), user="oo_user1", delay_s=sentry_refresh_timeout_s) Are you able to reproduce the issue? We have bunch of calls to self.user_query that does not use delay_s=sentry_refresh_timeout_s in this function. Should we also update those? -- To view, visit http://gerrit.cloudera.org:8080/11723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If8bb2e1fba334ba26e6ae25fbb04c1a5785ac677 Gerrit-Change-Number: 11723 Gerrit-PatchSet: 1 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya Gerrit-Comment-Date: Thu, 18 Oct 2018 15:26:37 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11723 Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException The problem was another cache consistency issue between Impalad and Catalogd. Because a Sentry refresh was occuring during an update to privileges from the alter table set owner, Impalad had the correct privileges, which allowed the "show grant role" to succeed but the privileges in catalogd were being overwritten from the sentry refresh. Added a delay in the drop call to ensure privileges are updated. Testing: - Ran custom cluster tests Change-Id: If8bb2e1fba334ba26e6ae25fbb04c1a5785ac677 --- M tests/authorization/test_owner_privileges.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/11723/1 -- To view, visit http://gerrit.cloudera.org:8080/11723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If8bb2e1fba334ba26e6ae25fbb04c1a5785ac677 Gerrit-Change-Number: 11723 Gerrit-PatchSet: 1 Gerrit-Owner: Adam Holley Gerrit-Reviewer: Adam Holley Gerrit-Reviewer: Fredy Wijaya
