[Impala-ASF-CR] IMPALA-7844: Default to not allow ordinals in HAVING clause
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17415 ) Change subject: IMPALA-7844: Default to not allow ordinals in HAVING clause .. IMPALA-7844: Default to not allow ordinals in HAVING clause Base on the discussion of the previous patch, we decide to not allow ordinals in the HAVING clause since 4.0. It's a non-standard feature that unintentionally supported by Impala 3.x and earlier versions. This patch disables it by default, and add a feature flag to turn it on for users that do depend on it. Tests: - Modify existing FE tests to test on the flag. - Add custom cluster test to verify the flag works. Change-Id: I0a57b8b65b046fae483e485e8391f8222fa586a5 Reviewed-on: http://gerrit.cloudera.org:8080/17415 Reviewed-by: Zoltan Borok-Nagy Tested-by: Impala Public Jenkins --- M be/src/util/backend-gflag-util.cc M common/thrift/BackendGflags.thrift M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M tests/custom_cluster/test_disable_features.py 6 files changed, 42 insertions(+), 39 deletions(-) Approvals: Zoltan Borok-Nagy: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/17415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0a57b8b65b046fae483e485e8391f8222fa586a5 Gerrit-Change-Number: 17415 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-7844: Default to not allow ordinals in HAVING clause
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17415 ) Change subject: IMPALA-7844: Default to not allow ordinals in HAVING clause .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a57b8b65b046fae483e485e8391f8222fa586a5 Gerrit-Change-Number: 17415 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 10 May 2021 15:17:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7844: Default to not allow ordinals in HAVING clause
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17415 ) Change subject: IMPALA-7844: Default to not allow ordinals in HAVING clause .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7127/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a57b8b65b046fae483e485e8391f8222fa586a5 Gerrit-Change-Number: 17415 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 10 May 2021 09:23:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7844: Default to not allow ordinals in HAVING clause
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17415 ) Change subject: IMPALA-7844: Default to not allow ordinals in HAVING clause .. Patch Set 3: Thanks for the quick review! -- To view, visit http://gerrit.cloudera.org:8080/17415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a57b8b65b046fae483e485e8391f8222fa586a5 Gerrit-Change-Number: 17415 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 10 May 2021 09:22:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7844: Default to not allow ordinals in HAVING clause
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17415 ) Change subject: IMPALA-7844: Default to not allow ordinals in HAVING clause .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8693/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a57b8b65b046fae483e485e8391f8222fa586a5 Gerrit-Change-Number: 17415 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 10 May 2021 09:21:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7844: Default to not allow ordinals in HAVING clause
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17415 ) Change subject: IMPALA-7844: Default to not allow ordinals in HAVING clause .. Patch Set 3: Code-Review+2 Thanks for fixing this, LGTM! -- To view, visit http://gerrit.cloudera.org:8080/17415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a57b8b65b046fae483e485e8391f8222fa586a5 Gerrit-Change-Number: 17415 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 10 May 2021 09:16:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7844: Default to not allow ordinals in HAVING clause
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17415 ) Change subject: IMPALA-7844: Default to not allow ordinals in HAVING clause .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8692/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a57b8b65b046fae483e485e8391f8222fa586a5 Gerrit-Change-Number: 17415 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Mon, 10 May 2021 09:15:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7844: Default to not allow ordinals in HAVING clause
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17415 to look at the new patch set (#3). Change subject: IMPALA-7844: Default to not allow ordinals in HAVING clause .. IMPALA-7844: Default to not allow ordinals in HAVING clause Base on the discussion of the previous patch, we decide to not allow ordinals in the HAVING clause since 4.0. It's a non-standard feature that unintentionally supported by Impala 3.x and earlier versions. This patch disables it by default, and add a feature flag to turn it on for users that do depend on it. Tests: - Modify existing FE tests to test on the flag. - Add custom cluster test to verify the flag works. Change-Id: I0a57b8b65b046fae483e485e8391f8222fa586a5 --- M be/src/util/backend-gflag-util.cc M common/thrift/BackendGflags.thrift M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M tests/custom_cluster/test_disable_features.py 6 files changed, 42 insertions(+), 39 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/17415/3 -- To view, visit http://gerrit.cloudera.org:8080/17415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0a57b8b65b046fae483e485e8391f8222fa586a5 Gerrit-Change-Number: 17415 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7844: Default to not allow ordinals in HAVING clause
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17415 to look at the new patch set (#2). Change subject: IMPALA-7844: Default to not allow ordinals in HAVING clause .. IMPALA-7844: Default to not allow ordinals in HAVING clause Base on the discussion of the previous patch, we decide to not allow ordinals in the HAVING clause since 4.0. It's a non-standard feature that unintentionally supported by Impala 3.x and earlier versions. This patch disables it by default, and add a feature flag to turn it on for users that do depend on it. Tests: - Modify existing FE tests to test on the flag. - Add custom cluster test to verify the flag works. Change-Id: I0a57b8b65b046fae483e485e8391f8222fa586a5 --- M be/src/util/backend-gflag-util.cc M common/thrift/BackendGflags.thrift M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M tests/custom_cluster/test_disable_features.py 6 files changed, 40 insertions(+), 39 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/17415/2 -- To view, visit http://gerrit.cloudera.org:8080/17415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0a57b8b65b046fae483e485e8391f8222fa586a5 Gerrit-Change-Number: 17415 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-7844: Default to not allow ordinals in HAVING clause
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/17415 )
Change subject: IMPALA-7844: Default to not allow ordinals in HAVING clause
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17415/1/fe/src/main/java/org/apache/impala/service/BackendConfig.java
File fe/src/main/java/org/apache/impala/service/BackendConfig.java:
http://gerrit.cloudera.org:8080/#/c/17415/1/fe/src/main/java/org/apache/impala/service/BackendConfig.java@256
PS1, Line 256: public boolean getAllowOrdinalsInHaving() { return
backendCfg_.allow_ordinals_in_having; }
line too long (92 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a57b8b65b046fae483e485e8391f8222fa586a5
Gerrit-Change-Number: 17415
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Mon, 10 May 2021 08:52:33 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7844: Default to not allow ordinals in HAVING clause
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17415 Change subject: IMPALA-7844: Default to not allow ordinals in HAVING clause .. IMPALA-7844: Default to not allow ordinals in HAVING clause Base on the discussion of the previous patch, we decide to not allow ordinals in the HAVING clause since 4.0. It's a non-standard feature that unintendedly supported by Impala 3.x and earlier versions. This patch disables it by default, and add a feature flag to turn it on for users that do depend on it. Tests: - Modify existing FE tests to test on the flag. - Add custom cluster test to verify the flag works. Change-Id: I0a57b8b65b046fae483e485e8391f8222fa586a5 --- M be/src/util/backend-gflag-util.cc M common/thrift/BackendGflags.thrift M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M tests/custom_cluster/test_disable_features.py 6 files changed, 40 insertions(+), 39 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/17415/1 -- To view, visit http://gerrit.cloudera.org:8080/17415 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0a57b8b65b046fae483e485e8391f8222fa586a5 Gerrit-Change-Number: 17415 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang
