[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12734 ) Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. Patch Set 3: Code-Review+1 Thanks for making the suggested changes. -- To view, visit http://gerrit.cloudera.org:8080/12734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac Gerrit-Change-Number: 12734 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 13 Mar 2019 20:54:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12734 ) Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac Reviewed-on: http://gerrit.cloudera.org:8080/12734 Tested-by: Impala Public Jenkins Reviewed-by: Vihang Karajgaonkar Reviewed-by: Alex Rodoni --- M docs/topics/impala_metadata.xml 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Verified Vihang Karajgaonkar: Looks good to me, but someone else must approve Alex Rodoni: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/12734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac Gerrit-Change-Number: 12734 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12734 ) Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac Gerrit-Change-Number: 12734 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 13 Mar 2019 21:01:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12734 ) Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. Patch Set 3: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/272/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/12734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac Gerrit-Change-Number: 12734 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 13 Mar 2019 20:48:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12734 ) Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12734/2/docs/topics/impala_metadata.xml File docs/topics/impala_metadata.xml: http://gerrit.cloudera.org:8080/#/c/12734/2/docs/topics/impala_metadata.xml@207 PS2, Line 207: Hive metastore service file. > nit: change to "of Hive metastore service". i think the word "file" is red Done -- To view, visit http://gerrit.cloudera.org:8080/12734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac Gerrit-Change-Number: 12734 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 13 Mar 2019 20:27:44 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12734 ) Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. Patch Set 3: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/272/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/12734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac Gerrit-Change-Number: 12734 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 13 Mar 2019 20:27:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync
Hello Bharath Vissapragada, Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12734 to look at the new patch set (#3). Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac --- M docs/topics/impala_metadata.xml 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/12734/3 -- To view, visit http://gerrit.cloudera.org:8080/12734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac Gerrit-Change-Number: 12734 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12734 ) Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. Patch Set 2: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/271/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/12734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac Gerrit-Change-Number: 12734 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 13 Mar 2019 18:57:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12734 ) Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. Patch Set 2: (1 comment) Rest looks good to me. Just one minor correction below. http://gerrit.cloudera.org:8080/#/c/12734/2/docs/topics/impala_metadata.xml File docs/topics/impala_metadata.xml: http://gerrit.cloudera.org:8080/#/c/12734/2/docs/topics/impala_metadata.xml@207 PS2, Line 207: Hive metastore service file. nit: change to "of Hive metastore service". i think the word "file" is redundant and can be removed. -- To view, visit http://gerrit.cloudera.org:8080/12734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac Gerrit-Change-Number: 12734 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 13 Mar 2019 18:48:24 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12734 ) Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/271/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/12734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac Gerrit-Change-Number: 12734 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 13 Mar 2019 18:41:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12734 ) Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12734/1/docs/topics/impala_metadata.xml File docs/topics/impala_metadata.xml: http://gerrit.cloudera.org:8080/#/c/12734/1/docs/topics/impala_metadata.xml@207 PS1, Line 207: file. > suggest you to add "of Hive metastore service" here to make it clearer sinc Done -- To view, visit http://gerrit.cloudera.org:8080/12734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac Gerrit-Change-Number: 12734 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 13 Mar 2019 18:41:22 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync
Hello Bharath Vissapragada, Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12734 to look at the new patch set (#2). Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac --- M docs/topics/impala_metadata.xml 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/12734/2 -- To view, visit http://gerrit.cloudera.org:8080/12734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac Gerrit-Change-Number: 12734 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12734 ) Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12734/1/docs/topics/impala_metadata.xml File docs/topics/impala_metadata.xml: http://gerrit.cloudera.org:8080/#/c/12734/1/docs/topics/impala_metadata.xml@207 PS1, Line 207: file. suggest you to add "of Hive metastore service" here to make it clearer since there are can be many hive-site.xml files http://gerrit.cloudera.org:8080/#/c/12734/1/docs/topics/impala_metadata.xml@213 PS1, Line 213: /property> > Question for Vihang: The above to configurations are only available in CDH Hive. We plan to make those changes to upstream but it will be available in Hive 3.2 onwards. Hence I think its okay to skip it as long as we document these configurations to the CDH documentation. If users are using Apache Hive 2.1.1 (open-source version of Apache Hive) the only configuration which is needed is hive.metastore.transactional.event.listeners. -- To view, visit http://gerrit.cloudera.org:8080/12734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac Gerrit-Change-Number: 12734 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 13 Mar 2019 18:35:11 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12734 ) Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12734/1/docs/topics/impala_metadata.xml File docs/topics/impala_metadata.xml: http://gerrit.cloudera.org:8080/#/c/12734/1/docs/topics/impala_metadata.xml@213 PS1, Line 213: /property> Question for Vihang: Now that we are here, should we also document hive.metastore.notification.parameters.exclude.patterns and hive.metastore.notifications.add.thrift.objects true hive.metastore.alter.notifications.basic false ? -- To view, visit http://gerrit.cloudera.org:8080/12734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac Gerrit-Change-Number: 12734 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 13 Mar 2019 04:56:16 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12734 ) Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/267/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/12734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac Gerrit-Change-Number: 12734 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 12 Mar 2019 23:00:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12734 ) Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/267/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/12734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac Gerrit-Change-Number: 12734 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 12 Mar 2019 22:43:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12734 Change subject: IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync .. IMPALA-7974: [DOCS] Phase 2: Configure Hive for event-based HMS sync Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac --- M docs/topics/impala_metadata.xml 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/12734/1 -- To view, visit http://gerrit.cloudera.org:8080/12734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2091d8b6afe1e75d78ce542e76351310562d81ac Gerrit-Change-Number: 12734 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
