[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14044 ) Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function - Added the Date and Timestamp patterns supported for the new CAST signature. Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 Reviewed-on: http://gerrit.cloudera.org:8080/14044 Reviewed-by: Gabor Kaszab Tested-by: Impala Public Jenkins --- M docs/topics/impala_conversion_functions.xml 1 file changed, 718 insertions(+), 65 deletions(-) Approvals: Gabor Kaszab: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/14044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 Gerrit-Change-Number: 14044 Gerrit-PatchSet: 5 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14044 ) Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. Patch Set 4: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/455/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 Gerrit-Change-Number: 14044 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 15 Aug 2019 17:44:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14044 ) Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 Gerrit-Change-Number: 14044 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 15 Aug 2019 17:42:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14044 ) Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. Patch Set 4: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/455/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 Gerrit-Change-Number: 14044 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 15 Aug 2019 17:32:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
Hello Gabor Kaszab, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14044 to look at the new patch set (#4). Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function - Added the Date and Timestamp patterns supported for the new CAST signature. Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 --- M docs/topics/impala_conversion_functions.xml 1 file changed, 718 insertions(+), 65 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/14044/4 -- To view, visit http://gerrit.cloudera.org:8080/14044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 Gerrit-Change-Number: 14044 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14044 ) Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml File docs/topics/impala_conversion_functions.xml: http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml@193 PS2, Line 193: > Sorry, this wasn't a suggestion to copy-paste to the change. I rather meant Done http://gerrit.cloudera.org:8080/#/c/14044/3/docs/topics/impala_conversion_functions.xml File docs/topics/impala_conversion_functions.xml: http://gerrit.cloudera.org:8080/#/c/14044/3/docs/topics/impala_conversion_functions.xml@589 PS3, Line 589: “+10”, “-05”. > Please add an example that doesn't contain a sign. E.g. "04"http://gerrit.cloudera.org:8080/14044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 Gerrit-Change-Number: 14044 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 15 Aug 2019 17:31:18 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14044 ) Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. Patch Set 3: Code-Review+1 (3 comments) Found some minor things. Once these are covered, I'm fine to +2. http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml File docs/topics/impala_conversion_functions.xml: http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml@193 PS2, Line 193: > Done Sorry, this wasn't a suggestion to copy-paste to the change. I rather meant this as a fact that requires this sentence to re-think a bit. Suggestion: For year tokens if fewer number of digits are in expression than specified in the pattern, the current date is used to complete the conversion. ... http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml@303 PS2, Line 303: try> : > Done Thanks, this looks way better! http://gerrit.cloudera.org:8080/#/c/14044/3/docs/topics/impala_conversion_functions.xml File docs/topics/impala_conversion_functions.xml: http://gerrit.cloudera.org:8080/#/c/14044/3/docs/topics/impala_conversion_functions.xml@589 PS3, Line 589: “+10”, “-05”. Please add an example that doesn't contain a sign. E.g. "04" -- To view, visit http://gerrit.cloudera.org:8080/14044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 Gerrit-Change-Number: 14044 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 15 Aug 2019 08:49:57 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14044 ) Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. Patch Set 3: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/450/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 Gerrit-Change-Number: 14044 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 13 Aug 2019 19:34:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14044 ) Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. Patch Set 3: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/450/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 Gerrit-Change-Number: 14044 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 13 Aug 2019 19:13:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
Hello Gabor Kaszab, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14044 to look at the new patch set (#3). Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function - Added the Date and Timestamp patterns supported for the new CAST signature. Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 --- M docs/topics/impala_conversion_functions.xml 1 file changed, 716 insertions(+), 65 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/14044/3 -- To view, visit http://gerrit.cloudera.org:8080/14044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 Gerrit-Change-Number: 14044 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14044 ) Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. Patch Set 2: (13 comments) http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml File docs/topics/impala_conversion_functions.xml: http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml@166 PS2, Line 166: The patterns supported in the FORMAT clause are not the same format : patterns used with the other Impala conversion functions, e.g. > I would mention here that this format is introduced to support ISO:SQL:2016 Done http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml@192 PS2, Line 192: If a fewer number of digits in > nit: "If fewer number of digits in" Done http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml@193 PS2, Line 193: the current date is used to complete > current date is only used for completing the year pattern. Done http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml@303 PS2, Line 303: The year is adjusted to be nearest to the nearest century to the current : date: > Here I'd list all the possible use-cases. For that there is a link to an Or Done http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml@307 PS2, Line 307: For string to datetime semantics, round year when last 2 digits of : current year is greater than 49. > Not sure what the meaning of this sentence is. Removed and replaced with the possible cases above. http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml@538 PS2, Line 538: Must be specified at the end of the pattern string > TZH and TZM can be anywhere in the pattern. TZM don't even has to be right Done http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml@545 PS2, Line 545: -15 and 15 > The design doc incorrectly mentions this limit. In fact Impala parses the o Done http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml@572 PS2, Line 572: Unsigned numbers between 0 and 59 are allowed for the source : expression. > There is no range check for TZM. Similarly to TZH after parsin Impala ignor Done http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml@628 PS2, Line 628: t > typo Done http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml@635 PS2, Line 635: CAST(“2019-. : ;101” AS DATE FORMAT “-MM-DD”) > This was a typo in the design doc. Actually this is the query that would su Done http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml@642 PS2, Line 642: ph>T Please mention that this is for accepting ISO8601 datetime formats. Done http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml@655 PS2, Line 655: >Z > Same comment as for "T" Done http://gerrit.cloudera.org:8080/#/c/14044/2/docs/topics/impala_conversion_functions.xml@668 PS2, Line 668: Examples: > It's great to have a few examples here. I'd add one more to have some cover Done -- To view, visit http://gerrit.cloudera.org:8080/14044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 Gerrit-Change-Number: 14044 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 13 Aug 2019 19:12:02 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14044 ) Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. Patch Set 2: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/446/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 Gerrit-Change-Number: 14044 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 12 Aug 2019 18:59:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
Hello Gabor Kaszab, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14044 to look at the new patch set (#2). Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function - Added the Date and Timestamp patterns supported for the new CAST signature. Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 --- M docs/topics/impala_conversion_functions.xml 1 file changed, 667 insertions(+), 65 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/14044/2 -- To view, visit http://gerrit.cloudera.org:8080/14044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 Gerrit-Change-Number: 14044 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14044 ) Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. Patch Set 2: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/446/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 Gerrit-Change-Number: 14044 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 12 Aug 2019 18:30:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14044 ) Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/14044/1/docs/topics/impala_conversion_functions.xml File docs/topics/impala_conversion_functions.xml: http://gerrit.cloudera.org:8080/#/c/14044/1/docs/topics/impala_conversion_functions.xml@84 PS1, Line 84: If the expression value is of a type that cannot be converted to : the target type, e.g. from TIMESTAMP to : DECIMAL, the function returns NULL. > DECIMAL and DATE types are exceptions to this rule: they return an error in BOOLEAN returned an error. Noted those 3 types. http://gerrit.cloudera.org:8080/#/c/14044/1/docs/topics/impala_conversion_functions.xml@175 PS1, Line 175: TIMESTAMP > This should be DATE too, if in L176 the expected result is of DATE type. Done http://gerrit.cloudera.org:8080/#/c/14044/1/docs/topics/impala_conversion_functions.xml@528 PS1, Line 528: -15 and 15 > I'm not sure if this is the valid range. Please check with Gabor Kaszab. Gabor? http://gerrit.cloudera.org:8080/#/c/14044/1/docs/topics/impala_conversion_functions.xml@555 PS1, Line 555: 0 and 59 > I'm not sure if this is the valid range. Please check with Gabor Kaszab. Gabor? -- To view, visit http://gerrit.cloudera.org:8080/14044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 Gerrit-Change-Number: 14044 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 12 Aug 2019 18:29:30 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
Attila Jeges has posted comments on this change. (
http://gerrit.cloudera.org:8080/14044 )
Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/14044/1/docs/topics/impala_conversion_functions.xml
File docs/topics/impala_conversion_functions.xml:
http://gerrit.cloudera.org:8080/#/c/14044/1/docs/topics/impala_conversion_functions.xml@84
PS1, Line 84: If the expression value is of a type that
cannot be converted to
: the target type, e.g. from
TIMESTAMP to
: DECIMAL, the function returns
NULL.
DECIMAL and DATE types are exceptions to this rule: they return an error
instead.
impala> select cast('123x' as decimal);
ERROR: UDF ERROR: String to Decimal parse failed
http://gerrit.cloudera.org:8080/#/c/14044/1/docs/topics/impala_conversion_functions.xml@175
PS1, Line 175: TIMESTAMP
This should be DATE too, if in L176 the expected result is of DATE type.
http://gerrit.cloudera.org:8080/#/c/14044/1/docs/topics/impala_conversion_functions.xml@528
PS1, Line 528: -15 and 15
I'm not sure if this is the valid range. Please check with Gabor Kaszab.
http://gerrit.cloudera.org:8080/#/c/14044/1/docs/topics/impala_conversion_functions.xml@555
PS1, Line 555: 0 and 59
I'm not sure if this is the valid range. Please check with Gabor Kaszab.
--
To view, visit http://gerrit.cloudera.org:8080/14044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092
Gerrit-Change-Number: 14044
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni
Gerrit-Reviewer: Attila Jeges
Gerrit-Reviewer: Gabor Kaszab
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Mon, 12 Aug 2019 16:27:30 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14044 ) Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/443/ : Doc tests passed. -- To view, visit http://gerrit.cloudera.org:8080/14044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 Gerrit-Change-Number: 14044 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Gabor Kaszab Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 09 Aug 2019 23:59:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14044 ) Change subject: IMPALA-8160: [DOCS] Document CAST (...FORMAT..) function .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/443/ Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstr...@cloudera.com or on this JIRA: IMPALA-7317 -- To view, visit http://gerrit.cloudera.org:8080/14044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6235ffd03ac56e648552058ff02491a55289c092 Gerrit-Change-Number: 14044 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 09 Aug 2019 23:46:13 + Gerrit-HasComments: No
