[Impala-ASF-CR] IMPALA-8202: Extend query timeout for test mem limit
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16774 ) Change subject: IMPALA-8202: Extend query timeout for test_mem_limit .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic02f73bea528af12053043e0a57b4158532833b4 Gerrit-Change-Number: 16774 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 24 Nov 2020 01:57:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8202: Extend query timeout for test mem limit
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16774 ) Change subject: IMPALA-8202: Extend query timeout for test_mem_limit .. IMPALA-8202: Extend query timeout for test_mem_limit With the current timeout set to 1 sec, we saw flaky failure where the query timed out due to client inactivity. This can happen if the thread keeping it alive fails to execute a fetch within the query timeout period. This patch attempts to fix this flakiness by increasing the timeout period. Testing: Looped the test locally. Change-Id: Ic02f73bea528af12053043e0a57b4158532833b4 Reviewed-on: http://gerrit.cloudera.org:8080/16774 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M tests/custom_cluster/test_admission_controller.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic02f73bea528af12053043e0a57b4158532833b4 Gerrit-Change-Number: 16774 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8202: Extend query timeout for test mem limit
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16774 ) Change subject: IMPALA-8202: Extend query timeout for test_mem_limit .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7719/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic02f73bea528af12053043e0a57b4158532833b4 Gerrit-Change-Number: 16774 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Nov 2020 21:51:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8202: Extend query timeout for test mem limit
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16774 ) Change subject: IMPALA-8202: Extend query timeout for test_mem_limit .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7718/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic02f73bea528af12053043e0a57b4158532833b4 Gerrit-Change-Number: 16774 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Nov 2020 18:59:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8202: Extend query timeout for test mem limit
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16774 ) Change subject: IMPALA-8202: Extend query timeout for test_mem_limit .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6703/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic02f73bea528af12053043e0a57b4158532833b4 Gerrit-Change-Number: 16774 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Nov 2020 18:51:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8202: Extend query timeout for test mem limit
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16774 ) Change subject: IMPALA-8202: Extend query timeout for test_mem_limit .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic02f73bea528af12053043e0a57b4158532833b4 Gerrit-Change-Number: 16774 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Nov 2020 18:51:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8202: Extend query timeout for test mem limit
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16774 ) Change subject: IMPALA-8202: Extend query timeout for test_mem_limit .. Patch Set 2: Code-Review+2 Carrying over +2 -- To view, visit http://gerrit.cloudera.org:8080/16774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic02f73bea528af12053043e0a57b4158532833b4 Gerrit-Change-Number: 16774 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Nov 2020 18:51:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8202: Extend query timeout for test mem limit
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16774 ) Change subject: IMPALA-8202: Extend query timeout for test_mem_limit .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16774/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/16774/1/tests/custom_cluster/test_admission_controller.py@1623 PS1, Line 1623: > flake8: E226 missing whitespace around arithmetic operator Done -- To view, visit http://gerrit.cloudera.org:8080/16774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic02f73bea528af12053043e0a57b4158532833b4 Gerrit-Change-Number: 16774 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Nov 2020 18:51:10 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8202: Extend query timeout for test mem limit
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16774 to look at the new patch set (#2). Change subject: IMPALA-8202: Extend query timeout for test_mem_limit .. IMPALA-8202: Extend query timeout for test_mem_limit With the current timeout set to 1 sec, we saw flaky failure where the query timed out due to client inactivity. This can happen if the thread keeping it alive fails to execute a fetch within the query timeout period. This patch attempts to fix this flakiness by increasing the timeout period. Testing: Looped the test locally. Change-Id: Ic02f73bea528af12053043e0a57b4158532833b4 --- M tests/custom_cluster/test_admission_controller.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/16774/2 -- To view, visit http://gerrit.cloudera.org:8080/16774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic02f73bea528af12053043e0a57b4158532833b4 Gerrit-Change-Number: 16774 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8202: Extend query timeout for test mem limit
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16774 ) Change subject: IMPALA-8202: Extend query timeout for test_mem_limit .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic02f73bea528af12053043e0a57b4158532833b4 Gerrit-Change-Number: 16774 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Nov 2020 18:48:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8202: Extend query timeout for test mem limit
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16774 ) Change subject: IMPALA-8202: Extend query timeout for test_mem_limit .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16774/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/16774/1/tests/custom_cluster/test_admission_controller.py@1623 PS1, Line 1623: / flake8: E226 missing whitespace around arithmetic operator -- To view, visit http://gerrit.cloudera.org:8080/16774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic02f73bea528af12053043e0a57b4158532833b4 Gerrit-Change-Number: 16774 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 23 Nov 2020 18:38:07 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8202: Extend query timeout for test mem limit
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16774 Change subject: IMPALA-8202: Extend query timeout for test_mem_limit .. IMPALA-8202: Extend query timeout for test_mem_limit With the current timeout set to 1 sec, we saw flaky failure where the query timed out due to client inactivity. This can happen if the thread keeping it alive fails to execute a fetch within the query timeout period. This patch attempts to fix this flakiness by increasing the timeout period. Testing: Looped the test locally. Change-Id: Ic02f73bea528af12053043e0a57b4158532833b4 --- M tests/custom_cluster/test_admission_controller.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/16774/1 -- To view, visit http://gerrit.cloudera.org:8080/16774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic02f73bea528af12053043e0a57b4158532833b4 Gerrit-Change-Number: 16774 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig
