[Impala-ASF-CR] IMPALA-8377: bump toolchain version to 107-acaeac961d
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12928 ) Change subject: IMPALA-8377: bump toolchain version to 107-acaeac961d .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ac25aa230b9d2559cd4eb6166ab985b18ef7e2a Gerrit-Change-Number: 12928 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 04 Apr 2019 22:40:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8377: bump toolchain version to 107-acaeac961d
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12928 ) Change subject: IMPALA-8377: bump toolchain version to 107-acaeac961d .. IMPALA-8377: bump toolchain version to 107-acaeac961d This fixes an issue with the previous toolchain version where the Kudu client was broken and caused all binaries to crash on startup due to an issue with linked libstdc++ It also fixes an issue where fastbinary.so wasn't being properly included with Thrift. Testing: - Built successfully on redhat6/7, ubuntu16/18, sles12, debian8 - Built and ran a full core test run with both USE_CDH_KUDU=true/false Change-Id: I4ac25aa230b9d2559cd4eb6166ab985b18ef7e2a Reviewed-on: http://gerrit.cloudera.org:8080/12928 Reviewed-by: Thomas Marshall Tested-by: Impala Public Jenkins --- M bin/impala-config.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Thomas Marshall: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4ac25aa230b9d2559cd4eb6166ab985b18ef7e2a Gerrit-Change-Number: 12928 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8377: bump toolchain version to 107-acaeac961d
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12928 ) Change subject: IMPALA-8377: bump toolchain version to 107-acaeac961d .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2643/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ac25aa230b9d2559cd4eb6166ab985b18ef7e2a Gerrit-Change-Number: 12928 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 04 Apr 2019 18:24:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8377: bump toolchain version to 107-acaeac961d
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12928 ) Change subject: IMPALA-8377: bump toolchain version to 107-acaeac961d .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3983/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/12928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ac25aa230b9d2559cd4eb6166ab985b18ef7e2a Gerrit-Change-Number: 12928 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 04 Apr 2019 17:52:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8377: bump toolchain version to 107-acaeac961d
Hello Lars Volker, Hector Acosta, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12928 to look at the new patch set (#2). Change subject: IMPALA-8377: bump toolchain version to 107-acaeac961d .. IMPALA-8377: bump toolchain version to 107-acaeac961d This fixes an issue with the previous toolchain version where the Kudu client was broken and caused all binaries to crash on startup due to an issue with linked libstdc++ It also fixes an issue where fastbinary.so wasn't being properly included with Thrift. Testing: - Built successfully on redhat6/7, ubuntu16/18, sles12, debian8 - Built and ran a full core test run with both USE_CDH_KUDU=true/false Change-Id: I4ac25aa230b9d2559cd4eb6166ab985b18ef7e2a --- M bin/impala-config.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/12928/2 -- To view, visit http://gerrit.cloudera.org:8080/12928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4ac25aa230b9d2559cd4eb6166ab985b18ef7e2a Gerrit-Change-Number: 12928 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8377: bump toolchain version to 107-acaeac961d
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12928 ) Change subject: IMPALA-8377: bump toolchain version to 107-acaeac961d .. Patch Set 2: Code-Review+2 carrying forward -- To view, visit http://gerrit.cloudera.org:8080/12928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ac25aa230b9d2559cd4eb6166ab985b18ef7e2a Gerrit-Change-Number: 12928 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 04 Apr 2019 17:52:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8377: bump toolchain version to 107-acaeac961d
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12928 ) Change subject: IMPALA-8377: bump toolchain version to 107-acaeac961d .. Patch Set 2: > Seems good to me aside from the conflict with Hector's patch - I > think you are figuring that out with him, right? I confirmed that my patch includes his fix, so he's going to abandon his and we'll submit this one -- To view, visit http://gerrit.cloudera.org:8080/12928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ac25aa230b9d2559cd4eb6166ab985b18ef7e2a Gerrit-Change-Number: 12928 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Thomas Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 04 Apr 2019 17:52:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8377: bump toolchain version to 107-acaeac961d
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12928 ) Change subject: IMPALA-8377: bump toolchain version to 107-acaeac961d .. Patch Set 1: Code-Review+2 Seems good to me aside from the conflict with Hector's patch - I think you are figuring that out with him, right? -- To view, visit http://gerrit.cloudera.org:8080/12928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ac25aa230b9d2559cd4eb6166ab985b18ef7e2a Gerrit-Change-Number: 12928 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 04 Apr 2019 17:43:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8377: bump toolchain version to 107-acaeac961d
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12928 ) Change subject: IMPALA-8377: bump toolchain version to 107-acaeac961d .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2632/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ac25aa230b9d2559cd4eb6166ab985b18ef7e2a Gerrit-Change-Number: 12928 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 04 Apr 2019 00:03:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8377: bump toolchain version to 107-acaeac961d
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12928 Change subject: IMPALA-8377: bump toolchain version to 107-acaeac961d .. IMPALA-8377: bump toolchain version to 107-acaeac961d This fixes an issue with the previous toolchain version where the Kudu client was broken and caused all binaries to crash on startup due to an issue with linked libstdc++ Change-Id: I4ac25aa230b9d2559cd4eb6166ab985b18ef7e2a --- M bin/impala-config.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/12928/1 -- To view, visit http://gerrit.cloudera.org:8080/12928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4ac25aa230b9d2559cd4eb6166ab985b18ef7e2a Gerrit-Change-Number: 12928 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall