[Impala-ASF-CR] IMPALA-8410: enable TestTpcdsInsert by default

2019-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13055 )

Change subject: IMPALA-8410: enable TestTpcdsInsert by default
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/13055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9a279d57ad74de0c77a90dde69e5c4dc563a3f
Gerrit-Change-Number: 13055
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Comment-Date: Wed, 17 Apr 2019 22:10:02 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8410: enable TestTpcdsInsert by default

2019-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/13055 )

Change subject: IMPALA-8410: enable TestTpcdsInsert by default
..

IMPALA-8410: enable TestTpcdsInsert by default

Fix incorrect output to match current behaviour. The test takes
24s on my system but can be run in parallel with other tests.

Change-Id: Ibf9a279d57ad74de0c77a90dde69e5c4dc563a3f
Reviewed-on: http://gerrit.cloudera.org:8080/13055
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M testdata/workloads/tpcds-insert/queries/partitioned-insert.test
M tests/query_test/test_tpcds_queries.py
2 files changed, 512 insertions(+), 33 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/13055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf9a279d57ad74de0c77a90dde69e5c4dc563a3f
Gerrit-Change-Number: 13055
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 


[Impala-ASF-CR] IMPALA-8410: enable TestTpcdsInsert by default

2019-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13055 )

Change subject: IMPALA-8410: enable TestTpcdsInsert by default
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4034/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/13055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9a279d57ad74de0c77a90dde69e5c4dc563a3f
Gerrit-Change-Number: 13055
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Comment-Date: Wed, 17 Apr 2019 17:01:31 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8410: enable TestTpcdsInsert by default

2019-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13055 )

Change subject: IMPALA-8410: enable TestTpcdsInsert by default
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9a279d57ad74de0c77a90dde69e5c4dc563a3f
Gerrit-Change-Number: 13055
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Comment-Date: Wed, 17 Apr 2019 17:01:30 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8410: enable TestTpcdsInsert by default

2019-04-17 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13055 )

Change subject: IMPALA-8410: enable TestTpcdsInsert by default
..


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13055/1/tests/query_test/test_tpcds_queries.py
File tests/query_test/test_tpcds_queries.py:

http://gerrit.cloudera.org:8080/#/c/13055/1/tests/query_test/test_tpcds_queries.py@a519
PS1, Line 519:
I think this is fine as a quick fix for this test, but it would be nice to 
actually be able to run non-"functional-query" tests only in exhaustive, and I 
suspect a bunch more tests are affected by issues like this.

Fwiw, this is already tracked by IMPALA-3947



--
To view, visit http://gerrit.cloudera.org:8080/13055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9a279d57ad74de0c77a90dde69e5c4dc563a3f
Gerrit-Change-Number: 13055
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Comment-Date: Wed, 17 Apr 2019 16:58:13 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8410: enable TestTpcdsInsert by default

2019-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13055 )

Change subject: IMPALA-8410: enable TestTpcdsInsert by default
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/13055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9a279d57ad74de0c77a90dde69e5c4dc563a3f
Gerrit-Change-Number: 13055
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Comment-Date: Wed, 17 Apr 2019 11:01:18 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8410: enable TestTpcdsInsert by default

2019-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13055 )

Change subject: IMPALA-8410: enable TestTpcdsInsert by default
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/2813/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9a279d57ad74de0c77a90dde69e5c4dc563a3f
Gerrit-Change-Number: 13055
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Comment-Date: Wed, 17 Apr 2019 06:46:04 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8410: enable TestTpcdsInsert by default

2019-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13055 )

Change subject: IMPALA-8410: enable TestTpcdsInsert by default
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4032/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/13055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9a279d57ad74de0c77a90dde69e5c4dc563a3f
Gerrit-Change-Number: 13055
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Comment-Date: Wed, 17 Apr 2019 06:13:34 +
Gerrit-HasComments: No