[Impala-ASF-CR] IMPALA-8504: Introduce the new Kudu storage handler

2019-05-23 Thread Thomas Marshall (Code Review) 
Thomas Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13358 )

Change subject: IMPALA-8504: Introduce the new Kudu storage handler
..


Patch Set 6:

If you'll address the previous comment about the JIRA references in the commit 
message, I think this is ready to go in


--
To view, visit http://gerrit.cloudera.org:8080/13358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
Gerrit-Change-Number: 13358
Gerrit-PatchSet: 6
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Comment-Date: Thu, 23 May 2019 20:21:24 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8504: Introduce the new Kudu storage handler

2019-05-22 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13358 )

Change subject: IMPALA-8504: Introduce the new Kudu storage handler
..


Patch Set 6:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3347/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
Gerrit-Change-Number: 13358
Gerrit-PatchSet: 6
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall 
Gerrit-Comment-Date: Thu, 23 May 2019 05:38:07 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8504: Introduce the new Kudu storage handler

2019-05-22 Thread Hao Hao (Code Review) 
Hello Thomas Marshall, Alexey Serbin, Andrew Wong, Adar Dembo, Grant Henke, 
Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13358

to look at the new patch set (#6).

Change subject: IMPALA-8504: Introduce the new Kudu storage handler
..

IMPALA-8504: Introduce the new Kudu storage handler

This commit introduces the new Kudu storage handler
'org.apache.kudu.hive.KuduStorageHandler' that is used in Kudu/HMS
integration. Tables with either the legacy storage handler
'com.cloudera.kudu.hive.KuduStorageHandler' or the new one are now
considered as Kudu tables. The actual work of adopting the new storage
handler will be addressed in a series of follow-up patches, which rely
on it to support Kudu/HMS integration in Impala.

Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
2 files changed, 15 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/13358/6
--
To view, visit http://gerrit.cloudera.org:8080/13358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
Gerrit-Change-Number: 13358
Gerrit-PatchSet: 6
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Thomas Marshall

[Impala-ASF-CR] IMPALA-8504: Introduce the new Kudu storage handler

2019-05-22 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13358 )

Change subject: IMPALA-8504: Introduce the new Kudu storage handler
..


Patch Set 5: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/13358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
Gerrit-Change-Number: 13358
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 13:01:40 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8504: Introduce the new Kudu storage handler

2019-05-21 Thread Andrew Wong (Code Review) 
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13358 )

Change subject: IMPALA-8504: Introduce the new Kudu storage handler
..


Patch Set 5: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13358/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13358/5//COMMIT_MSG@7
PS5, Line 7: IMPALA-8504: Introduce the new Kudu storage handler
nit: IMPALA-4271 may be a more appropriate ticket now?



--
To view, visit http://gerrit.cloudera.org:8080/13358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
Gerrit-Change-Number: 13358
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 22 May 2019 00:47:08 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8504: Introduce the new Kudu storage handler

2019-05-20 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13358 )

Change subject: IMPALA-8504: Introduce the new Kudu storage handler
..


Patch Set 4: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/13358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
Gerrit-Change-Number: 13358
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 20 May 2019 21:34:40 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8504: Introduce the new Kudu storage handler

2019-05-20 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13358 )

Change subject: IMPALA-8504: Introduce the new Kudu storage handler
..


Patch Set 4: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/13358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
Gerrit-Change-Number: 13358
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 20 May 2019 12:55:59 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8504: Introduce the new Kudu storage handler

2019-05-20 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13358 )

Change subject: IMPALA-8504: Introduce the new Kudu storage handler
..


Patch Set 4:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3291/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
Gerrit-Change-Number: 13358
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Mon, 20 May 2019 07:26:30 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8504: Introduce the new Kudu storage handler

2019-05-19 Thread Hao Hao (Code Review) 
Hello Alexey Serbin, Andrew Wong, Adar Dembo, Grant Henke, Impala Public 
Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13358

to look at the new patch set (#4).

Change subject: IMPALA-8504: Introduce the new Kudu storage handler
..

IMPALA-8504: Introduce the new Kudu storage handler

This commit introduces the new Kudu storage handler
'org.apache.kudu.hive.KuduStorageHandler' that is used in Kudu/HMS
integration. Tables with either the legacy storage handler
'com.cloudera.kudu.hive.KuduStorageHandler' or the new one are now
considered as Kudu tables. The actual work of adopting the new storage
handler will be addressed in a series of follow-up patches, which rely
on it to support Kudu/HMS integration in Impala.

Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
2 files changed, 15 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/13358/4
--
To view, visit http://gerrit.cloudera.org:8080/13358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
Gerrit-Change-Number: 13358
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-8504: Introduce the new Kudu storage handler

2019-05-17 Thread Hao Hao (Code Review) 
Hello Alexey Serbin, Andrew Wong, Adar Dembo, Grant Henke, Impala Public 
Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13358

to look at the new patch set (#2).

Change subject: IMPALA-8504: Introduce the new Kudu storage handler
..

IMPALA-8504: Introduce the new Kudu storage handler

This commit introduces the new Kudu storage handler
'org.apache.kudu.hive.KuduStorageHandler' that is used in Kudu/HMS
integration. Tables with either the legacy storage handler
'com.cloudera.kudu.hive.KuduStorageHandler' or the new one are now
considered as Kudu tables. The actual work of adopting the new storage
handler will be addressed in a series of follow-up patches, which rely
on it to support Kudu/HMS integration in Impala.

Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
2 files changed, 15 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/13358/2
--
To view, visit http://gerrit.cloudera.org:8080/13358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
Gerrit-Change-Number: 13358
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-8504: Introduce the new Kudu storage handler

2019-05-17 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13358 )

Change subject: IMPALA-8504: Introduce the new Kudu storage handler
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3277/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
Gerrit-Change-Number: 13358
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 17 May 2019 23:53:35 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8504: Introduce the new Kudu storage handler

2019-05-17 Thread Hao Hao (Code Review) 
Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13358 )

Change subject: IMPALA-8504: Introduce the new Kudu storage handler
..


Patch Set 2:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/13358/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13358/1//COMMIT_MSG@9
PS1, Line 9: commit
> commit
Done


http://gerrit.cloudera.org:8080/#/c/13358/1//COMMIT_MSG@13
PS1, Line 13:  st
> drop
Done


http://gerrit.cloudera.org:8080/#/c/13358/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java:

http://gerrit.cloudera.org:8080/#/c/13358/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@222
PS1, Line 222:   if (KuduTable.KUDU_LEGACY_STORAGE_HANDLER.equals(
> Should this check if it's either format? Or just the new format since the o
This is intentionally to only check the legacy format as this commit is only 
introducing the new storage handler. And there are a series of follow-up 
patches will actual use this storage handler. The motivation is to avoid giant 
patch to review and also hopefully to unblock other's testing work which rely 
on use new storage handler to identify Kudu tables.


http://gerrit.cloudera.org:8080/#/c/13358/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@222
PS1, Line 222:   if (KuduTable.KUDU_LEGACY_STORAGE_HANDLER.equals(
> I'm also curious why new storage handler is not accounted for in this logic
Yeah, this is intentional, as explained above. I will add more detailed 
explanation in the commit msg.


http://gerrit.cloudera.org:8080/#/c/13358/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@265
PS1, Line 265: if (handler != null && 
!handler.equals(KuduTable.KUDU_LEGACY_STORAGE_HANDLER)) {
> Same here.
Same as above comment.


http://gerrit.cloudera.org:8080/#/c/13358/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@270
PS1, Line 270: KuduTable.KUDU_LEGACY_STORAGE_HANDLER);
> Should this be the new format since the old format won't be used to create
Same as above.


http://gerrit.cloudera.org:8080/#/c/13358/1/fe/src/main/java/org/apache/impala/catalog/KuduTable.java
File fe/src/main/java/org/apache/impala/catalog/KuduTable.java:

http://gerrit.cloudera.org:8080/#/c/13358/1/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@74
PS1, Line 74:   // KEY_STORAGE_HANDLER. This is expected to be deprecated 
eventually.
> Is this comment still true? I think we will use KUDU_STORAGE_HANDLER for al
Good catch, you're right.


http://gerrit.cloudera.org:8080/#/c/13358/1/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@79
PS1, Line 79:   // KEY_STORAGE_HANDLER.
> We also don't need to mention HMS integration here.
Done



--
To view, visit http://gerrit.cloudera.org:8080/13358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
Gerrit-Change-Number: 13358
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 17 May 2019 23:28:29 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8504: Introduce the new Kudu storage handler

2019-05-17 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13358 )

Change subject: IMPALA-8504: Introduce the new Kudu storage handler
..


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/13358/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13358/1//COMMIT_MSG@9
PS1, Line 9: commits
commit


http://gerrit.cloudera.org:8080/#/c/13358/1//COMMIT_MSG@13
PS1, Line 13: be
drop


http://gerrit.cloudera.org:8080/#/c/13358/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java:

http://gerrit.cloudera.org:8080/#/c/13358/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@222
PS1, Line 222:   if (KuduTable.KUDU_LEGACY_STORAGE_HANDLER.equals(
> Should this check if it's either format? Or just the new format since the o
I'm also curious why new storage handler is not accounted for in this logic.  
If it's intentional, please add a comment explaining why.



--
To view, visit http://gerrit.cloudera.org:8080/13358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
Gerrit-Change-Number: 13358
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 17 May 2019 17:09:51 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8504: Introduce the new Kudu storage handler

2019-05-17 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13358 )

Change subject: IMPALA-8504: Introduce the new Kudu storage handler
..


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/13358/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java:

http://gerrit.cloudera.org:8080/#/c/13358/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@222
PS1, Line 222:   if (KuduTable.KUDU_LEGACY_STORAGE_HANDLER.equals(
Should this check if it's either format? Or just the new format since the old 
format won't be used to create tables?

You could use KuduTable.isKuduStorageHandler here.


http://gerrit.cloudera.org:8080/#/c/13358/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@265
PS1, Line 265: if (handler != null && 
!handler.equals(KuduTable.KUDU_LEGACY_STORAGE_HANDLER)) {
Same here.


http://gerrit.cloudera.org:8080/#/c/13358/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@270
PS1, Line 270: KuduTable.KUDU_LEGACY_STORAGE_HANDLER);
Should this be the new format since the old format won't be used to create 
tables?


http://gerrit.cloudera.org:8080/#/c/13358/1/fe/src/main/java/org/apache/impala/catalog/KuduTable.java
File fe/src/main/java/org/apache/impala/catalog/KuduTable.java:

http://gerrit.cloudera.org:8080/#/c/13358/1/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@74
PS1, Line 74:   // KEY_STORAGE_HANDLER when Kudu/HMS integration is not enabled.
Is this comment still true? I think we will use KUDU_STORAGE_HANDLER for all 
new tables so we don't need to mention HMS integration.


http://gerrit.cloudera.org:8080/#/c/13358/1/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@79
PS1, Line 79:   // KEY_STORAGE_HANDLER when Kudu/HMS integration is enabled.
We also don't need to mention HMS integration here.



--
To view, visit http://gerrit.cloudera.org:8080/13358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
Gerrit-Change-Number: 13358
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 17 May 2019 13:03:29 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8504: Introduce the new Kudu storage handler

2019-05-17 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13358 )

Change subject: IMPALA-8504: Introduce the new Kudu storage handler
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3261/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
Gerrit-Change-Number: 13358
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 17 May 2019 06:47:33 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8504: Introduce the new Kudu storage handler

2019-05-16 Thread Hao Hao (Code Review) 
Hao Hao has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13358


Change subject: IMPALA-8504: Introduce the new Kudu storage handler
..

IMPALA-8504: Introduce the new Kudu storage handler

This commits introduces the new Kudu storage handler
'org.apache.kudu.hive.KuduStorageHandler' that is used in Kudu/HMS
integration. Tables with either the legacy storage handler
'com.cloudera.kudu.hive.KuduStorageHandler' or the new one are now
considered as Kudu tables. A series of follow-up patches will be rely
on the new storage handler to support Kudu/HMS integration in Impala.

Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
2 files changed, 16 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/13358/1
--
To view, visit http://gerrit.cloudera.org:8080/13358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I75bcd5246005f4e35251aef9219f4d07eeb87dc6
Gerrit-Change-Number: 13358
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao