[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13271 )

Change subject: IMPALA-8512: Disable certain tests on Centos6
..


Patch Set 4: Verified+1

I'm just going to override jenkins on this one - most of the jobs actually 
succeeded so I'm confident that the code change is fine.


--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 08 May 2019 18:16:25 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has removed a vote on this change.

Change subject: IMPALA-8512: Disable certain tests on Centos6
..


Removed Verified-1 by Impala Public Jenkins 
--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/13271 )

Change subject: IMPALA-8512: Disable certain tests on Centos6
..

IMPALA-8512: Disable certain tests on Centos6

The data cache related tests rely on data cache files being created
successfully on local filesystem. The cache initialization may fail
if the cache directory resides on a ext filesystem which is affected
by KUDU-1508 (metadata corruption after hole punching in some files).
On some older versions of Centos6, the tests fail as a result of
this bug.

This change skips these tests if they detect that it's running on
an old system affected by KUDU-1508. This patch also disables a
filesystem-util test which relies on readdir() returning the correct
entries' types. On some older platforms such as Centos6, this feature
may not be fully supported on all filesystems.

Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Reviewed-on: http://gerrit.cloudera.org:8080/13271
Reviewed-by: Impala Public Jenkins 
Tested-by: Tim Armstrong 
---
M be/src/runtime/io/data-cache-test.cc
M be/src/util/filesystem-util-test.cc
M be/src/util/filesystem-util.cc
M be/src/util/filesystem-util.h
M tests/common/environ.py
M tests/common/skip.py
M tests/custom_cluster/test_data_cache.py
7 files changed, 86 insertions(+), 32 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved
  Tim Armstrong: Verified

--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13271 )

Change subject: IMPALA-8512: Disable certain tests on Centos6
..


Patch Set 4:

GVO failed due to IMPALA-8527


--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 08 May 2019 17:54:54 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13271 )

Change subject: IMPALA-8512: Disable certain tests on Centos6
..


Patch Set 4:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4181/


--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 08 May 2019 15:38:37 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13271 )

Change subject: IMPALA-8512: Disable certain tests on Centos6
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4181/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 08 May 2019 05:38:35 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13271 )

Change subject: IMPALA-8512: Disable certain tests on Centos6
..


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4178/


--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 08 May 2019 05:12:38 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13271 )

Change subject: IMPALA-8512: Disable certain tests on Centos6
..


Patch Set 3:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3118/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 08 May 2019 00:01:20 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13271 )

Change subject: IMPALA-8512: Disable certain tests on Centos6
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 07 May 2019 23:17:56 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13271 )

Change subject: IMPALA-8512: Disable certain tests on Centos6
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4178/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 07 May 2019 23:17:57 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Michael Ho (Code Review)
Hello Lars Volker, Tim Armstrong, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13271

to look at the new patch set (#3).

Change subject: IMPALA-8512: Disable certain tests on Centos6
..

IMPALA-8512: Disable certain tests on Centos6

The data cache related tests rely on data cache files being created
successfully on local filesystem. The cache initialization may fail
if the cache directory resides on a ext filesystem which is affected
by KUDU-1508 (metadata corruption after hole punching in some files).
On some older versions of Centos6, the tests fail as a result of
this bug.

This change skips these tests if they detect that it's running on
an old system affected by KUDU-1508. This patch also disables a
filesystem-util test which relies on readdir() returning the correct
entries' types. On some older platforms such as Centos6, this feature
may not be fully supported on all filesystems.

Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
---
M be/src/runtime/io/data-cache-test.cc
M be/src/util/filesystem-util-test.cc
M be/src/util/filesystem-util.cc
M be/src/util/filesystem-util.h
M tests/common/environ.py
M tests/common/skip.py
M tests/custom_cluster/test_data_cache.py
7 files changed, 86 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/13271/3
--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13271 )

Change subject: IMPALA-8512: Disable certain tests on Centos6
..


Patch Set 3: Code-Review+2

Carry Tim's +2


--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 07 May 2019 23:17:15 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13271 )

Change subject: IMPALA-8512: Disable certain tests on Centos6
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 07 May 2019 22:19:33 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13271 )

Change subject: IMPALA-8512: Disable certain tests on Centos6
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3113/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 07 May 2019 22:09:22 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/13271 )

Change subject: IMPALA-8512: Disable certain tests on Centos6
..

IMPALA-8512: Disable certain tests on Centos6

The data cache related tests rely on data cache files being created
successfully on local filesystem. The cache initialization may fail
if the cache directory resides on a ext filesystem which is affected
by KUDU-1508 (metadata corruption after hole punching in some files).
On some older versions of Centos6, the tests fail as a result of
this bug.

This change skips these tests if they detect that it's running on
an old system affected by KUDU-1508. This patch also disables a
filesystem-util test which relies on readdir() returning the correct
entries' types. On some older platforms such as Centos6, this feature
may not be fully supported on all filesystems.

Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
---
M be/src/runtime/io/data-cache-test.cc
M be/src/util/filesystem-util-test.cc
M be/src/util/filesystem-util.cc
M be/src/util/filesystem-util.h
M tests/common/environ.py
M tests/common/skip.py
M tests/custom_cluster/test_data_cache.py
7 files changed, 86 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/13271/2
--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13271 )

Change subject: IMPALA-8512: Disable certain tests on Centos6
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13271/1/tests/common/environ.py
File tests/common/environ.py:

http://gerrit.cloudera.org:8080/#/c/13271/1/tests/common/environ.py@54
PS1, Line 54: IS_BUGGY_EL6_KERNEL = 'el6' in kernel_release and kernel_release 
< '2.6.32-674'
> Yes, it probably requires some more sophisticated parsing to make it more f
There are probably other python modules which allow simple parsing. Otherwise, 
it shouldn't be too hard to parse them via regular expression. Will update the 
patch on it.



--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 07 May 2019 20:14:34 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13271 )

Change subject: IMPALA-8512: Disable certain tests on Centos6
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13271/1/tests/common/environ.py
File tests/common/environ.py:

http://gerrit.cloudera.org:8080/#/c/13271/1/tests/common/environ.py@54
PS1, Line 54: IS_BUGGY_EL6_KERNEL = 'el6' in kernel_release and kernel_release 
< '2.6.32-674'
> Does string comparison of the kernel version always work? As opposed to num
Yes, it probably requires some more sophisticated parsing to make it more 
foolproof but it gets most of what we need for our current testing environment.



--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 07 May 2019 19:56:33 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13271 )

Change subject: IMPALA-8512: Disable certain tests on Centos6
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3108/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 07 May 2019 19:45:43 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13271 )

Change subject: IMPALA-8512: Disable certain tests on Centos6
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13271/1/tests/common/environ.py
File tests/common/environ.py:

http://gerrit.cloudera.org:8080/#/c/13271/1/tests/common/environ.py@54
PS1, Line 54: IS_BUGGY_EL6_KERNEL = 'el6' in kernel_release and kernel_release 
< '2.6.32-674'
Does string comparison of the kernel version always work? As opposed to numeric 
comparison of the components. I guess this is probably close enough for most 
purposes



--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 07 May 2019 19:03:38 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-07 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13271


Change subject: IMPALA-8512: Disable certain tests on Centos6
..

IMPALA-8512: Disable certain tests on Centos6

The data cache related tests rely on data cache files being created
successfully on local filesystem. The cache initialization may fail
if the cache directory resides on a ext filesystem which is affected
by KUDU-1508 (metadata corruption after hole punching in some files).
On some older versions of Centos6, the tests fail as a result of
this bug.

This change skips these tests if they detect that it's running on
an old system affected by KUDU-1508. This patch also disables a
filesystem-util test which relies on readdir() returning the correct
entries' types. On some older platforms such as Centos6, this feature
may not be fully supported on all filesystems.

Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
---
M be/src/runtime/io/data-cache-test.cc
M be/src/util/filesystem-util-test.cc
M be/src/util/filesystem-util.cc
M be/src/util/filesystem-util.h
M tests/common/environ.py
M tests/common/skip.py
M tests/custom_cluster/test_data_cache.py
7 files changed, 79 insertions(+), 32 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/13271/1
--
To view, visit http://gerrit.cloudera.org:8080/13271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbff15415bc690f779a09ec93a7ded8b394eca10
Gerrit-Change-Number: 13271
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho