[Impala-ASF-CR] IMPALA-8534: data cache for dockerised tests
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13934 ) Change subject: IMPALA-8534: data cache for dockerised tests .. IMPALA-8534: data cache for dockerised tests This adds support for the data cache in dockerised clusters in start-impala-cluster.py. It is handled similarly to the log directories - we ensure that a separate data cache directory is created for each container, then mount it at /opt/impala/cache inside the container. This is then enabled by default for the dockerised tests. Testing: Did a dockerised test run. Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 Reviewed-on: http://gerrit.cloudera.org:8080/13934 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M bin/jenkins/dockerized-impala-run-tests.sh M bin/start-impala-cluster.py 2 files changed, 26 insertions(+), 4 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 Gerrit-Change-Number: 13934 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho
[Impala-ASF-CR] IMPALA-8534: data cache for dockerised tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13934 ) Change subject: IMPALA-8534: data cache for dockerised tests .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 Gerrit-Change-Number: 13934 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Tue, 30 Jul 2019 03:59:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8534: data cache for dockerised tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13934 ) Change subject: IMPALA-8534: data cache for dockerised tests .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4683/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 Gerrit-Change-Number: 13934 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Mon, 29 Jul 2019 21:23:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8534: data cache for dockerised tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13934 ) Change subject: IMPALA-8534: data cache for dockerised tests .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 Gerrit-Change-Number: 13934 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Mon, 29 Jul 2019 21:23:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8534: data cache for dockerised tests
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13934 ) Change subject: IMPALA-8534: data cache for dockerised tests .. Patch Set 6: Code-Review+2 Nice. -- To view, visit http://gerrit.cloudera.org:8080/13934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 Gerrit-Change-Number: 13934 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Mon, 29 Jul 2019 21:06:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8534: data cache for dockerised tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13934 ) Change subject: IMPALA-8534: data cache for dockerised tests .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4052/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 Gerrit-Change-Number: 13934 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Sun, 28 Jul 2019 20:12:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8534: data cache for dockerised tests
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13934 to look at the new patch set (#6). Change subject: IMPALA-8534: data cache for dockerised tests .. IMPALA-8534: data cache for dockerised tests This adds support for the data cache in dockerised clusters in start-impala-cluster.py. It is handled similarly to the log directories - we ensure that a separate data cache directory is created for each container, then mount it at /opt/impala/cache inside the container. This is then enabled by default for the dockerised tests. Testing: Did a dockerised test run. Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 --- M bin/jenkins/dockerized-impala-run-tests.sh M bin/start-impala-cluster.py 2 files changed, 26 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/13934/6 -- To view, visit http://gerrit.cloudera.org:8080/13934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 Gerrit-Change-Number: 13934 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho
[Impala-ASF-CR] IMPALA-8534: data cache for dockerised tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13934 ) Change subject: IMPALA-8534: data cache for dockerised tests .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4050/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 Gerrit-Change-Number: 13934 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Sun, 28 Jul 2019 05:15:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8534: data cache for dockerised tests
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13934 to look at the new patch set (#4). Change subject: IMPALA-8534: data cache for dockerised tests .. IMPALA-8534: data cache for dockerised tests This adds support for the data cache in dockerised clusters in start-impala-cluster.py. It is handled similarly to the log directories - we ensure that a separate data cache directory is created for each container, then mount it at /opt/impala/cache inside the container. This is then enabled by default for the dockerised tests. Testing: Did a dockerised test run. Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 --- M bin/jenkins/dockerized-impala-run-tests.sh M bin/start-impala-cluster.py 2 files changed, 26 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/13934/4 -- To view, visit http://gerrit.cloudera.org:8080/13934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 Gerrit-Change-Number: 13934 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho
[Impala-ASF-CR] IMPALA-8534: data cache for dockerised tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13934 ) Change subject: IMPALA-8534: data cache for dockerised tests .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4048/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 Gerrit-Change-Number: 13934 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Sat, 27 Jul 2019 16:53:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8534: data cache for dockerised tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13934 ) Change subject: IMPALA-8534: data cache for dockerised tests .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13934/3/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/13934/3/bin/start-impala-cluster.py@600 PS3, Line 600: d flake8: E126 continuation line over-indented for hanging indent -- To view, visit http://gerrit.cloudera.org:8080/13934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 Gerrit-Change-Number: 13934 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Comment-Date: Sat, 27 Jul 2019 16:12:55 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8534: data cache for dockerised tests
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13934 Change subject: IMPALA-8534: data cache for dockerised tests .. IMPALA-8534: data cache for dockerised tests This adds support for the data cache in dockerised clusters in start-impala-cluster.py. It is handled similarly to the log directories - we ensure that a separate data cache directory is created for each container, then mount it at /opt/impala/cache inside the container. This is then enabled by default for the dockerised tests. Testing: Did a dockerised test run. Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 --- M bin/jenkins/dockerized-impala-run-tests.sh M bin/start-impala-cluster.py 2 files changed, 26 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/13934/3 -- To view, visit http://gerrit.cloudera.org:8080/13934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2c75d4a5c1eea7a540d051bb175537163dec0e29 Gerrit-Change-Number: 13934 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins
