[Impala-ASF-CR] IMPALA-8686: docker entrypoint script execs daemon

2019-07-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13682 )

Change subject: IMPALA-8686: docker entrypoint script execs daemon
..


Patch Set 4: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/13682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifefbe0a926cf9cfb8acbd37c3f691dc28847dd8b
Gerrit-Change-Number: 13682
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Comment-Date: Tue, 16 Jul 2019 06:04:17 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8686: docker entrypoint script execs daemon

2019-07-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/13682 )

Change subject: IMPALA-8686: docker entrypoint script execs daemon
..

IMPALA-8686: docker entrypoint script execs daemon

The script now execs the subprocess, which is required for signals, etc
to be handled correctly.

Change-Id: Ifefbe0a926cf9cfb8acbd37c3f691dc28847dd8b
Reviewed-on: http://gerrit.cloudera.org:8080/13682
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M docker/daemon_entrypoint.sh
1 file changed, 1 insertion(+), 7 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/13682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifefbe0a926cf9cfb8acbd37c3f691dc28847dd8b
Gerrit-Change-Number: 13682
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 


[Impala-ASF-CR] IMPALA-8686: docker entrypoint script execs daemon

2019-07-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13682 )

Change subject: IMPALA-8686: docker entrypoint script execs daemon
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifefbe0a926cf9cfb8acbd37c3f691dc28847dd8b
Gerrit-Change-Number: 13682
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Comment-Date: Mon, 15 Jul 2019 23:48:13 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8686: docker entrypoint script execs daemon

2019-07-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13682 )

Change subject: IMPALA-8686: docker entrypoint script execs daemon
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4601/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/13682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifefbe0a926cf9cfb8acbd37c3f691dc28847dd8b
Gerrit-Change-Number: 13682
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Comment-Date: Mon, 15 Jul 2019 23:48:14 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8686: docker entrypoint script execs daemon

2019-07-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13682 )

Change subject: IMPALA-8686: docker entrypoint script execs daemon
..


Patch Set 3: Code-Review+2

Looks good


--
To view, visit http://gerrit.cloudera.org:8080/13682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifefbe0a926cf9cfb8acbd37c3f691dc28847dd8b
Gerrit-Change-Number: 13682
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Comment-Date: Mon, 15 Jul 2019 23:39:22 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8686: docker entrypoint script execs daemon

2019-06-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13682 )

Change subject: IMPALA-8686: docker entrypoint script execs daemon
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/3694/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/13682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifefbe0a926cf9cfb8acbd37c3f691dc28847dd8b
Gerrit-Change-Number: 13682
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 20 Jun 2019 15:35:19 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8686: docker entrypoint script execs daemon

2019-06-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13682


Change subject: IMPALA-8686: docker entrypoint script execs daemon
..

IMPALA-8686: docker entrypoint script execs daemon

The script now execs the subprocess, which is required for signals, etc
to be handled correctly.

Change-Id: Ifefbe0a926cf9cfb8acbd37c3f691dc28847dd8b
---
M docker/daemon_entrypoint.sh
1 file changed, 1 insertion(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/13682/2
--
To view, visit http://gerrit.cloudera.org:8080/13682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifefbe0a926cf9cfb8acbd37c3f691dc28847dd8b
Gerrit-Change-Number: 13682
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Impala Public Jenkins