[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test Removed the PlannerTestOption of VALIDATE_CARDINALITY in testJoins() and testFkPkJoinDetection() to avoid checking the estimated cardinality which may be slightly different each time due to IMPALA-7608 when an hdfs table without stats is involved in a query. Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Reviewed-on: http://gerrit.cloudera.org:8080/13717 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/test/java/org/apache/impala/planner/PlannerTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 6 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 22:59:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 4: Unrelated tests were flaky. Reverted those changes then will merge again. -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 17:14:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 17:13:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4551/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 17:13:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4546/ -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 06:16:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3748/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 01:21:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4546/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 00:39:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 26 Jun 2019 00:39:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Fang-Yu Rao has posted comments on this change. (
http://gerrit.cloudera.org:8080/13717 )
Change subject: IMPALA-8702: Remove the PlannerTestOption of
VALIDATE_CARDINALITY to avoid a flaky test
..
Patch Set 4:
(3 comments)
> Patch Set 1:
>
> (3 comments)
http://gerrit.cloudera.org:8080/#/c/13717/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java
File fe/src/test/java/org/apache/impala/planner/PlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/13717/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@222
PS1, Line 222: // Skip cardinality validation because some tables do not
have stats
> This comment should be more concise. The comments shouldn't explain the cha
Thanks for the prompt reply! I will modify the comment as suggested.
http://gerrit.cloudera.org:8080/#/c/13717/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@227
PS1, Line 227: @Test
> No need to pass in an empty set when there's an overload that does not requ
Sure. I will use the method that does not require this argument.
http://gerrit.cloudera.org:8080/#/c/13717/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@263
PS1, Line 263: public void testFkPkJoinDetectionWithHDFSNumRowsEstDisabled() {
Thanks Tim! I have removed the cardinality validation here as well.
--
To view, visit http://gerrit.cloudera.org:8080/13717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187
Gerrit-Change-Number: 13717
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao
Gerrit-Reviewer: Bikramjeet Vig
Gerrit-Reviewer: Fang-Yu Rao
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong
Gerrit-Comment-Date: Wed, 26 Jun 2019 00:37:50 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Fang-Yu Rao has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test Removed the PlannerTestOption of VALIDATE_CARDINALITY in testJoins() and testFkPkJoinDetection() to avoid checking the estimated cardinality which may be slightly different each time due to IMPALA-7608 when an hdfs table without stats is involved in a query. Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 --- M fe/src/test/java/org/apache/impala/planner/PlannerTest.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/13717/4 -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13716 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3729/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42400f189644ff1cf080e6afa6dc38cd11a55ea9 Gerrit-Change-Number: 13716 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 24 Jun 2019 23:21:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3728/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 24 Jun 2019 23:20:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13717 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13717/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/13717/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@222 PS1, Line 222: // Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid This comment should be more concise. The comments shouldn't explain the change you made to the code, only the details needed to understand why the code is the way it is now. E.g. this should be some thing like. // Skip cardinality validation because some tables do not have stats and estimated file sizes are non-deterministic. http://gerrit.cloudera.org:8080/#/c/13717/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@227 PS1, Line 227: ImmutableSet.of()); No need to pass in an empty set when there's an overload that does not require this argument to be provided. http://gerrit.cloudera.org:8080/#/c/13717/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@263 PS1, Line 263: PlannerTestOption.VALIDATE_CARDINALITY)); This test may also be non-deterministic, right? Shouldn't we skip cardinality validation? -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 24 Jun 2019 22:50:18 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13715 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3727/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice500b00a520abb0e386e4ffb09a0c3df772f36d Gerrit-Change-Number: 13715 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 24 Jun 2019 22:49:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13716 Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test Removed the PlannerTestOption of VALIDATE_CARDINALITY in testJoins() to avoid checking the estimated cardinality which may be slightly different each time when an hdfs table without stats is involved in a query. Change-Id: I42400f189644ff1cf080e6afa6dc38cd11a55ea9 --- M fe/src/test/java/org/apache/impala/planner/PlannerTest.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/13716/1 -- To view, visit http://gerrit.cloudera.org:8080/13716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I42400f189644ff1cf080e6afa6dc38cd11a55ea9 Gerrit-Change-Number: 13716 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Fang-Yu Rao has abandoned this change. ( http://gerrit.cloudera.org:8080/13716 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/13716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I42400f189644ff1cf080e6afa6dc38cd11a55ea9 Gerrit-Change-Number: 13716 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13717 Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test Removed the PlannerTestOption of VALIDATE_CARDINALITY in testJoins() to avoid checking the estimated cardinality which may be slightly different each time due to IMPALA-7608 when an hdfs table without stats is involved in a query. Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 --- M fe/src/test/java/org/apache/impala/planner/PlannerTest.java 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/13717/1 -- To view, visit http://gerrit.cloudera.org:8080/13717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie7fce59ecef45df7edc71cde1f8166ccfd45d187 Gerrit-Change-Number: 13717 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13714 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3726/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd509d2625de54a5deaf85002bb1500f624c7843 Gerrit-Change-Number: 13714 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 24 Jun 2019 22:38:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Fang-Yu Rao has abandoned this change. ( http://gerrit.cloudera.org:8080/13715 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/13715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ice500b00a520abb0e386e4ffb09a0c3df772f36d Gerrit-Change-Number: 13715 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13715 Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test Removed the PlannerTestOption of VALIDATE_CARDINALITY in testJoins() to avoid checking the estimated cardinality which may be slightly different each time when an hdfs table without stats is involved in a query. Change-Id: Ice500b00a520abb0e386e4ffb09a0c3df772f36d --- M fe/src/test/java/org/apache/impala/planner/PlannerTest.java 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/13715/1 -- To view, visit http://gerrit.cloudera.org:8080/13715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ice500b00a520abb0e386e4ffb09a0c3df772f36d Gerrit-Change-Number: 13715 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Fang-Yu Rao has abandoned this change. ( http://gerrit.cloudera.org:8080/13714 ) Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/13714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ibd509d2625de54a5deaf85002bb1500f624c7843 Gerrit-Change-Number: 13714 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao
[Impala-ASF-CR] IMPALA-8702: Remove the PlannerTestOption of VALIDATE CARDINALITY to avoid a flaky test
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13714 Change subject: IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test .. IMPALA-8702: Remove the PlannerTestOption of VALIDATE_CARDINALITY to avoid a flaky test Removed the PlannerTestOption of VALIDATE_CARDINALITY in testJoins() to avoid checking the estimated cardinality which may be slightly different each time when an hdfs table without stats is involved in a query. Change-Id: Ibd509d2625de54a5deaf85002bb1500f624c7843 --- M fe/src/test/java/org/apache/impala/planner/PlannerTest.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/13714/1 -- To view, visit http://gerrit.cloudera.org:8080/13714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd509d2625de54a5deaf85002bb1500f624c7843 Gerrit-Change-Number: 13714 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao
