[Impala-ASF-CR] IMPALA-8867: Deflake test auto scaling, improve logging

2019-08-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14074 )

Change subject: IMPALA-8867: Deflake test_auto_scaling, improve logging
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/14074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22c43618a40ff197784add69223359e23fa1bdec
Gerrit-Change-Number: 14074
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 16 Aug 2019 01:50:33 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8867: Deflake test auto scaling, improve logging

2019-08-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/14074 )

Change subject: IMPALA-8867: Deflake test_auto_scaling, improve logging
..

IMPALA-8867: Deflake test_auto_scaling, improve logging

test_auto_scaling sometimes failed to reach the required query rate
within the expected time. This change increases the timeout that we wait
for the query rate to increase. It also adds logging for the maximum
query rate observed to help with debugging in case the issue still
occurs.

Testing: I looped this for a day on my desktop box and did not observe
any issues.

Change-Id: I22c43618a40ff197784add69223359e23fa1bdec
Reviewed-on: http://gerrit.cloudera.org:8080/14074
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M tests/custom_cluster/test_auto_scaling.py
1 file changed, 16 insertions(+), 5 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/14074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I22c43618a40ff197784add69223359e23fa1bdec
Gerrit-Change-Number: 14074
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-8867: Deflake test auto scaling, improve logging

2019-08-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14074 )

Change subject: IMPALA-8867: Deflake test_auto_scaling, improve logging
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4803/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/14074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22c43618a40ff197784add69223359e23fa1bdec
Gerrit-Change-Number: 14074
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 15 Aug 2019 21:43:53 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8867: Deflake test auto scaling, improve logging

2019-08-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14074 )

Change subject: IMPALA-8867: Deflake test_auto_scaling, improve logging
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/14074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22c43618a40ff197784add69223359e23fa1bdec
Gerrit-Change-Number: 14074
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 15 Aug 2019 21:43:52 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8867: Deflake test auto scaling, improve logging

2019-08-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14074 )

Change subject: IMPALA-8867: Deflake test_auto_scaling, improve logging
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/14074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22c43618a40ff197784add69223359e23fa1bdec
Gerrit-Change-Number: 14074
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 15 Aug 2019 21:36:53 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8867: Deflake test auto scaling, improve logging

2019-08-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14074 )

Change subject: IMPALA-8867: Deflake test_auto_scaling, improve logging
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4271/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/14074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22c43618a40ff197784add69223359e23fa1bdec
Gerrit-Change-Number: 14074
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 15 Aug 2019 21:32:46 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8867: Deflake test auto scaling, improve logging

2019-08-15 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/14074


Change subject: IMPALA-8867: Deflake test_auto_scaling, improve logging
..

IMPALA-8867: Deflake test_auto_scaling, improve logging

test_auto_scaling sometimes failed to reach the required query rate
within the expected time. This change increases the timeout that we wait
for the query rate to increase. It also adds logging for the maximum
query rate observed to help with debugging in case the issue still
occurs.

Testing: I looped this for a day on my desktop box and did not observe
any issues.

Change-Id: I22c43618a40ff197784add69223359e23fa1bdec
---
M tests/custom_cluster/test_auto_scaling.py
1 file changed, 16 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/14074/1
--
To view, visit http://gerrit.cloudera.org:8080/14074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I22c43618a40ff197784add69223359e23fa1bdec
Gerrit-Change-Number: 14074
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker