[Impala-ASF-CR] IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14423 ) Change subject: IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api .. Patch Set 2: Verified+1 Code-Review+2 Only the commit message was changed since the successful verification, so I submit this without running tests again. -- To view, visit http://gerrit.cloudera.org:8080/14423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice0dfda5ee0ef60c9c208f05b0952555770fc090 Gerrit-Change-Number: 14423 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 15 Oct 2019 10:58:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14423 ) Change subject: IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api .. IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api The previous commit for this Jira serialized the compilation of shaded-deps and ext-data-source to fix flakiness. It looks like this led to a new similar issue related to the parallel compilation of ext-data-source and query-event-hook-api. Similarly to the shaded-deps issue, I try to fix this by adding a fictional dependency (query-event-hook-api -> yarn-extras) to serialize the build. Full Maven dependency graph: fe -> query-event-hook-api -> yarn-extras -> ext-data-source -> shaded-deps-> impala-parent The ordering of query-event-hook-apit, yarn-extras, ext-data-source, and shaded-deps are arbitrary. Change-Id: Ice0dfda5ee0ef60c9c208f05b0952555770fc090 Reviewed-on: http://gerrit.cloudera.org:8080/14423 Reviewed-by: Joe McDonnell Reviewed-by: Csaba Ringhofer Tested-by: Csaba Ringhofer --- M query-event-hook-api/CMakeLists.txt 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Joe McDonnell: Looks good to me, approved Csaba Ringhofer: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ice0dfda5ee0ef60c9c208f05b0952555770fc090 Gerrit-Change-Number: 14423 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14423 ) Change subject: IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice0dfda5ee0ef60c9c208f05b0952555770fc090 Gerrit-Change-Number: 14423 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Mon, 14 Oct 2019 22:53:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14423 ) Change subject: IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice0dfda5ee0ef60c9c208f05b0952555770fc090 Gerrit-Change-Number: 14423 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 14 Oct 2019 19:56:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14423 ) Change subject: IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4789/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice0dfda5ee0ef60c9c208f05b0952555770fc090 Gerrit-Change-Number: 14423 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 14 Oct 2019 16:19:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14423 ) Change subject: IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5087/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice0dfda5ee0ef60c9c208f05b0952555770fc090 Gerrit-Change-Number: 14423 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 14 Oct 2019 15:37:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14423 to look at the new patch set (#2). Change subject: IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api .. IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api The previous commit for this Jira serialized the compilation of shaded-deps and ext-data-source to fix flakiness. It looks like this led to a new similar issue related to the parallel compilation of ext-data-source and query-event-hook-api. Similarly to the shaded-deps issue, I try to fix this by adding a fictional dependency (query-event-hook-api -> yarn-extras) to serialize the build. Full Maven dependency graph: fe -> query-event-hook-api -> yarn-extras -> ext-data-source -> shaded-deps-> impala-parent The ordering of query-event-hook-apit, yarn-extras, ext-data-source, and shaded-deps are arbitrary. Change-Id: Ice0dfda5ee0ef60c9c208f05b0952555770fc090 --- M query-event-hook-api/CMakeLists.txt 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/14423/2 -- To view, visit http://gerrit.cloudera.org:8080/14423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ice0dfda5ee0ef60c9c208f05b0952555770fc090 Gerrit-Change-Number: 14423 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14423 Change subject: IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api .. IMPALA-9008: Serialize Maven invocations to deflake query-event-hook-api The previous commit for this Jira serialized the compilation of shaded-deps and ext-data-source to fix flakiness. It looks like this led to a new similar issue related to the parallel compilation of ext-data-source and query-event-hook-api. Similarly to the shaded-deps issue, I try to fix this by adding a fictional dependency (query-event-hook -> yarn-extras) to serialize the build. Full Maven dependency graph: fe -> query-event-hook -> yarn-extras -> ext-data-source -> shaded-deps-> impala-parent The ordering of query-event-hook, yarn-extras, ext-data-source, and shaded-deps are arbitrary. Change-Id: Ice0dfda5ee0ef60c9c208f05b0952555770fc090 --- M query-event-hook-api/CMakeLists.txt 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/14423/1 -- To view, visit http://gerrit.cloudera.org:8080/14423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ice0dfda5ee0ef60c9c208f05b0952555770fc090 Gerrit-Change-Number: 14423 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer
