[Impala-ASF-CR] IMPALA-9081: fix mt dop validation tests
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14707 ) Change subject: IMPALA-9081: fix mt_dop validation tests .. IMPALA-9081: fix mt_dop validation tests This undoes the hack of pretending that it's not a test environment for that single test. That had side effects, e.g. for the metadata loading path. Instead we have a special flag to enable the validation code in frontend tests. Note that the plans change to include join build sinks as an expected result of undoing the hack. Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f Reviewed-on: http://gerrit.cloudera.org:8080/14707 Reviewed-by: Anurag Mantripragada Reviewed-by: Thomas Tauber-Marshall Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/common/RuntimeEnv.java M fe/src/main/java/org/apache/impala/planner/Planner.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java M testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation-hdfs-num-rows-est-enabled.test M testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test 5 files changed, 87 insertions(+), 52 deletions(-) Approvals: Anurag Mantripragada: Looks good to me, but someone else must approve Thomas Tauber-Marshall: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/14707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f Gerrit-Change-Number: 14707 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-9081: fix mt dop validation tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14707 ) Change subject: IMPALA-9081: fix mt_dop validation tests .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f Gerrit-Change-Number: 14707 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 15 Nov 2019 20:10:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9081: fix mt dop validation tests
Tim Armstrong has removed a vote on this change. Change subject: IMPALA-9081: fix mt_dop validation tests .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/14707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f Gerrit-Change-Number: 14707 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-9081: fix mt dop validation tests
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14707 ) Change subject: IMPALA-9081: fix mt_dop validation tests .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/14707/5/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/14707/5/fe/src/main/java/org/apache/impala/planner/Planner.java@133 PS5, Line 133: !RuntimeEnv.INSTANCE.isTestEnv() > Out of curiosity, why do we do this? We have planner tests that verify plan Yeah exactly, the PARALLELPLANS with the join build sink aren't executable, but we want to continue testing the planner code. -- To view, visit http://gerrit.cloudera.org:8080/14707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f Gerrit-Change-Number: 14707 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 15 Nov 2019 18:32:28 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9081: fix mt dop validation tests
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14707 ) Change subject: IMPALA-9081: fix mt_dop validation tests .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14707/5/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/14707/5/fe/src/main/java/org/apache/impala/planner/Planner.java@133 PS5, Line 133: !RuntimeEnv.INSTANCE.isTestEnv() Out of curiosity, why do we do this? We have planner tests that verify plans that can't actually be generated by real user queries? -- To view, visit http://gerrit.cloudera.org:8080/14707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f Gerrit-Change-Number: 14707 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 15 Nov 2019 18:25:52 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9081: fix mt dop validation tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14707 ) Change subject: IMPALA-9081: fix mt_dop validation tests .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5217/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f Gerrit-Change-Number: 14707 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Fri, 15 Nov 2019 15:38:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9081: fix mt dop validation tests
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14707 ) Change subject: IMPALA-9081: fix mt_dop validation tests .. Patch Set 5: It got stuck generating data, will retry 22:45:08 Executing: create-load-data.sh 22:45:08 Generating HBase data (logging to /home/ubuntu/Impala/logs/data_loading/create-hbase.log)... 08:35:23 Set build name. -- To view, visit http://gerrit.cloudera.org:8080/14707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f Gerrit-Change-Number: 14707 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 15 Nov 2019 15:38:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9081: fix mt dop validation tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14707 ) Change subject: IMPALA-9081: fix mt_dop validation tests .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5216/ -- To view, visit http://gerrit.cloudera.org:8080/14707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f Gerrit-Change-Number: 14707 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Fri, 15 Nov 2019 08:35:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9081: fix mt dop validation tests
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14707 ) Change subject: IMPALA-9081: fix mt_dop validation tests .. Patch Set 5: Code-Review+1 Looks good to me. -- To view, visit http://gerrit.cloudera.org:8080/14707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f Gerrit-Change-Number: 14707 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Fri, 15 Nov 2019 01:27:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9081: fix mt dop validation tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14707 ) Change subject: IMPALA-9081: fix mt_dop validation tests .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5023/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f Gerrit-Change-Number: 14707 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Thu, 14 Nov 2019 23:11:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9081: fix mt dop validation tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14707 ) Change subject: IMPALA-9081: fix mt_dop validation tests .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5022/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f Gerrit-Change-Number: 14707 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Thu, 14 Nov 2019 23:10:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9081: fix mt dop validation tests
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14707 ) Change subject: IMPALA-9081: fix mt_dop validation tests .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5216/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f Gerrit-Change-Number: 14707 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Thu, 14 Nov 2019 22:35:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9081: fix mt dop validation tests
Hello Thomas Tauber-Marshall, Anurag Mantripragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14707 to look at the new patch set (#5). Change subject: IMPALA-9081: fix mt_dop validation tests .. IMPALA-9081: fix mt_dop validation tests This undoes the hack of pretending that it's not a test environment for that single test. That had side effects, e.g. for the metadata loading path. Instead we have a special flag to enable the validation code in frontend tests. Note that the plans change to include join build sinks as an expected result of undoing the hack. Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f --- M fe/src/main/java/org/apache/impala/common/RuntimeEnv.java M fe/src/main/java/org/apache/impala/planner/Planner.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java M testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation-hdfs-num-rows-est-enabled.test M testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test 5 files changed, 87 insertions(+), 52 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/14707/5 -- To view, visit http://gerrit.cloudera.org:8080/14707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f Gerrit-Change-Number: 14707 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-9081: fix mt dop validation tests
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14707 to look at the new patch set (#4). Change subject: IMPALA-9081: fix mt_dop validation tests .. IMPALA-9081: fix mt_dop validation tests This undoes the hack of pretending that it's not a test environment for that single test. That had side effects, e.g. for the metadata loading path. Instead we have a special flag to enable the validation code in frontend tests. Note that the plans change to include join build sinks as an expected result of undoing the hack. Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f --- M fe/src/main/java/org/apache/impala/common/RuntimeEnv.java M fe/src/main/java/org/apache/impala/planner/Planner.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java M testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation-hdfs-num-rows-est-enabled.test M testdata/workloads/functional-planner/queries/PlannerTest/mt-dop-validation.test 5 files changed, 88 insertions(+), 52 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/14707/4 -- To view, visit http://gerrit.cloudera.org:8080/14707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2e8823c562395e13f318d1ad6eed883d2d9d771f Gerrit-Change-Number: 14707 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins
