[Impala-ASF-CR] IMPALA-9090 Add name of table being scanned in HDFS scan node profile
Xiaomeng Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14660 ) Change subject: IMPALA-9090 Add name of table being scanned in HDFS scan node profile .. Patch Set 1: Thanks Tim, I will update patch with Hbase and Kudu change. -- To view, visit http://gerrit.cloudera.org:8080/14660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99 Gerrit-Change-Number: 14660 Gerrit-PatchSet: 1 Gerrit-Owner: Xiaomeng Zhang Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Xiaomeng Zhang Gerrit-Comment-Date: Wed, 13 Nov 2019 18:40:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9090 Add name of table being scanned in HDFS scan node profile
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14660 ) Change subject: IMPALA-9090 Add name of table being scanned in HDFS scan node profile .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/14660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99 Gerrit-Change-Number: 14660 Gerrit-PatchSet: 1 Gerrit-Owner: Xiaomeng Zhang Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Nov 2019 17:14:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9090 Add name of table being scanned in HDFS scan node profile
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14660 ) Change subject: IMPALA-9090 Add name of table being scanned in HDFS scan node profile .. Patch Set 1: I probably should have asked in the JIRA to include it for all scan nodes (Kudu, Hbase, etc). I can start the merge as-is, since this is a good improvement, but I wouldn't mind if you looked at what it would take to add for the other node types. -- To view, visit http://gerrit.cloudera.org:8080/14660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99 Gerrit-Change-Number: 14660 Gerrit-PatchSet: 1 Gerrit-Owner: Xiaomeng Zhang Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 12 Nov 2019 17:14:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9090 Add name of table being scanned in HDFS scan node profile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14660 ) Change subject: IMPALA-9090 Add name of table being scanned in HDFS scan node profile .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4977/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99 Gerrit-Change-Number: 14660 Gerrit-PatchSet: 1 Gerrit-Owner: Xiaomeng Zhang Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 07 Nov 2019 23:34:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9090 Add name of table being scanned in HDFS scan node profile
Xiaomeng Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14660 Change subject: IMPALA-9090 Add name of table being scanned in HDFS scan node profile .. IMPALA-9090 Add name of table being scanned in HDFS scan node profile Before this change, the only way to figure out the table being scanned by a scan node in the profile is to pull the string out of the explain plan or execsummary. This is awkward, both for manual and automated analysis of the profiles. We should include the table name as a string in the SCAN_NODE implementation. After this change, a new line "Table Name: database.table" will be added between line HDFS_SCAN_NODE (id=0) and Hdfs split stats. Manually tested on mini-cluster with hdfs and s3 with file format text and parquet. All have Table Name in HDFS scan node profile. Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99 --- M be/src/exec/hdfs-scan-node-base.cc 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/14660/1 -- To view, visit http://gerrit.cloudera.org:8080/14660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If5da1112bcf38ae55b89eccfd7c7fad860819a99 Gerrit-Change-Number: 14660 Gerrit-PatchSet: 1 Gerrit-Owner: Xiaomeng Zhang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
