[Impala-ASF-CR] IMPALA-9125: generalize finding DataSink from other fragment
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14710 ) Change subject: IMPALA-9125: generalize finding DataSink from other fragment .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c91cadf9ecfde9cc3235bd71412ba10ee37bc4e Gerrit-Change-Number: 14710 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 16 Nov 2019 05:38:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9125: generalize finding DataSink from other fragment
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14710 ) Change subject: IMPALA-9125: generalize finding DataSink from other fragment .. IMPALA-9125: generalize finding DataSink from other fragment This is a minor refactor that makes the existing mechanism for finding PlanRootSink more general: * Status-returning API to reduce boilerplate in caller. * Avoid storing PlanRootSink as a member - this doesn't scale nicely to multiple subclasses. Instead use an accessor method. Change-Id: I3c91cadf9ecfde9cc3235bd71412ba10ee37bc4e Reviewed-on: http://gerrit.cloudera.org:8080/14710 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/runtime/coordinator.cc M be/src/runtime/fragment-instance-state.cc M be/src/runtime/fragment-instance-state.h M be/src/runtime/query-state.cc M be/src/runtime/query-state.h 5 files changed, 26 insertions(+), 22 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3c91cadf9ecfde9cc3235bd71412ba10ee37bc4e Gerrit-Change-Number: 14710 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-9125: generalize finding DataSink from other fragment
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14710 ) Change subject: IMPALA-9125: generalize finding DataSink from other fragment .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c91cadf9ecfde9cc3235bd71412ba10ee37bc4e Gerrit-Change-Number: 14710 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 16 Nov 2019 01:03:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9125: generalize finding DataSink from other fragment
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14710 ) Change subject: IMPALA-9125: generalize finding DataSink from other fragment .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5221/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c91cadf9ecfde9cc3235bd71412ba10ee37bc4e Gerrit-Change-Number: 14710 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 16 Nov 2019 01:03:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9125: generalize finding DataSink from other fragment
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14710 ) Change subject: IMPALA-9125: generalize finding DataSink from other fragment .. Patch Set 2: Hit IMPALA-9161, which isn't related. Will retry. -- To view, visit http://gerrit.cloudera.org:8080/14710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c91cadf9ecfde9cc3235bd71412ba10ee37bc4e Gerrit-Change-Number: 14710 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sat, 16 Nov 2019 01:03:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9125: generalize finding DataSink from other fragment
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14710 ) Change subject: IMPALA-9125: generalize finding DataSink from other fragment .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5218/ -- To view, visit http://gerrit.cloudera.org:8080/14710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c91cadf9ecfde9cc3235bd71412ba10ee37bc4e Gerrit-Change-Number: 14710 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sat, 16 Nov 2019 00:22:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9125: generalize finding DataSink from other fragment
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14710 ) Change subject: IMPALA-9125: generalize finding DataSink from other fragment .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5218/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c91cadf9ecfde9cc3235bd71412ba10ee37bc4e Gerrit-Change-Number: 14710 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 15 Nov 2019 19:48:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9125: generalize finding DataSink from other fragment
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14710 ) Change subject: IMPALA-9125: generalize finding DataSink from other fragment .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c91cadf9ecfde9cc3235bd71412ba10ee37bc4e Gerrit-Change-Number: 14710 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 15 Nov 2019 19:48:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9125: generalize finding DataSink from other fragment
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14710 ) Change subject: IMPALA-9125: generalize finding DataSink from other fragment .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c91cadf9ecfde9cc3235bd71412ba10ee37bc4e Gerrit-Change-Number: 14710 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 15 Nov 2019 19:39:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9125: generalize finding DataSink from other fragment
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14710 ) Change subject: IMPALA-9125: generalize finding DataSink from other fragment .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5027/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c91cadf9ecfde9cc3235bd71412ba10ee37bc4e Gerrit-Change-Number: 14710 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 15 Nov 2019 17:25:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9125: generalize finding DataSink from other fragment
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14710 Change subject: IMPALA-9125: generalize finding DataSink from other fragment .. IMPALA-9125: generalize finding DataSink from other fragment This is a minor refactor that makes the existing mechanism for finding PlanRootSink more general: * Status-returning API to reduce boilerplate in caller. * Avoid storing PlanRootSink as a member - this doesn't scale nicely to multiple subclasses. Instead use an accessor method. Change-Id: I3c91cadf9ecfde9cc3235bd71412ba10ee37bc4e --- M be/src/runtime/coordinator.cc M be/src/runtime/fragment-instance-state.cc M be/src/runtime/fragment-instance-state.h M be/src/runtime/query-state.cc M be/src/runtime/query-state.h 5 files changed, 26 insertions(+), 22 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/14710/1 -- To view, visit http://gerrit.cloudera.org:8080/14710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3c91cadf9ecfde9cc3235bd71412ba10ee37bc4e Gerrit-Change-Number: 14710 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
