[Impala-ASF-CR] IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14697 ) Change subject: IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster .. IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster testdata/bin/kill-hbase.sh currently uses the generic kill-java-service.sh script to kill the region servers, then the master, and then the zookeeper. Recent versions of HBase become unusable after performing this type of shutdown. The master seems to get stuck trying to recover, even after restarting the minicluster. The root cause in HBase is unclear, but HBase provides the stop-hbase.sh script, which does a more graceful shutdown. This switches tesdata/bin/kill-hbase.sh to use this script, which avoids the recovery problems. Testing: - Ran the test-with-docker.py tests (which does a minicluster restart). Before the change, the HBase tests timed out due to HBase getting stuck recovering. After the change, tests ran normally. - Added a minicluster restart after dataload so that this is tested. Change-Id: I67283f9098c73c849023af8bfa7af62308bf3ed3 Reviewed-on: http://gerrit.cloudera.org:8080/14697 Reviewed-by: Vihang Karajgaonkar Tested-by: Impala Public Jenkins --- M testdata/bin/create-load-data.sh M testdata/bin/kill-hbase.sh 2 files changed, 9 insertions(+), 2 deletions(-) Approvals: Vihang Karajgaonkar: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/14697 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I67283f9098c73c849023af8bfa7af62308bf3ed3 Gerrit-Change-Number: 14697 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14697 ) Change subject: IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14697 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67283f9098c73c849023af8bfa7af62308bf3ed3 Gerrit-Change-Number: 14697 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 13 Nov 2019 06:31:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14697 ) Change subject: IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5009/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14697 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67283f9098c73c849023af8bfa7af62308bf3ed3 Gerrit-Change-Number: 14697 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 13 Nov 2019 02:42:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14697 ) Change subject: IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14697 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67283f9098c73c849023af8bfa7af62308bf3ed3 Gerrit-Change-Number: 14697 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 13 Nov 2019 02:05:30 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14697 ) Change subject: IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5206/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14697 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67283f9098c73c849023af8bfa7af62308bf3ed3 Gerrit-Change-Number: 14697 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 13 Nov 2019 02:01:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14697 to look at the new patch set (#2). Change subject: IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster .. IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster testdata/bin/kill-hbase.sh currently uses the generic kill-java-service.sh script to kill the region servers, then the master, and then the zookeeper. Recent versions of HBase become unusable after performing this type of shutdown. The master seems to get stuck trying to recover, even after restarting the minicluster. The root cause in HBase is unclear, but HBase provides the stop-hbase.sh script, which does a more graceful shutdown. This switches tesdata/bin/kill-hbase.sh to use this script, which avoids the recovery problems. Testing: - Ran the test-with-docker.py tests (which does a minicluster restart). Before the change, the HBase tests timed out due to HBase getting stuck recovering. After the change, tests ran normally. - Added a minicluster restart after dataload so that this is tested. Change-Id: I67283f9098c73c849023af8bfa7af62308bf3ed3 --- M testdata/bin/create-load-data.sh M testdata/bin/kill-hbase.sh 2 files changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/14697/2 -- To view, visit http://gerrit.cloudera.org:8080/14697 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I67283f9098c73c849023af8bfa7af62308bf3ed3 Gerrit-Change-Number: 14697 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14697 ) Change subject: IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5008/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14697 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67283f9098c73c849023af8bfa7af62308bf3ed3 Gerrit-Change-Number: 14697 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 12 Nov 2019 21:20:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14697 Change subject: IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster .. IMPALA-9150: Use HBase's stop-hbase.sh script for minicluster testdata/bin/kill-hbase.sh currently uses the generic kill-java-service.sh script to kill the region servers, then the master, and then the zookeeper. Recent versions of HBase become unusable after performing this type of shutdown. The master seems to get stuck trying to recover, even after restarting the minicluster. The root cause in HBase is unclear, but HBase provides the stop-hbase.sh script, which does a more graceful shutdown. This switches tesdata/bin/kill-hbase.sh to use this script, which avoids the recovery problems. Testing: Ran the test-with-docker.py tests (which does a minicluster restart). Before the change, the HBase tests timed out due to HBase getting stuck recovering. After the change, tests ran normally. Change-Id: I67283f9098c73c849023af8bfa7af62308bf3ed3 --- M testdata/bin/kill-hbase.sh 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/14697/1 -- To view, visit http://gerrit.cloudera.org:8080/14697 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I67283f9098c73c849023af8bfa7af62308bf3ed3 Gerrit-Change-Number: 14697 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell