[Impala-ASF-CR] IMPALA-9335 (part 2): Fix rebased KRPC to compile
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15144 ) Change subject: IMPALA-9335 (part 2): Fix rebased KRPC to compile .. IMPALA-9335 (part 2): Fix rebased KRPC to compile This patch applies various fixes to Impala and to the copied Kudu source code in be/src/kudu/* to allow everything to compile. Some highlights of the changes made: - Various Kudu files were removed from compilation due to issues like relying on libraries that Impala does not provide. The linking of some executable is also changed for similar reasons. - The Kudu Cache implementation changed to support unique_ptr, allowing us to remove various uses of MakeScopeExitTrigger. - Some flags that have a DEFINE in both Kudu and Impala are modified to change one of the DEFINEs to a DECLARE. This patch was in part based on the patches that were applied the last time we rebased the Kudu code in IMPALA-7006, and I ensured that all changes from those commits that are still relevant were included here. I also went through all commits that have been applied to the be/src/kudu directory since the last rebase and ensured that all relevant changes from those are included here. Testing: - Passed an exhaustive DEBUG build and a core ASAN build. Change-Id: I1eb4caf927c729109426fb50a28b5e15d6ac46cb Reviewed-on: http://gerrit.cloudera.org:8080/15144 Tested-by: Impala Public Jenkins Reviewed-by: Joe McDonnell --- M be/src/kudu/rpc/CMakeLists.txt M be/src/kudu/rpc/transfer.cc M be/src/kudu/security/CMakeLists.txt M be/src/kudu/security/test/mini_kdc.cc M be/src/kudu/util/CMakeLists.txt M be/src/kudu/util/flags.cc A be/src/kudu/util/kudu_export.h M be/src/kudu/util/logging.cc M be/src/kudu/util/logging.h M be/src/rpc/impala-service-pool.cc M be/src/rpc/impala-service-pool.h M be/src/runtime/io/data-cache.cc M be/src/runtime/io/data-cache.h M be/src/util/webserver.cc M bin/rat_exclude_files.txt M cmake_modules/kudu_cmake_fns.txt M tests/custom_cluster/test_restart_services.py 17 files changed, 177 insertions(+), 86 deletions(-) Approvals: Impala Public Jenkins: Verified Joe McDonnell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1eb4caf927c729109426fb50a28b5e15d6ac46cb Gerrit-Change-Number: 15144 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-9335 (part 2): Fix rebased KRPC to compile
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15144 ) Change subject: IMPALA-9335 (part 2): Fix rebased KRPC to compile .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eb4caf927c729109426fb50a28b5e15d6ac46cb Gerrit-Change-Number: 15144 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 04 Feb 2020 17:17:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9335 (part 2): Fix rebased KRPC to compile
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15144 ) Change subject: IMPALA-9335 (part 2): Fix rebased KRPC to compile .. Patch Set 2: (1 comment) I think I'm ready to +2 unless someone else wants to review. http://gerrit.cloudera.org:8080/#/c/15144/2/be/src/runtime/io/data-cache.cc File be/src/runtime/io/data-cache.cc: http://gerrit.cloudera.org:8080/#/c/15144/2/be/src/runtime/io/data-cache.cc@558 PS2, Line 558: handle.get() > I know. I prefer doing it this way because it makes it more obvious to read UniqueHandle is a bit weird, because it is a unique_ptr without exposing that fact in the type name. I looked through the Kudu codebase, and they always wrap the UniqueHandle in something else. I don't feel too strongly, so let's leave it this way. -- To view, visit http://gerrit.cloudera.org:8080/15144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eb4caf927c729109426fb50a28b5e15d6ac46cb Gerrit-Change-Number: 15144 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 04 Feb 2020 17:13:25 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9335 (part 2): Fix rebased KRPC to compile
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15144 ) Change subject: IMPALA-9335 (part 2): Fix rebased KRPC to compile .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15144/2/be/src/runtime/io/data-cache.cc File be/src/runtime/io/data-cache.cc: http://gerrit.cloudera.org:8080/#/c/15144/2/be/src/runtime/io/data-cache.cc@558 PS2, Line 558: handle.get() > Nit: you don't need the .get() I know. I prefer doing it this way because it makes it more obvious to readers of the code that its a unique_ptr, but I don't feel strongly about it and can remove it if you prefer. -- To view, visit http://gerrit.cloudera.org:8080/15144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eb4caf927c729109426fb50a28b5e15d6ac46cb Gerrit-Change-Number: 15144 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Mon, 03 Feb 2020 22:57:08 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9335 (part 2): Fix rebased KRPC to compile
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15144 ) Change subject: IMPALA-9335 (part 2): Fix rebased KRPC to compile .. Patch Set 2: Code-Review+1 (3 comments) This is looking good to me. I compared the changes in this patch to the existing code in our KRPC. http://gerrit.cloudera.org:8080/#/c/15144/2/be/src/runtime/io/data-cache.cc File be/src/runtime/io/data-cache.cc: http://gerrit.cloudera.org:8080/#/c/15144/2/be/src/runtime/io/data-cache.cc@558 PS2, Line 558: handle.get() Nit: you don't need the .get() http://gerrit.cloudera.org:8080/#/c/15144/2/be/src/runtime/io/data-cache.cc@616 PS2, Line 616: .get() Nit: Don't need the .get() http://gerrit.cloudera.org:8080/#/c/15144/2/be/src/runtime/io/data-cache.cc@649 PS2, Line 649: .get() Nit: don't need the .get() -- To view, visit http://gerrit.cloudera.org:8080/15144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eb4caf927c729109426fb50a28b5e15d6ac46cb Gerrit-Change-Number: 15144 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Mon, 03 Feb 2020 22:44:37 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9335 (part 2): Fix rebased KRPC to compile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15144 ) Change subject: IMPALA-9335 (part 2): Fix rebased KRPC to compile .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/15144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eb4caf927c729109426fb50a28b5e15d6ac46cb Gerrit-Change-Number: 15144 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Sat, 01 Feb 2020 00:00:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9335 (part 2): Fix rebased KRPC to compile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15144 ) Change subject: IMPALA-9335 (part 2): Fix rebased KRPC to compile .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5486/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/15144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eb4caf927c729109426fb50a28b5e15d6ac46cb Gerrit-Change-Number: 15144 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Fri, 31 Jan 2020 19:11:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9335 (part 2): Fix rebased KRPC to compile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15144 ) Change subject: IMPALA-9335 (part 2): Fix rebased KRPC to compile .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5485/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/15144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eb4caf927c729109426fb50a28b5e15d6ac46cb Gerrit-Change-Number: 15144 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Fri, 31 Jan 2020 19:10:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9335 (part 2): Fix rebased KRPC to compile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15144 ) Change subject: IMPALA-9335 (part 2): Fix rebased KRPC to compile .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5574/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eb4caf927c729109426fb50a28b5e15d6ac46cb Gerrit-Change-Number: 15144 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Fri, 31 Jan 2020 19:09:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9335 (part 2): Fix rebased KRPC to compile
Hello Sahil Takiar, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15144 to look at the new patch set (#2). Change subject: IMPALA-9335 (part 2): Fix rebased KRPC to compile .. IMPALA-9335 (part 2): Fix rebased KRPC to compile This patch applies various fixes to Impala and to the copied Kudu source code in be/src/kudu/* to allow everything to compile. Some highlights of the changes made: - Various Kudu files were removed from compilation due to issues like relying on libraries that Impala does not provide. The linking of some executable is also changed for similar reasons. - The Kudu Cache implementation changed to support unique_ptr, allowing us to remove various uses of MakeScopeExitTrigger. - Some flags that have a DEFINE in both Kudu and Impala are modified to change one of the DEFINEs to a DECLARE. This patch was in part based on the patches that were applied the last time we rebased the Kudu code in IMPALA-7006, and I ensured that all changes from those commits that are still relevant were included here. I also went through all commits that have been applied to the be/src/kudu directory since the last rebase and ensured that all relevant changes from those are included here. Testing: - Passed an exhaustive DEBUG build and a core ASAN build. Change-Id: I1eb4caf927c729109426fb50a28b5e15d6ac46cb --- M be/src/kudu/rpc/CMakeLists.txt M be/src/kudu/rpc/transfer.cc M be/src/kudu/security/CMakeLists.txt M be/src/kudu/security/test/mini_kdc.cc M be/src/kudu/util/CMakeLists.txt M be/src/kudu/util/flags.cc A be/src/kudu/util/kudu_export.h M be/src/kudu/util/logging.cc M be/src/kudu/util/logging.h M be/src/rpc/impala-service-pool.cc M be/src/rpc/impala-service-pool.h M be/src/runtime/io/data-cache.cc M be/src/runtime/io/data-cache.h M be/src/util/webserver.cc M bin/rat_exclude_files.txt M cmake_modules/kudu_cmake_fns.txt M tests/custom_cluster/test_restart_services.py 17 files changed, 177 insertions(+), 86 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/15144/2 -- To view, visit http://gerrit.cloudera.org:8080/15144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1eb4caf927c729109426fb50a28b5e15d6ac46cb Gerrit-Change-Number: 15144 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar
[Impala-ASF-CR] IMPALA-9335 (part 2): Fix rebased KRPC to compile
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15144 ) Change subject: IMPALA-9335 (part 2): Fix rebased KRPC to compile .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/5570/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/15144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1eb4caf927c729109426fb50a28b5e15d6ac46cb Gerrit-Change-Number: 15144 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Fri, 31 Jan 2020 17:16:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9335 (part 2): Fix rebased KRPC to compile
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/15144 )
Change subject: IMPALA-9335 (part 2): Fix rebased KRPC to compile
..
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/15144/1/be/src/runtime/io/data-cache.h
File be/src/runtime/io/data-cache.h:
http://gerrit.cloudera.org:8080/#/c/15144/1/be/src/runtime/io/data-cache.h@327
PS1, Line 327: bool HandleExistingEntry(const kudu::Slice& key, const
kudu::Cache::UniqueHandle& handle,
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/15144/1/be/src/runtime/io/data-cache.cc
File be/src/runtime/io/data-cache.cc:
http://gerrit.cloudera.org:8080/#/c/15144/1/be/src/runtime/io/data-cache.cc@446
PS1, Line 446: meta_cache_(kudu::NewCache(capacity_, path_)) {
line too long (116 > 90)
http://gerrit.cloudera.org:8080/#/c/15144/1/be/src/runtime/io/data-cache.cc@553
PS1, Line 553: kudu::Cache::UniqueHandle handle(meta_cache_->Lookup(key,
kudu::Cache::EXPECT_IN_CACHE));
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/15144/1/be/src/runtime/io/data-cache.cc@611
PS1, Line 611: kudu::Cache::UniquePendingHandle
pending_handle(meta_cache_->Allocate(key, sizeof(CacheEntry), charge_len));
line too long (110 > 90)
http://gerrit.cloudera.org:8080/#/c/15144/1/be/src/runtime/io/data-cache.cc@643
PS1, Line 643: kudu::Cache::UniqueHandle handle(meta_cache_->Lookup(key,
kudu::Cache::EXPECT_IN_CACHE));
line too long (93 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/15144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1eb4caf927c729109426fb50a28b5e15d6ac46cb
Gerrit-Change-Number: 15144
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Sahil Takiar
Gerrit-Comment-Date: Fri, 31 Jan 2020 16:57:22 +
Gerrit-HasComments: Yes
