[Impala-ASF-CR] IMPALA-9664: Fix typo in test event processing.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16547 ) Change subject: IMPALA-9664: Fix typo in test_event_processing.py .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34e16f52722ada2334aeb3bbb187c6c6358d20a3 Gerrit-Change-Number: 16547 Gerrit-PatchSet: 3 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 06 Oct 2020 20:52:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9664: Fix typo in test event processing.py
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16547 ) Change subject: IMPALA-9664: Fix typo in test_event_processing.py .. IMPALA-9664: Fix typo in test_event_processing.py The test tries to add src_db within a database object which would fail when the database managed location is present. This test doesn't fail currently in ASF master since the database doesn't have managed location yet. It will start failing once the managed location for databases is available in the toolchain build of Hive. Testing: 1. The test was working before the patch since the managed db location was probably not set and modified line was not getting executed. I made sure the test works with the patch as well. 2. I applied the patch in an environment where managed db location is available and the error disappears. (Although the test fails for another unrelated reason HIVE-23995) so we should be aware of this when the toolchain hive build is bumped up. Change-Id: I34e16f52722ada2334aeb3bbb187c6c6358d20a3 Reviewed-on: http://gerrit.cloudera.org:8080/16547 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M tests/custom_cluster/test_event_processing.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I34e16f52722ada2334aeb3bbb187c6c6358d20a3 Gerrit-Change-Number: 16547 Gerrit-PatchSet: 4 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar
[Impala-ASF-CR] IMPALA-9664: Fix typo in test event processing.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16547 ) Change subject: IMPALA-9664: Fix typo in test_event_processing.py .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34e16f52722ada2334aeb3bbb187c6c6358d20a3 Gerrit-Change-Number: 16547 Gerrit-PatchSet: 3 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 06 Oct 2020 15:26:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9664: Fix typo in test event processing.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16547 ) Change subject: IMPALA-9664: Fix typo in test_event_processing.py .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6519/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34e16f52722ada2334aeb3bbb187c6c6358d20a3 Gerrit-Change-Number: 16547 Gerrit-PatchSet: 3 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 06 Oct 2020 15:26:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9664: Fix typo in test event processing.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16547 ) Change subject: IMPALA-9664: Fix typo in test_event_processing.py .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6514/ -- To view, visit http://gerrit.cloudera.org:8080/16547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34e16f52722ada2334aeb3bbb187c6c6358d20a3 Gerrit-Change-Number: 16547 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 06 Oct 2020 05:06:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9664: Fix typo in test event processing.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16547 ) Change subject: IMPALA-9664: Fix typo in test_event_processing.py .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6514/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34e16f52722ada2334aeb3bbb187c6c6358d20a3 Gerrit-Change-Number: 16547 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Mon, 05 Oct 2020 23:54:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9664: Fix typo in test event processing.py
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16547 ) Change subject: IMPALA-9664: Fix typo in test_event_processing.py .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/7358/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34e16f52722ada2334aeb3bbb187c6c6358d20a3 Gerrit-Change-Number: 16547 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Mon, 05 Oct 2020 22:31:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9664: Fix typo in test event processing.py
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16547 ) Change subject: IMPALA-9664: Fix typo in test_event_processing.py .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34e16f52722ada2334aeb3bbb187c6c6358d20a3 Gerrit-Change-Number: 16547 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Mon, 05 Oct 2020 22:06:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9664: Fix typo in test event processing.py
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16547 Change subject: IMPALA-9664: Fix typo in test_event_processing.py .. IMPALA-9664: Fix typo in test_event_processing.py The test tries to add src_db within a database object which would fail when the database managed location is present. This test doesn't fail currently in ASF master since the database doesn't have managed location yet. It will start failing once the managed location for databases is available in the toolchain build of Hive. Testing: 1. The test was working before the patch since the managed db location was probably not set and modified line was not getting executed. I made sure the test works with the patch as well. 2. I applied the patch in an environment where managed db location is available and the error disappears. (Although the test fails for another unrelated reason HIVE-23995) so we should be aware of this when the toolchain hive build is bumped up. Change-Id: I34e16f52722ada2334aeb3bbb187c6c6358d20a3 --- M tests/custom_cluster/test_event_processing.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/16547/2 -- To view, visit http://gerrit.cloudera.org:8080/16547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I34e16f52722ada2334aeb3bbb187c6c6358d20a3 Gerrit-Change-Number: 16547 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar
