[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16269 ) Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. IMPALA-9909: Print body of http error code in Impala Shell. Make Impala Shell closer to Impyla by printing the body of any http error code message received when using hs2-over-http. The common case is that there is nothing in the body, in which case the behavior is unchanged. TESTING Added a test for the new functionality. Ran all end-to-end tests. Change-Id: Iabc45eda0b87ca694b8359148cda6a7c1d5a8fff Reviewed-on: http://gerrit.cloudera.org:8080/16269 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M shell/ImpalaHttpClient.py M tests/shell/test_shell_interactive.py 2 files changed, 90 insertions(+), 25 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iabc45eda0b87ca694b8359148cda6a7c1d5a8fff Gerrit-Change-Number: 16269 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar
[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16269 ) Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabc45eda0b87ca694b8359148cda6a7c1d5a8fff Gerrit-Change-Number: 16269 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 04 Aug 2020 22:33:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16269 ) Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6223/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabc45eda0b87ca694b8359148cda6a7c1d5a8fff Gerrit-Change-Number: 16269 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 04 Aug 2020 17:19:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16269 ) Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabc45eda0b87ca694b8359148cda6a7c1d5a8fff Gerrit-Change-Number: 16269 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 04 Aug 2020 17:19:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16269 ) Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabc45eda0b87ca694b8359148cda6a7c1d5a8fff Gerrit-Change-Number: 16269 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sahil Takiar Gerrit-Comment-Date: Tue, 04 Aug 2020 16:59:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16269 ) Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6771/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabc45eda0b87ca694b8359148cda6a7c1d5a8fff Gerrit-Change-Number: 16269 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 03 Aug 2020 17:35:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16269 ) Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6770/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabc45eda0b87ca694b8359148cda6a7c1d5a8fff Gerrit-Change-Number: 16269 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 03 Aug 2020 17:31:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16269 ) Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. IMPALA-9909: Print body of http error code in Impala Shell. Make Impala Shell closer to Impyla by printing the body of any http error code message received when using hs2-over-http. The common case is that there is nothing in the body, in which case the behavior is unchanged. TESTING Added a test for the new functionality. Ran all end-to-end tests. Change-Id: Iabc45eda0b87ca694b8359148cda6a7c1d5a8fff --- M shell/ImpalaHttpClient.py M tests/shell/test_shell_interactive.py 2 files changed, 90 insertions(+), 25 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/16269/4 -- To view, visit http://gerrit.cloudera.org:8080/16269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iabc45eda0b87ca694b8359148cda6a7c1d5a8fff Gerrit-Change-Number: 16269 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16269 ) Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/16269/3/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/16269/3/tests/shell/test_shell_interactive.py@84 PS3, Line 84: e flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/16269/3/tests/shell/test_shell_interactive.py@1080 PS3, Line 1080: T flake8: E501 line too long (93 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/16269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabc45eda0b87ca694b8359148cda6a7c1d5a8fff Gerrit-Change-Number: 16269 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 03 Aug 2020 17:02:54 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16269 Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. IMPALA-9909: Print body of http error code in Impala Shell. Make Impala Shell closer to Impyla by printing the body of any http error code message received when using hs2-over-http. The common case is that there is nothing in the body, in which case the behavior is unchanged. TESTING Added a test for the new functionality. Ran all end-to-end tests. Change-Id: Iabc45eda0b87ca694b8359148cda6a7c1d5a8fff --- M shell/ImpalaHttpClient.py M tests/shell/test_shell_interactive.py 2 files changed, 88 insertions(+), 25 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/16269/3 -- To view, visit http://gerrit.cloudera.org:8080/16269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iabc45eda0b87ca694b8359148cda6a7c1d5a8fff Gerrit-Change-Number: 16269 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Sherman
