[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-08-06 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/16259 )

Change subject: IMPALA-9963: Implement ds_kll_n() function
..

IMPALA-9963: Implement ds_kll_n() function

This function receives a serialized Apache DataSketches KLL sketch
and returns how many input values were fed into this sketch.

Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
Reviewed-on: http://gerrit.cloudera.org:8080/16259
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M be/src/exprs/datasketches-common.h
M be/src/exprs/datasketches-functions-ir.cc
M be/src/exprs/datasketches-functions.h
M common/function-registry/impala_functions.py
M testdata/workloads/functional-query/queries/QueryTest/datasketches-kll.test
5 files changed, 56 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/16259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
Gerrit-Change-Number: 16259
Gerrit-PatchSet: 6
Gerrit-Owner: Gabor Kaszab 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-08-06 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16259 )

Change subject: IMPALA-9963: Implement ds_kll_n() function
..


Patch Set 5: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/16259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
Gerrit-Change-Number: 16259
Gerrit-PatchSet: 5
Gerrit-Owner: Gabor Kaszab 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 06 Aug 2020 19:15:03 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-08-06 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16259 )

Change subject: IMPALA-9963: Implement ds_kll_n() function
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
Gerrit-Change-Number: 16259
Gerrit-PatchSet: 5
Gerrit-Owner: Gabor Kaszab 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 06 Aug 2020 14:01:01 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-08-06 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16259 )

Change subject: IMPALA-9963: Implement ds_kll_n() function
..


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6237/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/16259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
Gerrit-Change-Number: 16259
Gerrit-PatchSet: 5
Gerrit-Owner: Gabor Kaszab 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 06 Aug 2020 14:01:02 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-08-06 Thread Csaba Ringhofer (Code Review) 
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16259 )

Change subject: IMPALA-9963: Implement ds_kll_n() function
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
Gerrit-Change-Number: 16259
Gerrit-PatchSet: 4
Gerrit-Owner: Gabor Kaszab 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 06 Aug 2020 13:06:07 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-08-06 Thread Gabor Kaszab (Code Review) 
Gabor Kaszab has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16259 )

Change subject: IMPALA-9963: Implement ds_kll_n() function
..


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16259/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16259/1//COMMIT_MSG@9
PS1, Line 9:
> I think this should be in singular.
Done


http://gerrit.cloudera.org:8080/#/c/16259/4/be/src/exprs/datasketches-functions-ir.cc
File be/src/exprs/datasketches-functions-ir.cc:

http://gerrit.cloudera.org:8080/#/c/16259/4/be/src/exprs/datasketches-functions-ir.cc@70
PS4, Line 70:   return sketch.get_n();
> A try-catch block could be added to be sure.
get_n() doesn't throw, it simply returns a member variable.
https://github.com/apache/impala/blob/master/be/src/thirdparty/datasketches/kll_sketch_impl.hpp#L232



--
To view, visit http://gerrit.cloudera.org:8080/16259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
Gerrit-Change-Number: 16259
Gerrit-PatchSet: 4
Gerrit-Owner: Gabor Kaszab 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 06 Aug 2020 06:11:08 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-08-05 Thread Csaba Ringhofer (Code Review) 
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16259 )

Change subject: IMPALA-9963: Implement ds_kll_n() function
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16259/4/be/src/exprs/datasketches-functions-ir.cc
File be/src/exprs/datasketches-functions-ir.cc:

http://gerrit.cloudera.org:8080/#/c/16259/4/be/src/exprs/datasketches-functions-ir.cc@70
PS4, Line 70:   return sketch.get_n();
A try-catch block could be added to be sure.



--
To view, visit http://gerrit.cloudera.org:8080/16259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
Gerrit-Change-Number: 16259
Gerrit-PatchSet: 4
Gerrit-Owner: Gabor Kaszab 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 05 Aug 2020 14:53:23 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-08-05 Thread Adam Tamas (Code Review) 
Adam Tamas has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16259 )

Change subject: IMPALA-9963: Implement ds_kll_n() function
..


Patch Set 4: Code-Review+1

LGTM!


--
To view, visit http://gerrit.cloudera.org:8080/16259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
Gerrit-Change-Number: 16259
Gerrit-PatchSet: 4
Gerrit-Owner: Gabor Kaszab 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 05 Aug 2020 12:28:42 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-08-04 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16259 )

Change subject: IMPALA-9963: Implement ds_kll_n() function
..


Patch Set 4:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/6779/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/16259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
Gerrit-Change-Number: 16259
Gerrit-PatchSet: 4
Gerrit-Owner: Gabor Kaszab 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Tue, 04 Aug 2020 10:05:04 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-08-04 Thread Gabor Kaszab (Code Review) 
Hello Adam Tamas, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16259

to look at the new patch set (#4).

Change subject: IMPALA-9963: Implement ds_kll_n() function
..

IMPALA-9963: Implement ds_kll_n() function

This function receives a serialized Apache DataSketches KLL sketch
and returns how many input values were fed into this sketch.

Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
---
M be/src/exprs/datasketches-common.h
M be/src/exprs/datasketches-functions-ir.cc
M be/src/exprs/datasketches-functions.h
M common/function-registry/impala_functions.py
M testdata/workloads/functional-query/queries/QueryTest/datasketches-kll.test
5 files changed, 56 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/16259/4
--
To view, visit http://gerrit.cloudera.org:8080/16259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
Gerrit-Change-Number: 16259
Gerrit-PatchSet: 4
Gerrit-Owner: Gabor Kaszab 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-07-31 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16259 )

Change subject: IMPALA-9963: Implement ds_kll_n() function
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/6748/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/16259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
Gerrit-Change-Number: 16259
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 31 Jul 2020 10:07:13 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-07-31 Thread Gabor Kaszab (Code Review) 
Hello Adam Tamas, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16259

to look at the new patch set (#2).

Change subject: IMPALA-9963: Implement ds_kll_n() function
..

IMPALA-9963: Implement ds_kll_n() function

This function receives a serialized Apache DataSketches KLL sketch
and returns how many input values were fed into this sketch.

Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
---
M be/src/exprs/datasketches-common.h
M be/src/exprs/datasketches-functions-ir.cc
M be/src/exprs/datasketches-functions.h
M common/function-registry/impala_functions.py
M testdata/workloads/functional-query/queries/QueryTest/datasketches-kll.test
5 files changed, 56 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/16259/2
--
To view, visit http://gerrit.cloudera.org:8080/16259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
Gerrit-Change-Number: 16259
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-07-30 Thread Adam Tamas (Code Review) 
Adam Tamas has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16259 )

Change subject: IMPALA-9963: Implement ds_kll_n() function
..


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16259/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16259/1//COMMIT_MSG@9
PS1, Line 9: s
I think this should be in singular.



--
To view, visit http://gerrit.cloudera.org:8080/16259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
Gerrit-Change-Number: 16259
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab 
Gerrit-Reviewer: Adam Tamas 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 30 Jul 2020 15:13:25 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-07-30 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16259 )

Change subject: IMPALA-9963: Implement ds_kll_n() function
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/6739/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/16259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
Gerrit-Change-Number: 16259
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 30 Jul 2020 13:34:18 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-07-30 Thread Gabor Kaszab (Code Review) 
Gabor Kaszab has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/16259


Change subject: IMPALA-9963: Implement ds_kll_n() function
..

IMPALA-9963: Implement ds_kll_n() function

This functions receives a serialized Apache DataSketches KLL sketch
and returns how many input values were fed into this sketch.

Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
---
M be/src/exprs/datasketches-functions-ir.cc
M be/src/exprs/datasketches-functions.h
M common/function-registry/impala_functions.py
M testdata/workloads/functional-query/queries/QueryTest/datasketches-kll.test
4 files changed, 55 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/16259/1
--
To view, visit http://gerrit.cloudera.org:8080/16259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I166e87a468e68e888ac15fca7429ac2552dbb781
Gerrit-Change-Number: 16259
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab