[Impala-ASF-CR] Ignore flake8 W503 about breaking before operators
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11196 ) Change subject: Ignore flake8 W503 about breaking before operators .. Ignore flake8 W503 about breaking before operators PEP8 now reads that breaking before or after binary operators is fine, and gives the rationale: But this can hurt readability in two ways: the operators tend to get scattered across different columns on the screen, and each operator is moved away from its operand and onto the previous line. Change-Id: Ieedde356f613ce57caf3fe190fb44e0404337f97 Reviewed-on: http://gerrit.cloudera.org:8080/11196 Reviewed-by: Jim Apple Tested-by: Impala Public Jenkins --- M setup.cfg 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jim Apple: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ieedde356f613ce57caf3fe190fb44e0404337f97 Gerrit-Change-Number: 11196 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Ignore flake8 W503 about breaking before operators
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11196 ) Change subject: Ignore flake8 W503 about breaking before operators .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieedde356f613ce57caf3fe190fb44e0404337f97 Gerrit-Change-Number: 11196 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 13 Aug 2018 19:39:37 + Gerrit-HasComments: No
[Impala-ASF-CR] Ignore flake8 W503 about breaking before operators
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11196 ) Change subject: Ignore flake8 W503 about breaking before operators .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2984/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/11196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieedde356f613ce57caf3fe190fb44e0404337f97 Gerrit-Change-Number: 11196 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 13 Aug 2018 16:27:56 + Gerrit-HasComments: No
[Impala-ASF-CR] Ignore flake8 W503 about breaking before operators
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11196 ) Change subject: Ignore flake8 W503 about breaking before operators .. Patch Set 2: Code-Review+2 carry Tim's & Michael's -- To view, visit http://gerrit.cloudera.org:8080/11196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieedde356f613ce57caf3fe190fb44e0404337f97 Gerrit-Change-Number: 11196 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 13 Aug 2018 16:27:23 + Gerrit-HasComments: No
[Impala-ASF-CR] Ignore flake8 W503 about breaking before operators
Hello Michael Brown, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11196 to look at the new patch set (#2). Change subject: Ignore flake8 W503 about breaking before operators .. Ignore flake8 W503 about breaking before operators PEP8 now reads that breaking before or after binary operators is fine, and gives the rationale: But this can hurt readability in two ways: the operators tend to get scattered across different columns on the screen, and each operator is moved away from its operand and onto the previous line. Change-Id: Ieedde356f613ce57caf3fe190fb44e0404337f97 --- M setup.cfg 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/11196/2 -- To view, visit http://gerrit.cloudera.org:8080/11196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieedde356f613ce57caf3fe190fb44e0404337f97 Gerrit-Change-Number: 11196 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Ignore flake8 W503 about breaking before operators
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11196 ) Change subject: Ignore flake8 W503 about breaking before operators .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieedde356f613ce57caf3fe190fb44e0404337f97 Gerrit-Change-Number: 11196 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 13 Aug 2018 16:19:30 + Gerrit-HasComments: No
[Impala-ASF-CR] Ignore flake8 W503 about breaking before operators
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11196 ) Change subject: Ignore flake8 W503 about breaking before operators .. Patch Set 1: Code-Review+1 I'll give Mike a chance to look but this makes sense to me -- To view, visit http://gerrit.cloudera.org:8080/11196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieedde356f613ce57caf3fe190fb44e0404337f97 Gerrit-Change-Number: 11196 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 13 Aug 2018 16:17:31 + Gerrit-HasComments: No
[Impala-ASF-CR] Ignore flake8 W503 about breaking before operators
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11196 ) Change subject: Ignore flake8 W503 about breaking before operators .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/301/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieedde356f613ce57caf3fe190fb44e0404337f97 Gerrit-Change-Number: 11196 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Sun, 12 Aug 2018 18:22:47 + Gerrit-HasComments: No
[Impala-ASF-CR] Ignore flake8 W503 about breaking before operators
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11196 Change subject: Ignore flake8 W503 about breaking before operators .. Ignore flake8 W503 about breaking before operators PEP8 now reads that breaking before or after binary operators is fine, and gives the rationale: But this can hurt readability in two ways: the operators tend to get scattered across different columns on the screen, and each operator is moved away from its operand and onto the previous line. Change-Id: Ieedde356f613ce57caf3fe190fb44e0404337f97 --- M setup.cfg 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/11196/1 -- To view, visit http://gerrit.cloudera.org:8080/11196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ieedde356f613ce57caf3fe190fb44e0404337f97 Gerrit-Change-Number: 11196 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple
