[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12723 ) Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script This also changes the behavior to always use DEBIAN_FRONTEND=noninteractive even for interactive terminals. Change-Id: Ifab2f56d3e119e4e73685c3cbd5249760ceb33ac Reviewed-on: http://gerrit.cloudera.org:8080/12723 Reviewed-by: Joe McDonnell Tested-by: Impala Public Jenkins --- M bin/bootstrap_system.sh 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifab2f56d3e119e4e73685c3cbd5249760ceb33ac Gerrit-Change-Number: 12723 Gerrit-PatchSet: 3 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12723 ) Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifab2f56d3e119e4e73685c3cbd5249760ceb33ac Gerrit-Change-Number: 12723 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 27 Mar 2019 00:42:00 + Gerrit-HasComments: No
[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12723 ) Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3958/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/12723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifab2f56d3e119e4e73685c3cbd5249760ceb33ac Gerrit-Change-Number: 12723 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 26 Mar 2019 20:14:54 + Gerrit-HasComments: No
[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12723 ) Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2446/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifab2f56d3e119e4e73685c3cbd5249760ceb33ac Gerrit-Change-Number: 12723 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Fri, 15 Mar 2019 21:36:00 + Gerrit-HasComments: No
[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12723 ) Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Patch Set 2: Code-Review+2 Thanks! -- To view, visit http://gerrit.cloudera.org:8080/12723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifab2f56d3e119e4e73685c3cbd5249760ceb33ac Gerrit-Change-Number: 12723 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Fri, 15 Mar 2019 20:27:06 + Gerrit-HasComments: No
[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script
Hector Acosta has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12723 ) Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script This also changes the behavior to always use DEBIAN_FRONTEND=noninteractive even for interactive terminals. Change-Id: Ifab2f56d3e119e4e73685c3cbd5249760ceb33ac --- M bin/bootstrap_system.sh 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/12723/2 -- To view, visit http://gerrit.cloudera.org:8080/12723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifab2f56d3e119e4e73685c3cbd5249760ceb33ac Gerrit-Change-Number: 12723 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12723 ) Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Patch Set 1: > > (1 comment) > > > > Let me know what you think. If we go with always using > > DEBIAN_FRONTEND=noninteractive, then please note that in the > commit > > message. > > I can confirm that with the current package listing, on an ubuntu > 16.04 docker image the script behaves the same way before and after > this patch (no interactive prompts on apt-get). > > Personally, I prefer to export DEBIAN_FRONTEND=noninteractive in > the interactive terminal case since > a) we're already assuming that this script can be used by automated > scripts (ex. docker/entrypoint.sh) > b) we already perform system-wide configuration changes (postgres, > ntp, etc.) so presumably if in the future we add a dependency that > does require user interaction we can modify the configuration files > as we do now (or revisit this patch altogether :-). Sounds good, we'll use DEBIAN_FRONTEND=noninteractive always. Can you add one line to the commit message documenting this. Something like: "This also changes the behavior to always use DEBIAN_FRONTEND=noninteractive even for interactive terminals." With that change, I'm ready to +2. -- To view, visit http://gerrit.cloudera.org:8080/12723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifab2f56d3e119e4e73685c3cbd5249760ceb33ac Gerrit-Change-Number: 12723 Gerrit-PatchSet: 1 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Thu, 14 Mar 2019 01:03:45 + Gerrit-HasComments: No
[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12723 ) Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Patch Set 1: > (1 comment) > > Let me know what you think. If we go with always using > DEBIAN_FRONTEND=noninteractive, then please note that in the commit > message. I can confirm that with the current package listing, on an ubuntu 16.04 docker image the script behaves the same way before and after this patch (no interactive prompts on apt-get). Personally, I prefer to export DEBIAN_FRONTEND=noninteractive in the interactive terminal case since a) we're already assuming that this script can be used by automated scripts (ex. docker/entrypoint.sh) b) we already perform system-wide configuration changes (postgres, ntp, etc.) so presumably if in the future we add a dependency that does require user interaction we can modify the configuration files as we do now (or revisit this patch altogether :-). -- To view, visit http://gerrit.cloudera.org:8080/12723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifab2f56d3e119e4e73685c3cbd5249760ceb33ac Gerrit-Change-Number: 12723 Gerrit-PatchSet: 1 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 13 Mar 2019 22:42:18 + Gerrit-HasComments: No
[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12723 ) Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Patch Set 1: (1 comment) Let me know what you think. If we go with always using DEBIAN_FRONTEND=noninteractive, then please note that in the commit message. http://gerrit.cloudera.org:8080/#/c/12723/1/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12723/1/bin/bootstrap_system.sh@101 PS1, Line 101: export DEBIAN_FRONTEND=noninteractive This is not quite identical. Previously, we were setting this if we are not on an interactive terminal. Now we are always setting it. I think this is probably a good thing to use DEBIAN_FRONTEND=noninteractive always. I haven't run this recently, but I think maybe kerberos asks about certain settings. I think it is better for this script to avoid needing manual interaction beyond the first prompt. If we wanted to maintain the old way, we could check "if [[ ! -t 1 ]]" or whatnot. -- To view, visit http://gerrit.cloudera.org:8080/12723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifab2f56d3e119e4e73685c3cbd5249760ceb33ac Gerrit-Change-Number: 12723 Gerrit-PatchSet: 1 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 13 Mar 2019 18:15:52 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12723 ) Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2411/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifab2f56d3e119e4e73685c3cbd5249760ceb33ac Gerrit-Change-Number: 12723 Gerrit-PatchSet: 1 Gerrit-Owner: Hector Acosta Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 12 Mar 2019 16:34:34 + Gerrit-HasComments: No
[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12723 Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script Change-Id: Ifab2f56d3e119e4e73685c3cbd5249760ceb33ac --- M bin/bootstrap_system.sh 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/12723/1 -- To view, visit http://gerrit.cloudera.org:8080/12723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifab2f56d3e119e4e73685c3cbd5249760ceb33ac Gerrit-Change-Number: 12723 Gerrit-PatchSet: 1 Gerrit-Owner: Hector Acosta
