[Impala-ASF-CR] Revert "IMPALA-5393. Use THREAD LOCAL state for regexp"

2019-03-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12791 )

Change subject: Revert "IMPALA-5393. Use THREAD_LOCAL state for regexp"
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/2464/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/12791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id35a90a58e3f775031a0f147b042ccd46d77e24b
Gerrit-Change-Number: 12791
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 19 Mar 2019 15:35:43 +
Gerrit-HasComments: No


[Impala-ASF-CR] Revert "IMPALA-5393. Use THREAD LOCAL state for regexp"

2019-03-19 Thread Lars Volker (Code Review)
Lars Volker has created a revert of this change. ( 
http://gerrit.cloudera.org:8080/12791 )

Change subject: Revert "IMPALA-5393. Use THREAD_LOCAL state for regexp"
..


Uploaded patch set 1.
--
To view, visit http://gerrit.cloudera.org:8080/12791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: revert
Gerrit-Change-Id: Id35a90a58e3f775031a0f147b042ccd46d77e24b
Gerrit-Change-Number: 12791
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Todd Lipcon 


[Impala-ASF-CR] Revert "IMPALA-5393. Use THREAD LOCAL state for regexp"

2019-03-19 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/12791 )

Change subject: Revert "IMPALA-5393. Use THREAD_LOCAL state for regexp"
..

Revert "IMPALA-5393. Use THREAD_LOCAL state for regexp"

This depends on a change which switches to a toolchain version that does not 
have packages for Ubuntu 18.04. Reverting both now to unblock everyone.

This reverts commit 6e8c330f40da087ca0d8ba844cd9d97a8e60ff67.

Change-Id: Id35a90a58e3f775031a0f147b042ccd46d77e24b
Reviewed-on: http://gerrit.cloudera.org:8080/12791
Reviewed-by: Lars Volker 
Tested-by: Lars Volker 
---
M be/src/exprs/string-functions-ir.cc
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Lars Volker: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/12791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id35a90a58e3f775031a0f147b042ccd46d77e24b
Gerrit-Change-Number: 12791
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Todd Lipcon 


[Impala-ASF-CR] Revert "IMPALA-5393. Use THREAD LOCAL state for regexp"

2019-03-19 Thread Lars Volker (Code Review)
Hello Todd Lipcon, Impala Public Jenkins,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/12791

to review the following change.


Change subject: Revert "IMPALA-5393. Use THREAD_LOCAL state for regexp"
..

Revert "IMPALA-5393. Use THREAD_LOCAL state for regexp"

This depends on a change which switches to a toolchain version that does not 
have packages for Ubuntu 18.04. Reverting both now to unblock everyone.

This reverts commit 6e8c330f40da087ca0d8ba844cd9d97a8e60ff67.

Change-Id: Id35a90a58e3f775031a0f147b042ccd46d77e24b
---
M be/src/exprs/string-functions-ir.cc
1 file changed, 6 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/12791/1
--
To view, visit http://gerrit.cloudera.org:8080/12791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id35a90a58e3f775031a0f147b042ccd46d77e24b
Gerrit-Change-Number: 12791
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Todd Lipcon 


[Impala-ASF-CR] Revert "IMPALA-5393. Use THREAD LOCAL state for regexp"

2019-03-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12791 )

Change subject: Revert "IMPALA-5393. Use THREAD_LOCAL state for regexp"
..


Patch Set 1: Verified+1 Code-Review+2

Clean revert.


--
To view, visit http://gerrit.cloudera.org:8080/12791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id35a90a58e3f775031a0f147b042ccd46d77e24b
Gerrit-Change-Number: 12791
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 19 Mar 2019 14:52:30 +
Gerrit-HasComments: No