[Impala-ASF-CR] Revert "IMPALA-8146: Remove make {debug,release,asan}.sh"

2019-02-01 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12335 )

Change subject: Revert "IMPALA-8146: Remove make_{debug,release,asan}.sh"
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/1962/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/12335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcb921224071eef2dc77cf7b9f4c618f88aaa7c1
Gerrit-Change-Number: 12335
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 01 Feb 2019 20:14:52 +
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-8146: Remove make {debug,release,asan}.sh"

2019-02-01 Thread Michael Ho (Code Review) 
Michael Ho has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/12335 )

Change subject: Revert "IMPALA-8146: Remove make_{debug,release,asan}.sh"
..

Revert "IMPALA-8146: Remove make_{debug,release,asan}.sh"

This reverts commit e8ea4b0525fb3223da9291775eff4b7fbd15c547.
Apparently some users of Impala have some workflow which rely
on these scripts. Reverting this change to unblock those users.

Change-Id: Ibcb921224071eef2dc77cf7b9f4c618f88aaa7c1
Reviewed-on: http://gerrit.cloudera.org:8080/12335
Reviewed-by: Philip Zeyliger 
Tested-by: Michael Ho 
---
A bin/make_asan.sh
A bin/make_debug.sh
A bin/make_release.sh
3 files changed, 60 insertions(+), 0 deletions(-)

Approvals:
  Philip Zeyliger: Looks good to me, approved
  Michael Ho: Verified

--
To view, visit http://gerrit.cloudera.org:8080/12335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcb921224071eef2dc77cf7b9f4c618f88aaa7c1
Gerrit-Change-Number: 12335
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] Revert "IMPALA-8146: Remove make {debug,release,asan}.sh"

2019-02-01 Thread Michael Ho (Code Review) 
Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12335 )

Change subject: Revert "IMPALA-8146: Remove make_{debug,release,asan}.sh"
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/12335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcb921224071eef2dc77cf7b9f4c618f88aaa7c1
Gerrit-Change-Number: 12335
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 01 Feb 2019 19:31:33 +
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-8146: Remove make {debug,release,asan}.sh"

2019-02-01 Thread Philip Zeyliger (Code Review) 
Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12335 )

Change subject: Revert "IMPALA-8146: Remove make_{debug,release,asan}.sh"
..


Patch Set 1: Code-Review+2

I recommend self-verifying and pushing ahead.


--
To view, visit http://gerrit.cloudera.org:8080/12335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcb921224071eef2dc77cf7b9f4c618f88aaa7c1
Gerrit-Change-Number: 12335
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 01 Feb 2019 19:29:02 +
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-8146: Remove make {debug,release,asan}.sh"

2019-02-01 Thread Michael Ho (Code Review) 
Michael Ho has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/12335


Change subject: Revert "IMPALA-8146: Remove make_{debug,release,asan}.sh"
..

Revert "IMPALA-8146: Remove make_{debug,release,asan}.sh"

This reverts commit e8ea4b0525fb3223da9291775eff4b7fbd15c547.
Apparently some users of Impala have some workflow which rely
on these scripts. Reverting this change to unblock those users.

Change-Id: Ibcb921224071eef2dc77cf7b9f4c618f88aaa7c1
---
A bin/make_asan.sh
A bin/make_debug.sh
A bin/make_release.sh
3 files changed, 60 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/12335/1
--
To view, visit http://gerrit.cloudera.org:8080/12335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibcb921224071eef2dc77cf7b9f4c618f88aaa7c1
Gerrit-Change-Number: 12335
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho