[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" This reverts commit 829d1a6ab4643b07877fb410971b67f1b1d1b045. Additionally, this patch has couple of addendums which are related to the original change: 1. Bug fix the original reverted commit which uses isSetGetFileMetadata instead of isGetFileMetadata (see https://gerrit.cloudera.org/#/c/17330/) 2. Fix for intermittent failures on CatalogHmsFileMetadataTest due to the limitation of the catalogd's HMS client requirement of need to set "hive.metastore.execute.setugi" to false. Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Reviewed-on: http://gerrit.cloudera.org:8080/17429 Tested-by: Impala Public Jenkins Reviewed-by: Aman Sinha --- M be/src/catalog/catalog-server.cc M be/src/common/global-flags.cc M be/src/util/backend-gflag-util.cc M common/thrift/BackendGflags.thrift M common/thrift/CatalogService.thrift M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java A fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java A fe/src/main/java/org/apache/impala/catalog/GetPartialCatalogObjectRequestBuilder.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java M fe/src/main/java/org/apache/impala/catalog/Table.java A fe/src/main/java/org/apache/impala/catalog/metastore/CatalogHmsClientUtils.java A fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java A fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java A fe/src/main/java/org/apache/impala/catalog/metastore/ICatalogMetastoreServer.java A fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java A fe/src/main/java/org/apache/impala/catalog/metastore/NoOpCatalogMetastoreServer.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java A fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java A fe/src/test/java/org/apache/impala/catalog/metastore/EnableCatalogdHmsCacheFlagTest.java M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java M tests/common/impala_test_suite.py A tests/custom_cluster/test_metastore_service.py 24 files changed, 5,406 insertions(+), 22 deletions(-) Approvals: Impala Public Jenkins: Verified Aman Sinha: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 8 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 7 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 18 May 2021 00:28:24 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 7 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 17 May 2021 23:46:34 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8735/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 7 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 17 May 2021 18:00:25 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7150/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 7 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 17 May 2021 17:41:48 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Vihang Karajgaonkar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" This reverts commit 829d1a6ab4643b07877fb410971b67f1b1d1b045. Additionally, this patch has couple of addendums which are related to the original change: 1. Bug fix the original reverted commit which uses isSetGetFileMetadata instead of isGetFileMetadata (see https://gerrit.cloudera.org/#/c/17330/) 2. Fix for intermittent failures on CatalogHmsFileMetadataTest due to the limitation of the catalogd's HMS client requirement of need to set "hive.metastore.execute.setugi" to false. Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 --- M be/src/catalog/catalog-server.cc M be/src/common/global-flags.cc M be/src/util/backend-gflag-util.cc M common/thrift/BackendGflags.thrift M common/thrift/CatalogService.thrift M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java A fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java A fe/src/main/java/org/apache/impala/catalog/GetPartialCatalogObjectRequestBuilder.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java M fe/src/main/java/org/apache/impala/catalog/Table.java A fe/src/main/java/org/apache/impala/catalog/metastore/CatalogHmsClientUtils.java A fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java A fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java A fe/src/main/java/org/apache/impala/catalog/metastore/ICatalogMetastoreServer.java A fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java A fe/src/main/java/org/apache/impala/catalog/metastore/NoOpCatalogMetastoreServer.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java A fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java A fe/src/test/java/org/apache/impala/catalog/metastore/EnableCatalogdHmsCacheFlagTest.java M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java M tests/common/impala_test_suite.py A tests/custom_cluster/test_metastore_service.py 24 files changed, 5,406 insertions(+), 22 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/17429/7 -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 7 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Patch Set 5: Couple of failures for the retry query feature. Since this patch ran cleanly in the original commit, I am guessing either the addendum causes some side effect or these are flaky tests? Perhaps re-submit to be sure. -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 5 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Thu, 13 May 2021 02:36:03 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8711/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 5 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 12 May 2021 23:58:55 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Vihang Karajgaonkar has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" This reverts commit 829d1a6ab4643b07877fb410971b67f1b1d1b045. Additionally, this also pulls in the addendum patch which was published here https://gerrit.cloudera.org/#/c/17330/ Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 --- M be/src/catalog/catalog-server.cc M be/src/common/global-flags.cc M be/src/util/backend-gflag-util.cc M common/thrift/BackendGflags.thrift M common/thrift/CatalogService.thrift M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java A fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java A fe/src/main/java/org/apache/impala/catalog/GetPartialCatalogObjectRequestBuilder.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java M fe/src/main/java/org/apache/impala/catalog/Table.java A fe/src/main/java/org/apache/impala/catalog/metastore/CatalogHmsClientUtils.java A fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java A fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java A fe/src/main/java/org/apache/impala/catalog/metastore/ICatalogMetastoreServer.java A fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java A fe/src/main/java/org/apache/impala/catalog/metastore/NoOpCatalogMetastoreServer.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java A fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java A fe/src/test/java/org/apache/impala/catalog/metastore/EnableCatalogdHmsCacheFlagTest.java M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java M tests/common/impala_test_suite.py A tests/custom_cluster/test_metastore_service.py 24 files changed, 5,398 insertions(+), 22 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/17429/5 -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 5 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7134/ -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 3 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 12 May 2021 21:49:21 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Patch Set 4: Code-Review+1 lgtm. There's one remaining formatting issue. -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 4 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 12 May 2021 19:35:44 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8709/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 4 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 12 May 2021 18:07:35 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17429/4/common/thrift/BackendGflags.thrift File common/thrift/BackendGflags.thrift: http://gerrit.cloudera.org:8080/#/c/17429/4/common/thrift/BackendGflags.thrift@200 PS4, Line 200: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 4 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 12 May 2021 17:47:11 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17429/2/common/thrift/BackendGflags.thrift File common/thrift/BackendGflags.thrift: http://gerrit.cloudera.org:8080/#/c/17429/2/common/thrift/BackendGflags.thrift@200 PS2, Line 200: > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/17429/2/tests/custom_cluster/test_metastore_service.py File tests/custom_cluster/test_metastore_service.py: http://gerrit.cloudera.org:8080/#/c/17429/2/tests/custom_cluster/test_metastore_service.py@215 PS2, Line 215: e > flake8: E722 do not use bare except' Done -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Wed, 12 May 2021 17:46:47 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Vihang Karajgaonkar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" This reverts commit 829d1a6ab4643b07877fb410971b67f1b1d1b045. Additionally, this also pulls in the addendum patch which was published here https://gerrit.cloudera.org/#/c/17330/ Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 --- M be/src/catalog/catalog-server.cc M be/src/common/global-flags.cc M be/src/util/backend-gflag-util.cc M common/thrift/BackendGflags.thrift M common/thrift/CatalogService.thrift M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java A fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java A fe/src/main/java/org/apache/impala/catalog/GetPartialCatalogObjectRequestBuilder.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java M fe/src/main/java/org/apache/impala/catalog/Table.java A fe/src/main/java/org/apache/impala/catalog/metastore/CatalogHmsClientUtils.java A fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java A fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java A fe/src/main/java/org/apache/impala/catalog/metastore/ICatalogMetastoreServer.java A fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java A fe/src/main/java/org/apache/impala/catalog/metastore/NoOpCatalogMetastoreServer.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java A fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java A fe/src/test/java/org/apache/impala/catalog/metastore/EnableCatalogdHmsCacheFlagTest.java M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java M tests/common/impala_test_suite.py A tests/custom_cluster/test_metastore_service.py 24 files changed, 5,398 insertions(+), 22 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/17429/4 -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 4 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8708/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 12 May 2021 16:11:31 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17429/2/common/thrift/BackendGflags.thrift File common/thrift/BackendGflags.thrift: http://gerrit.cloudera.org:8080/#/c/17429/2/common/thrift/BackendGflags.thrift@200 PS2, Line 200: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17429/2/tests/custom_cluster/test_metastore_service.py File tests/custom_cluster/test_metastore_service.py: http://gerrit.cloudera.org:8080/#/c/17429/2/tests/custom_cluster/test_metastore_service.py@215 PS2, Line 215: e flake8: E722 do not use bare except' -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 12 May 2021 15:51:58 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7134/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 3 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 12 May 2021 15:51:41 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Vihang Karajgaonkar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" This reverts commit 829d1a6ab4643b07877fb410971b67f1b1d1b045. Additionally, this also pulls in the addendum patch which was published here https://gerrit.cloudera.org/#/c/17330/ Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 --- M be/src/catalog/catalog-server.cc M be/src/common/global-flags.cc M be/src/util/backend-gflag-util.cc M common/thrift/BackendGflags.thrift M common/thrift/CatalogService.thrift M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java A fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java A fe/src/main/java/org/apache/impala/catalog/GetPartialCatalogObjectRequestBuilder.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java M fe/src/main/java/org/apache/impala/catalog/Table.java A fe/src/main/java/org/apache/impala/catalog/metastore/CatalogHmsClientUtils.java A fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java A fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java A fe/src/main/java/org/apache/impala/catalog/metastore/ICatalogMetastoreServer.java A fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java A fe/src/main/java/org/apache/impala/catalog/metastore/NoOpCatalogMetastoreServer.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java A fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java A fe/src/test/java/org/apache/impala/catalog/metastore/EnableCatalogdHmsCacheFlagTest.java M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java M tests/common/impala_test_suite.py A tests/custom_cluster/test_metastore_service.py 24 files changed, 5,398 insertions(+), 22 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/17429/2 -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8707/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 12 May 2021 14:51:26 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17429 ) Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17429/1/common/thrift/BackendGflags.thrift File common/thrift/BackendGflags.thrift: http://gerrit.cloudera.org:8080/#/c/17429/1/common/thrift/BackendGflags.thrift@200 PS1, Line 200: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/17429/1/tests/custom_cluster/test_metastore_service.py File tests/custom_cluster/test_metastore_service.py: http://gerrit.cloudera.org:8080/#/c/17429/1/tests/custom_cluster/test_metastore_service.py@215 PS1, Line 215: e flake8: E722 do not use bare except' -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 12 May 2021 14:32:31 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog""
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17429 Change subject: Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" .. Revert "Revert "IMPALA-10613: Standup HMS thrift server in Catalog"" This reverts commit 829d1a6ab4643b07877fb410971b67f1b1d1b045. Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 --- M be/src/catalog/catalog-server.cc M be/src/common/global-flags.cc M be/src/util/backend-gflag-util.cc M common/thrift/BackendGflags.thrift M common/thrift/CatalogService.thrift M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java A fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java A fe/src/main/java/org/apache/impala/catalog/GetPartialCatalogObjectRequestBuilder.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java M fe/src/main/java/org/apache/impala/catalog/Table.java A fe/src/main/java/org/apache/impala/catalog/metastore/CatalogHmsClientUtils.java A fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServer.java A fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java A fe/src/main/java/org/apache/impala/catalog/metastore/ICatalogMetastoreServer.java A fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java A fe/src/main/java/org/apache/impala/catalog/metastore/NoOpCatalogMetastoreServer.java M fe/src/main/java/org/apache/impala/service/BackendConfig.java A fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsFileMetadataTest.java A fe/src/test/java/org/apache/impala/catalog/metastore/EnableCatalogdHmsCacheFlagTest.java M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java M tests/common/impala_test_suite.py A tests/custom_cluster/test_metastore_service.py 24 files changed, 5,398 insertions(+), 22 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/17429/1 -- To view, visit http://gerrit.cloudera.org:8080/17429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Icbe93f3ae4efd585d4b0092a9ac7081b0b2c1c44 Gerrit-Change-Number: 17429 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar