[Impala-ASF-CR] Revert "build: use thin static archives"
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13798 ) Change subject: Revert "build: use thin static archives" .. Patch Set 2: > What was the rationale for this revert? I don't see a reference in > JIRA. It broke the build on Centos 6. The symptoms was like this: 20:24:12 [ 10%] Linking CXX static library ../../build/debug/gutil/libgutil.a 20:24:12 /usr/bin/ranlib: ../../build/debug/gutil/libgutil.a: No such file or directory 20:24:12 make[2]: *** [be/build/debug/gutil/libgutil.a] Error 1 20:24:12 make[2]: *** Deleting file `be/build/debug/gutil/libgutil.a' 20:24:12 make[1]: *** [be/src/gutil/CMakeFiles/gutil.dir/all] Error 2 20:24:12 make[1]: *** Waiting for unfinished jobs We didn't have time to diagnose it completely. -- To view, visit http://gerrit.cloudera.org:8080/13798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I777ca8b4e862c8bfd8c06135834161fe91fefe67 Gerrit-Change-Number: 13798 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Mon, 12 Aug 2019 03:46:51 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "build: use thin static archives"
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13798 ) Change subject: Revert "build: use thin static archives" .. Patch Set 2: What was the rationale for this revert? I don't see a reference in JIRA. -- To view, visit http://gerrit.cloudera.org:8080/13798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I777ca8b4e862c8bfd8c06135834161fe91fefe67 Gerrit-Change-Number: 13798 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Mon, 12 Aug 2019 00:12:46 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "build: use thin static archives"
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13798 ) Change subject: Revert "build: use thin static archives" .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I777ca8b4e862c8bfd8c06135834161fe91fefe67 Gerrit-Change-Number: 13798 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 03 Jul 2019 23:32:07 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "build: use thin static archives"
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13798 ) Change subject: Revert "build: use thin static archives" .. Revert "build: use thin static archives" This reverts commit 78c55230288f8874bcd16454eb3c55277211719a. Change-Id: I777ca8b4e862c8bfd8c06135834161fe91fefe67 Reviewed-on: http://gerrit.cloudera.org:8080/13798 Reviewed-by: Joe McDonnell Tested-by: Joe McDonnell --- M CMakeLists.txt 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I777ca8b4e862c8bfd8c06135834161fe91fefe67 Gerrit-Change-Number: 13798 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] Revert "build: use thin static archives"
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13798 ) Change subject: Revert "build: use thin static archives" .. Patch Set 1: Verified+1 This is reverting a small CMake change that broke Centos 6. Impala has been building without this change for a long time (and the verification jobs are past the build stage), so I'm just going to verify and push this in. -- To view, visit http://gerrit.cloudera.org:8080/13798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I777ca8b4e862c8bfd8c06135834161fe91fefe67 Gerrit-Change-Number: 13798 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 03 Jul 2019 18:32:31 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "build: use thin static archives"
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13798 ) Change subject: Revert "build: use thin static archives" .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3818/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I777ca8b4e862c8bfd8c06135834161fe91fefe67 Gerrit-Change-Number: 13798 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 03 Jul 2019 18:23:12 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "build: use thin static archives"
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13798 ) Change subject: Revert "build: use thin static archives" .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4580/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I777ca8b4e862c8bfd8c06135834161fe91fefe67 Gerrit-Change-Number: 13798 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 03 Jul 2019 18:04:20 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "build: use thin static archives"
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13798 ) Change subject: Revert "build: use thin static archives" .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I777ca8b4e862c8bfd8c06135834161fe91fefe67 Gerrit-Change-Number: 13798 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Wed, 03 Jul 2019 18:03:54 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "build: use thin static archives"
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13798 ) Change subject: Revert "build: use thin static archives" .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4579/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/13798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I777ca8b4e862c8bfd8c06135834161fe91fefe67 Gerrit-Change-Number: 13798 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 03 Jul 2019 17:43:56 + Gerrit-HasComments: No
[Impala-ASF-CR] Revert "build: use thin static archives"
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13798 Change subject: Revert "build: use thin static archives" .. Revert "build: use thin static archives" This reverts commit 78c55230288f8874bcd16454eb3c55277211719a. Change-Id: I777ca8b4e862c8bfd8c06135834161fe91fefe67 --- M CMakeLists.txt 1 file changed, 0 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/13798/1 -- To view, visit http://gerrit.cloudera.org:8080/13798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I777ca8b4e862c8bfd8c06135834161fe91fefe67 Gerrit-Change-Number: 13798 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell
