[Impala-ASF-CR] Update .gitignore with VSCode artifacts
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15061 ) Change subject: Update .gitignore with VSCode artifacts .. Update .gitignore with VSCode artifacts Added .vscode/ directory to .gitignore. Change-Id: Ifc4083787b132f6455023c9b2f52a82a1b8626a7 Reviewed-on: http://gerrit.cloudera.org:8080/15061 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M .gitignore 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifc4083787b132f6455023c9b2f52a82a1b8626a7 Gerrit-Change-Number: 15061 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] Update .gitignore with VSCode artifacts
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15061 ) Change subject: Update .gitignore with VSCode artifacts .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/15061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc4083787b132f6455023c9b2f52a82a1b8626a7 Gerrit-Change-Number: 15061 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 17 Jan 2020 20:56:55 + Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore with VSCode artifacts
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15061 ) Change subject: Update .gitignore with VSCode artifacts .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5430/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/15061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc4083787b132f6455023c9b2f52a82a1b8626a7 Gerrit-Change-Number: 15061 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 17 Jan 2020 16:02:16 + Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore with VSCode artifacts
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15061 ) Change subject: Update .gitignore with VSCode artifacts .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc4083787b132f6455023c9b2f52a82a1b8626a7 Gerrit-Change-Number: 15061 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 17 Jan 2020 16:02:15 + Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore with VSCode artifacts
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15061 ) Change subject: Update .gitignore with VSCode artifacts .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc4083787b132f6455023c9b2f52a82a1b8626a7 Gerrit-Change-Number: 15061 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 17 Jan 2020 15:01:19 + Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore with VSCode artifacts
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15061 ) Change subject: Update .gitignore with VSCode artifacts .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5451/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/15061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc4083787b132f6455023c9b2f52a82a1b8626a7 Gerrit-Change-Number: 15061 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 17 Jan 2020 13:14:17 + Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore with VSCode artifacts
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15061 Change subject: Update .gitignore with VSCode artifacts .. Update .gitignore with VSCode artifacts Added .vscode/ directory to .gitignore. Change-Id: Ifc4083787b132f6455023c9b2f52a82a1b8626a7 --- M .gitignore 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/15061/1 -- To view, visit http://gerrit.cloudera.org:8080/15061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifc4083787b132f6455023c9b2f52a82a1b8626a7 Gerrit-Change-Number: 15061 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy
[Impala-ASF-CR] Update gitignore files
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14858 ) Change subject: Update gitignore files .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I357441fab00ac031fbc70c40e4574e7a723fdedd Gerrit-Change-Number: 14858 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 06 Dec 2019 04:38:08 + Gerrit-HasComments: No
[Impala-ASF-CR] Update gitignore files
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14858 ) Change subject: Update gitignore files .. Update gitignore files This adds in a handful of files that I had on my local machine Change-Id: I357441fab00ac031fbc70c40e4574e7a723fdedd Reviewed-on: http://gerrit.cloudera.org:8080/14858 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M .gitignore M fe/.gitignore 2 files changed, 16 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I357441fab00ac031fbc70c40e4574e7a723fdedd Gerrit-Change-Number: 14858 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] Update gitignore files
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14858 ) Change subject: Update gitignore files .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5318/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I357441fab00ac031fbc70c40e4574e7a723fdedd Gerrit-Change-Number: 14858 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 06 Dec 2019 00:12:31 + Gerrit-HasComments: No
[Impala-ASF-CR] Update gitignore files
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14858 ) Change subject: Update gitignore files .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I357441fab00ac031fbc70c40e4574e7a723fdedd Gerrit-Change-Number: 14858 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 06 Dec 2019 00:12:30 + Gerrit-HasComments: No
[Impala-ASF-CR] Update gitignore files
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14858 ) Change subject: Update gitignore files .. Patch Set 1: Code-Review+2 LGTM -- To view, visit http://gerrit.cloudera.org:8080/14858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I357441fab00ac031fbc70c40e4574e7a723fdedd Gerrit-Change-Number: 14858 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Andrew Sherman Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 06 Dec 2019 00:09:22 + Gerrit-HasComments: No
[Impala-ASF-CR] Update gitignore files
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14858 ) Change subject: Update gitignore files .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/5218/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I357441fab00ac031fbc70c40e4574e7a723fdedd Gerrit-Change-Number: 14858 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 05 Dec 2019 22:17:10 + Gerrit-HasComments: No
[Impala-ASF-CR] Update gitignore files
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14858 Change subject: Update gitignore files .. Update gitignore files This adds in a handful of files that I had on my local machine Change-Id: I357441fab00ac031fbc70c40e4574e7a723fdedd --- M .gitignore M fe/.gitignore 2 files changed, 16 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/14858/1 -- To view, visit http://gerrit.cloudera.org:8080/14858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I357441fab00ac031fbc70c40e4574e7a723fdedd Gerrit-Change-Number: 14858 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
[Impala-ASF-CR] Update .gitignore
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Gerrit-Change-Number: 11787 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 26 Oct 2018 22:19:34 + Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Update .gitignore A few unversioned artifacts crept in over time without corresponding .gitignore entries. These are the updates based on the git status output on my dev env. Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Reviewed-on: http://gerrit.cloudera.org:8080/11787 Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M .gitignore A common/yarn-extras/.gitignore M fe/.gitignore M fe/src/test/resources/.gitignore A lib/python/.gitignore M testdata/.gitignore M testdata/cluster/.gitignore 7 files changed, 35 insertions(+), 0 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Gerrit-Change-Number: 11787 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Update .gitignore
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1177/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Gerrit-Change-Number: 11787 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 26 Oct 2018 19:08:30 + Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3367/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Gerrit-Change-Number: 11787 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 26 Oct 2018 18:40:45 + Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Gerrit-Change-Number: 11787 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 26 Oct 2018 18:40:26 + Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 4: (3 comments) I added the requested files. I don't think it really makes sense for me in future to add everyone's pet .gitignore entry though since you know what files you have on your system and I don't. http://gerrit.cloudera.org:8080/#/c/11787/3/.gitignore File .gitignore: http://gerrit.cloudera.org:8080/#/c/11787/3/.gitignore@72 PS3, Line 72: .gdbinit > .gdbinit ? Done http://gerrit.cloudera.org:8080/#/c/11787/3/common/yarn-extras/.gitignore File common/yarn-extras/.gitignore: http://gerrit.cloudera.org:8080/#/c/11787/3/common/yarn-extras/.gitignore@10 PS3, Line 10: *~ > probably worth adding to the top level one too. Moved to top level http://gerrit.cloudera.org:8080/#/c/11787/3/common/yarn-extras/.gitignore@16 PS3, Line 16: > same Done -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Gerrit-Change-Number: 11787 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 26 Oct 2018 18:40:17 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Update .gitignore
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3366/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Gerrit-Change-Number: 11787 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 26 Oct 2018 18:39:39 + Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Hello Bharath Vissapragada, Paul Rogers, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11787 to look at the new patch set (#4). Change subject: Update .gitignore .. Update .gitignore A few unversioned artifacts crept in over time without corresponding .gitignore entries. These are the updates based on the git status output on my dev env. Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a --- M .gitignore A common/yarn-extras/.gitignore M fe/.gitignore M fe/src/test/resources/.gitignore A lib/python/.gitignore M testdata/.gitignore M testdata/cluster/.gitignore 7 files changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/11787/4 -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Gerrit-Change-Number: 11787 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Update .gitignore
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 3: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/11787/3/.gitignore File .gitignore: http://gerrit.cloudera.org:8080/#/c/11787/3/.gitignore@72 PS3, Line 72: .gdbinit ? http://gerrit.cloudera.org:8080/#/c/11787/3/common/yarn-extras/.gitignore File common/yarn-extras/.gitignore: http://gerrit.cloudera.org:8080/#/c/11787/3/common/yarn-extras/.gitignore@10 PS3, Line 10: .idea probably worth adding to the top level one too. http://gerrit.cloudera.org:8080/#/c/11787/3/common/yarn-extras/.gitignore@16 PS3, Line 16: DS_Store same -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Gerrit-Change-Number: 11787 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 26 Oct 2018 18:00:13 + Gerrit-HasComments: Yes
[Impala-ASF-CR] Update .gitignore
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1164/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Gerrit-Change-Number: 11787 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 25 Oct 2018 19:06:53 + Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1163/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Gerrit-Change-Number: 11787 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 25 Oct 2018 18:59:46 + Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 3: Code-Review+1 Thanks! I've found a few more additions, many around the use of Eclipse. Probably easiest if I add those after you commit this set. -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Gerrit-Change-Number: 11787 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Paul Rogers Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 25 Oct 2018 18:56:48 + Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 3: Code-Review+1 Thanks for doing this! LGTM. -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Gerrit-Change-Number: 11787 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 25 Oct 2018 18:23:58 + Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1161/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Gerrit-Change-Number: 11787 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 25 Oct 2018 18:23:42 + Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Hello Fredy Wijaya, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11787 to look at the new patch set (#3). Change subject: Update .gitignore .. Update .gitignore A few unversioned artifacts crept in over time without corresponding .gitignore entries. These are the updates based on the git status output on my dev env. Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a --- M .gitignore A common/yarn-extras/.gitignore M fe/.gitignore M fe/src/test/resources/.gitignore A lib/python/.gitignore M testdata/.gitignore M testdata/cluster/.gitignore 7 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/11787/3 -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Gerrit-Change-Number: 11787 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Update .gitignore
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 2: I think I addressed the ones you mentioned. I don't use some of those IDEs - intellij and codeblocks it looks like - so I can't confirm that I got all of the generated files for those. -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Gerrit-Change-Number: 11787 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 25 Oct 2018 18:21:59 + Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11787 ) Change subject: Update .gitignore .. Patch Set 1: We need to ignore more. These are files that I think should also be ignored. $IMPALA_HOME/ .idea/ Impala.cbp be/ASSEMBLER.cbp lib/python/impala_py_lib.egg-info/ testdata/cluster/cdh6/ -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Gerrit-Change-Number: 11787 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Fredy Wijaya Gerrit-Comment-Date: Thu, 25 Oct 2018 18:07:31 + Gerrit-HasComments: No
[Impala-ASF-CR] Update .gitignore
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11787 Change subject: Update .gitignore .. Update .gitignore A few unversioned artifacts crept in over time without corresponding .gitignore entries. These are the updates based on the git status output on my dev env. Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a --- M .gitignore A common/yarn-extras/.gitignore M fe/.gitignore M fe/src/test/resources/.gitignore A lib/python/.gitignore 5 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/11787/1 -- To view, visit http://gerrit.cloudera.org:8080/11787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I281ab3b5c98ac32e5d60663562628ffda6606a6a Gerrit-Change-Number: 11787 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
