[Impala-ASF-CR] WIP: IMPALA-4063

2018-10-08 Thread Michael Ho (Code Review) 
Michael Ho has abandoned this change. ( http://gerrit.cloudera.org:8080/11185 )

Change subject: WIP: IMPALA-4063
..


Abandoned

New patch is at https://gerrit.cloudera.org/#/c/11615/
--
To view, visit http://gerrit.cloudera.org:8080/11185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I82dd6d6014f5219550082c3cc59e88bfb7d84ef8
Gerrit-Change-Number: 11185
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Ho

[Impala-ASF-CR] WIP: IMPALA-4063

2018-08-10 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11185 )

Change subject: WIP: IMPALA-4063
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/283/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/11185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82dd6d6014f5219550082c3cc59e88bfb7d84ef8
Gerrit-Change-Number: 11185
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Ho 
Gerrit-Comment-Date: Fri, 10 Aug 2018 16:31:21 +
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: IMPALA-4063

2018-08-10 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11185 )

Change subject: WIP: IMPALA-4063
..


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11185/1/be/src/runtime/coordinator-backend-state.cc
File be/src/runtime/coordinator-backend-state.cc:

http://gerrit.cloudera.org:8080/#/c/11185/1/be/src/runtime/coordinator-backend-state.cc@272
PS1, Line 272:   //<< report_version << " | Last report version: " 
<< instance_stats->last_report_version_
line too long (103 > 90)


http://gerrit.cloudera.org:8080/#/c/11185/1/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:

http://gerrit.cloudera.org:8080/#/c/11185/1/be/src/runtime/query-state.cc@516
PS1, Line 516:   // We prioritize thread creation failure as a query 
killing error, even over an error
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/11185/1/be/src/service/client-request-state.cc
File be/src/service/client-request-state.cc:

http://gerrit.cloudera.org:8080/#/c/11185/1/be/src/service/client-request-state.cc@1198
PS1, Line 1198: const ReportExecStatusRequestPB& request, const 
TRuntimeProfileForest& thrift_profiles) {
line too long (93 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/11185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82dd6d6014f5219550082c3cc59e88bfb7d84ef8
Gerrit-Change-Number: 11185
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Fri, 10 Aug 2018 16:02:00 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] WIP: IMPALA-4063

2018-08-10 Thread Sailesh Mukil (Code Review) 
Sailesh Mukil has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/11185


Change subject: WIP: IMPALA-4063
..

WIP: IMPALA-4063

Change-Id: I82dd6d6014f5219550082c3cc59e88bfb7d84ef8
---
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/fragment-instance-state.h
M be/src/runtime/query-exec-mgr.cc
M be/src/runtime/query-state.cc
M be/src/runtime/query-state.h
M be/src/service/client-request-state.cc
M be/src/service/client-request-state.h
M be/src/service/control-service.cc
M common/protobuf/control_service.proto
M common/thrift/RuntimeProfile.thrift
14 files changed, 185 insertions(+), 227 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/11185/1
--
To view, visit http://gerrit.cloudera.org:8080/11185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82dd6d6014f5219550082c3cc59e88bfb7d84ef8
Gerrit-Change-Number: 11185
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil