[native-toolchain-CR] Add libpfm / google benchmark
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21164 ) Change subject: Add libpfm / google benchmark .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18a59e430850e45e7a28792925692a70ef9fce4a Gerrit-Change-Number: 21164 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Mon, 25 Mar 2024 15:55:41 + Gerrit-HasComments: No
[native-toolchain-CR] Add libpfm / google benchmark
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21164 ) Change subject: Add libpfm / google benchmark .. Add libpfm / google benchmark Google benchmark is a framework for writing benchmarks similar to Googletest's framework for tests. An interesting feature of google benchmark is that it integrates with libpfm / perfmon2 to get hardware performance counters as described in https://abseil.io/fast/53 . This adds a build for both libpfm and google benchmark to allow testing this capability for microbenchmarks. Testing: - Ran a toolchain build Change-Id: I18a59e430850e45e7a28792925692a70ef9fce4a Reviewed-on: http://gerrit.cloudera.org:8080/21164 Reviewed-by: Laszlo Gaal Tested-by: Joe McDonnell --- M buildall.sh M functions.sh A source/googlebenchmark/build.sh A source/libpfm/build.sh 4 files changed, 105 insertions(+), 0 deletions(-) Approvals: Laszlo Gaal: Looks good to me, approved Joe McDonnell: Verified -- To view, visit http://gerrit.cloudera.org:8080/21164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I18a59e430850e45e7a28792925692a70ef9fce4a Gerrit-Change-Number: 21164 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal
[native-toolchain-CR] Add libpfm / google benchmark
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21164 ) Change subject: Add libpfm / google benchmark .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18a59e430850e45e7a28792925692a70ef9fce4a Gerrit-Change-Number: 21164 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Fri, 22 Mar 2024 20:57:32 + Gerrit-HasComments: No
[native-toolchain-CR] Add libpfm / google benchmark
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21164 ) Change subject: Add libpfm / google benchmark .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21164/2/source/googlebenchmark/build.sh File source/googlebenchmark/build.sh: http://gerrit.cloudera.org:8080/#/c/21164/2/source/googlebenchmark/build.sh@2 PS2, Line 2: 2015 > nit: 2024 Done http://gerrit.cloudera.org:8080/#/c/21164/2/source/libpfm/build.sh File source/libpfm/build.sh: http://gerrit.cloudera.org:8080/#/c/21164/2/source/libpfm/build.sh@2 PS2, Line 2: 2016 > nit: 2024 Done -- To view, visit http://gerrit.cloudera.org:8080/21164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18a59e430850e45e7a28792925692a70ef9fce4a Gerrit-Change-Number: 21164 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Fri, 22 Mar 2024 20:47:31 + Gerrit-HasComments: Yes
[native-toolchain-CR] Add libpfm / google benchmark
Hello Laszlo Gaal, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21164 to look at the new patch set (#3). Change subject: Add libpfm / google benchmark .. Add libpfm / google benchmark Google benchmark is a framework for writing benchmarks similar to Googletest's framework for tests. An interesting feature of google benchmark is that it integrates with libpfm / perfmon2 to get hardware performance counters as described in https://abseil.io/fast/53 . This adds a build for both libpfm and google benchmark to allow testing this capability for microbenchmarks. Testing: - Ran a toolchain build Change-Id: I18a59e430850e45e7a28792925692a70ef9fce4a --- M buildall.sh M functions.sh A source/googlebenchmark/build.sh A source/libpfm/build.sh 4 files changed, 105 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/64/21164/3 -- To view, visit http://gerrit.cloudera.org:8080/21164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I18a59e430850e45e7a28792925692a70ef9fce4a Gerrit-Change-Number: 21164 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal
[native-toolchain-CR] Add libpfm / google benchmark
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21164 ) Change subject: Add libpfm / google benchmark .. Patch Set 2: (2 comments) Just two copyright headers... http://gerrit.cloudera.org:8080/#/c/21164/2/source/googlebenchmark/build.sh File source/googlebenchmark/build.sh: http://gerrit.cloudera.org:8080/#/c/21164/2/source/googlebenchmark/build.sh@2 PS2, Line 2: 2015 nit: 2024 http://gerrit.cloudera.org:8080/#/c/21164/2/source/libpfm/build.sh File source/libpfm/build.sh: http://gerrit.cloudera.org:8080/#/c/21164/2/source/libpfm/build.sh@2 PS2, Line 2: 2016 nit: 2024 -- To view, visit http://gerrit.cloudera.org:8080/21164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18a59e430850e45e7a28792925692a70ef9fce4a Gerrit-Change-Number: 21164 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Laszlo Gaal Gerrit-Comment-Date: Fri, 22 Mar 2024 20:44:22 + Gerrit-HasComments: Yes
[native-toolchain-CR] Add libpfm / google benchmark
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21164 Change subject: Add libpfm / google benchmark .. Add libpfm / google benchmark Google benchmark is a framework for writing benchmarks similar to Googletest's framework for tests. An interesting feature of google benchmark is that it integrates with libpfm / perfmon2 to get hardware performance counters as described in https://abseil.io/fast/53 . This adds a build for both libpfm and google benchmark to allow testing this capability for microbenchmarks. Testing: - Ran a toolchain build Change-Id: I18a59e430850e45e7a28792925692a70ef9fce4a --- M buildall.sh M functions.sh A source/googlebenchmark/build.sh A source/libpfm/build.sh 4 files changed, 105 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/64/21164/1 -- To view, visit http://gerrit.cloudera.org:8080/21164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I18a59e430850e45e7a28792925692a70ef9fce4a Gerrit-Change-Number: 21164 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell
