[native-toolchain-CR] Let buildall.sh run without setting PUBLISH DEPENDENCIES*
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/12883 ) Change subject: Let buildall.sh run without setting PUBLISH_DEPENDENCIES* .. Abandoned Hector already fixed it. -- To view, visit http://gerrit.cloudera.org:8080/12883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I4c88f44f597398c66881a7b4f5ebdee06a6f6b0b Gerrit-Change-Number: 12883 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Hector Acosta Gerrit-Reviewer: Thomas Marshall
[native-toolchain-CR] Let buildall.sh run without setting PUBLISH DEPENDENCIES*
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/12883 )
Change subject: Let buildall.sh run without setting PUBLISH_DEPENDENCIES*
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12883/2/init.sh
File init.sh:
http://gerrit.cloudera.org:8080/#/c/12883/2/init.sh@62
PS2, Line 62: # If PUBLISH_DEPENDENCIES_S3 and/or PUBLISH_DEPENDENCIES_S3 is
set to 1, the script will
: # upload the artifacts to S3 and/or the internal artifactory
respectively.
: # PUBLISH_DEPENDENCIES=1 results in PUBLISH_DEPENDENCIES_S3=1 and
: # PUBLISH_DEPENDENCIES_ARTIFACTORY=1
: : ${PUBLISH_DEPENDENCIES=0}
: if [[ "$PUBLISH_DEPENDENCIES" -eq 1 ]]; then
: PUBLISH_DEPENDENCIES_S3=1
: PUBLISH_DEPENDENCIES_ARTIFACTORY=1
: fi
: : ${PUBLISH_DEPENDENCIES_S3=0}
: : ${PUBLISH_DEPENDENCIES_ARTIFACTORY=0}
: export PUBLISH_DEPENDENCIES
: export PUBLISH_DEPENDENCIES_S3
: export PUBLISH_DEPENDENCIES_ARTIFACTORY
> I did something similar here:
Oh. thanks for pointing this out. It turns out I just needed to rebase to pick
up your fix.
--
To view, visit http://gerrit.cloudera.org:8080/12883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c88f44f597398c66881a7b4f5ebdee06a6f6b0b
Gerrit-Change-Number: 12883
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Hector Acosta
Gerrit-Reviewer: Thomas Marshall
Gerrit-Comment-Date: Thu, 28 Mar 2019 23:59:42 +
Gerrit-HasComments: Yes
[native-toolchain-CR] Let buildall.sh run without setting PUBLISH DEPENDENCIES*
Hector Acosta has posted comments on this change. (
http://gerrit.cloudera.org:8080/12883 )
Change subject: Let buildall.sh run without setting PUBLISH_DEPENDENCIES*
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12883/2/init.sh
File init.sh:
http://gerrit.cloudera.org:8080/#/c/12883/2/init.sh@62
PS2, Line 62: # If PUBLISH_DEPENDENCIES_S3 and/or PUBLISH_DEPENDENCIES_S3 is
set to 1, the script will
: # upload the artifacts to S3 and/or the internal artifactory
respectively.
: # PUBLISH_DEPENDENCIES=1 results in PUBLISH_DEPENDENCIES_S3=1 and
: # PUBLISH_DEPENDENCIES_ARTIFACTORY=1
: : ${PUBLISH_DEPENDENCIES=0}
: if [[ "$PUBLISH_DEPENDENCIES" -eq 1 ]]; then
: PUBLISH_DEPENDENCIES_S3=1
: PUBLISH_DEPENDENCIES_ARTIFACTORY=1
: fi
: : ${PUBLISH_DEPENDENCIES_S3=0}
: : ${PUBLISH_DEPENDENCIES_ARTIFACTORY=0}
: export PUBLISH_DEPENDENCIES
: export PUBLISH_DEPENDENCIES_S3
: export PUBLISH_DEPENDENCIES_ARTIFACTORY
I did something similar here:
https://gerrit.cloudera.org/#/c/12810/3/functions.sh
Perhaps that should be removed from functions.sh?
--
To view, visit http://gerrit.cloudera.org:8080/12883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c88f44f597398c66881a7b4f5ebdee06a6f6b0b
Gerrit-Change-Number: 12883
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong
Gerrit-Reviewer: Hector Acosta
Gerrit-Reviewer: Thomas Marshall
Gerrit-Comment-Date: Thu, 28 Mar 2019 23:50:43 +
Gerrit-HasComments: Yes
[native-toolchain-CR] Let buildall.sh run without setting PUBLISH DEPENDENCIES*
Hello Hector Acosta, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12883 to look at the new patch set (#2). Change subject: Let buildall.sh run without setting PUBLISH_DEPENDENCIES* .. Let buildall.sh run without setting PUBLISH_DEPENDENCIES* This fixes a regression where buildall.sh and build.sh failed if none of the PUBLISH_DEPENDENCIES variables were set. After the fix buildall.sh runs successfully on my system. Change-Id: I4c88f44f597398c66881a7b4f5ebdee06a6f6b0b --- M init.sh 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/83/12883/2 -- To view, visit http://gerrit.cloudera.org:8080/12883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4c88f44f597398c66881a7b4f5ebdee06a6f6b0b Gerrit-Change-Number: 12883 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Hector Acosta
[native-toolchain-CR] Let buildall.sh run without setting PUBLISH DEPENDENCIES*
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12883 Change subject: Let buildall.sh run without setting PUBLISH_DEPENDENCIES* .. Let buildall.sh run without setting PUBLISH_DEPENDENCIES* This fixes a regression where buildall.sh and build.sh failed unless some of the PUBLISH_DEPENDENCIES variables were not set. After the fix buildall.sh runs successfully on my system. Change-Id: I4c88f44f597398c66881a7b4f5ebdee06a6f6b0b --- M init.sh 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/83/12883/1 -- To view, visit http://gerrit.cloudera.org:8080/12883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4c88f44f597398c66881a7b4f5ebdee06a6f6b0b Gerrit-Change-Number: 12883 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong
