[native-toolchain-CR] WIP: Add platform tag for Ubuntu 14.04

2020-03-17 Thread Hector Acosta (Code Review)
Hector Acosta has abandoned this change. ( 
http://gerrit.cloudera.org:8080/15469 )

Change subject: WIP: Add platform tag for Ubuntu 14.04
..


Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/15469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I32dac434ddf12ec3a2367f6a0974b3504bd137c5
Gerrit-Change-Number: 15469
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta 
Gerrit-Reviewer: Hector Acosta 
Gerrit-Reviewer: Laszlo Gaal 


[native-toolchain-CR] WIP: Add platform tag for Ubuntu 14.04

2020-03-17 Thread Hector Acosta (Code Review)
Hector Acosta has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15469 )

Change subject: WIP: Add platform tag for Ubuntu 14.04
..


Patch Set 1:

> I must be missing something here: I was convinced that the earlier
 > change, https://gerrit.cloudera.org/c/15464/1 removed the
 > Ubuntu-14.04 toolchain build (so artifacts wouldn't be prodiced
 > either). How come that the build is still producing artifacts then?
 > Wouldn't the right fix be to make sure that Ubuntu-14.04 bits are
 > just not built?

I think I found the problem. The list of supported platforms is listed in the 
Makefile. I'll remove them from there and will abandon this RR.


--
To view, visit http://gerrit.cloudera.org:8080/15469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I32dac434ddf12ec3a2367f6a0974b3504bd137c5
Gerrit-Change-Number: 15469
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta 
Gerrit-Reviewer: Hector Acosta 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Comment-Date: Tue, 17 Mar 2020 22:34:36 +
Gerrit-HasComments: No


[native-toolchain-CR] WIP: Add platform tag for Ubuntu 14.04

2020-03-17 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15469 )

Change subject: WIP: Add platform tag for Ubuntu 14.04
..


Patch Set 1:

I must be missing something here: I was convinced that the earlier change, 
https://gerrit.cloudera.org/c/15464/1 removed the Ubuntu-14.04 toolchain build 
(so artifacts wouldn't be prodiced either). How come that the build is still 
producing artifacts then? Wouldn't the right fix be to make sure that 
Ubuntu-14.04 bits are just not built?


--
To view, visit http://gerrit.cloudera.org:8080/15469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I32dac434ddf12ec3a2367f6a0974b3504bd137c5
Gerrit-Change-Number: 15469
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta 
Gerrit-Reviewer: Laszlo Gaal 
Gerrit-Comment-Date: Tue, 17 Mar 2020 17:37:49 +
Gerrit-HasComments: No


[native-toolchain-CR] WIP: Add platform tag for Ubuntu 14.04

2020-03-17 Thread Hector Acosta (Code Review)
Hector Acosta has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15469


Change subject: WIP: Add platform tag for Ubuntu 14.04
..

WIP: Add platform tag for Ubuntu 14.04

Without this the packages for Ubuntu 14.04 are uploaded with tarball
names ending in 'generic', which makes bootstrap_toolchain.py unable
to find them later, during an Impala build.

Change-Id: I32dac434ddf12ec3a2367f6a0974b3504bd137c5
---
M in-docker.py
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain 
refs/changes/69/15469/1
--
To view, visit http://gerrit.cloudera.org:8080/15469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I32dac434ddf12ec3a2367f6a0974b3504bd137c5
Gerrit-Change-Number: 15469
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta 
Gerrit-Reviewer: Laszlo Gaal