[Impala-ASF-CR] IMPALA-3853: squeasel is MIT (and dual copyright) not Apache

2016-10-08 Thread Internal Jenkins (Code Review) 
Internal Jenkins has posted comments on this change.

Change subject: IMPALA-3853: squeasel is MIT (and dual copyright) not Apache
..


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4646
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9711ad60dbe00c3b8b1ce7b9ccc3ca1dd637b88c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3853: squeasel is MIT (and dual copyright) not Apache

2016-10-08 Thread Henry Robinson (Code Review) 
Henry Robinson has posted comments on this change.

Change subject: IMPALA-3853: squeasel is MIT (and dual copyright) not Apache
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4646
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9711ad60dbe00c3b8b1ce7b9ccc3ca1dd637b88c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Henry Robinson 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment

2016-10-08 Thread Jim Apple (Code Review) 
Jim Apple has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4674

Change subject: IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment
..

IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment

This script bootstraps an Impala dev environment on Ubuntu 14.04. It
is not hermetic -- it changes some config files for the user and for
the OS.

It is green on Jenkins, and it runs in about 6.5 hours. The intention
is to have this script run in a CI tool for post-commit testing, with
the hope that this will make it easier for new developers to get a
working development environment. Previously, the new developer
workflow lived on wiki pages and tended to bit-rot.

Still left to do: migrating the install script into the official
Impala repo.

Change-Id: If166a8a286d7559af547da39f6cc09e723f34c7e
---
A bin/bootstrap_development.sh
1 file changed, 71 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/4674/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If166a8a286d7559af547da39f6cc09e723f34c7e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-08 Thread Marcel Kornacker (Code Review) 
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-1702: Enforce single-table consistency in query analysis.
..


Patch Set 14:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4349/14/common/thrift/CatalogObjects.thrift
File common/thrift/CatalogObjects.thrift:

Line 366
there's a TTableDescriptor.table_id which deserves a comment (clarify that this 
is a query-local id)


http://gerrit.cloudera.org:8080/#/c/4349/14/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

Line 294: // same version of table in a single query, we cache all 
referenced tables here.
"of a table"

shouldn't this also apply to other top-level objects from the catalog? there's 
analyzer.getDb() and there are numerous references to analyzer.getCatalog() 
elsewhere (data source, auth policy, hdfs cache pool, ...)


Line 2284:* the table has not yet been loaded in the local catalog cache.
update comment: effect on referencedTables_


-- 
To view, visit http://gerrit.cloudera.org:8080/4349
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad648b72684ae495ec387590ab1bc58ce5b39e2
Gerrit-PatchSet: 14
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Huaisi Xu 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Huaisi Xu 
Gerrit-Reviewer: Marcel Kornacker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] PREVIEW IMPALA-3644 Make predicate order deterministic

2016-10-08 Thread Lars Volker (Code Review) 
Lars Volker has posted comments on this change.

Change subject: PREVIEW IMPALA-3644 Make predicate order deterministic
..


Patch Set 1:

> Thanks, Lars! Change looks good, let's wait for your validation.

There were 4 failures, having a look:

01:33:54.780 Running org.apache.impala.planner.PlannerTest
01:33:54.781 Tests run: 44, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 
58.785 sec <<< FAILURE! - in org.apache.impala.planner.PlannerTest
01:33:54.781 testTpchNested(org.apache.impala.planner.PlannerTest)  Time 
elapsed: 2.578 sec  <<< FAILURE!
01:33:54.781at 
org.apache.impala.planner.PlannerTestBase.runPlannerTestFile(PlannerTestBase.java:682)
01:33:54.782at 
org.apache.impala.planner.PlannerTestBase.runPlannerTestFile(PlannerTestBase.java:691)
01:33:54.782at 
org.apache.impala.planner.PlannerTest.testTpchNested(PlannerTest.java:199)
01:33:54.782 testKudu(org.apache.impala.planner.PlannerTest)  Time elapsed: 
1.404 sec  <<< FAILURE!
01:33:54.782at 
org.apache.impala.planner.PlannerTestBase.runPlannerTestFile(PlannerTestBase.java:682)
01:33:54.783at 
org.apache.impala.planner.PlannerTestBase.runPlannerTestFile(PlannerTestBase.java:687)
01:33:54.783at 
org.apache.impala.planner.PlannerTest.testKudu(PlannerTest.java:254)
01:33:54.783 
testRuntimeFilterPropagation(org.apache.impala.planner.PlannerTest)  Time 
elapsed: 1.059 sec  <<< FAILURE!
01:33:54.784at 
org.apache.impala.planner.PlannerTestBase.runPlannerTestFile(PlannerTestBase.java:682)
01:33:54.784at 
org.apache.impala.planner.PlannerTestBase.runPlannerTestFile(PlannerTestBase.java:646)
01:33:54.784at 
org.apache.impala.planner.PlannerTest.testRuntimeFilterPropagation(PlannerTest.java:243)
01:34:31.786 testLineage(org.apache.impala.planner.PlannerTest)  Time elapsed: 
1.441 sec  <<< FAILURE!
01:34:31.786at 
org.apache.impala.planner.PlannerTestBase.runPlannerTestFile(PlannerTestBase.java:682)
01:34:31.787at 
org.apache.impala.planner.PlannerTestBase.runPlannerTestFile(PlannerTestBase.java:687)
01:34:31.787at 
org.apache.impala.planner.PlannerTest.testLineage(PlannerTest.java:171)
01:34:31.787 Running org.apache.impala.planner.S3PlannerTest

-- 
To view, visit http://gerrit.cloudera.org:8080/4671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id11010bfeaff368869e6d430eeb4773ddf41faff
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-08 Thread Henry Robinson (Code Review) 
Henry Robinson has posted comments on this change.

Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all 
others
..


Patch Set 10:

EE tests pass with this new sink implementation as well.

-- 
To view, visit http://gerrit.cloudera.org:8080/4402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb0064ec2f085fa3a5598ea80894fb489a01e4df
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Marcel Kornacker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No