[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1

2017-09-17 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1232/

-- 
To view, visit http://gerrit.cloudera.org:8080/7974
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1

2017-09-17 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..


Patch Set 8: Code-Review+2

Need to suppress a few new clang-tidy checks

-- 
To view, visit http://gerrit.cloudera.org:8080/7974
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1

2017-09-17 Thread Tim Armstrong (Code Review) 
Hello Impala Public Jenkins, Dan Hecht,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7974

to look at the new patch set (#8).

Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
..

IMPALA-5860: upgrade to LLVM 3.9.1

LLVM made a few API changes:
* Misc minor changes to function and type signatures
* The CloneFunction() API changed semantics (http://reviews.llvm.org/D18628)

Testing:
Ran core and ASAN tests.

Perf:
Ran single node TPC-H and targeted perf with scale factor 60. Both
improved on average.

+--+---+-++++
| Workload | File Format   | Avg (s) | Delta(Avg) | GeoMean(s) | 
Delta(GeoMean) |
+--+---+-++++
| TPCH(60) | parquet / none / none | 17.82   | -5.01% | 11.64  | -4.23% 
|
+--+---+-++++

+--+--+---++-++++-+---+
| Workload | Query| File Format   | Avg(s) | Base Avg(s) | 
Delta(Avg) | StdDev(%)  | Base StdDev(%) | Num Clients | Iters |
+--+--+---++-++++-+---+
| TPCH(60) | TPCH-Q1  | parquet / none / none | 27.97  | 27.59   |   +1.36% 
  |   0.39%|   0.41%| 1   | 5 |
| TPCH(60) | TPCH-Q20 | parquet / none / none | 5.81   | 5.78|   +0.44% 
  |   0.73%|   0.21%| 1   | 5 |
| TPCH(60) | TPCH-Q21 | parquet / none / none | 62.98  | 62.98   |   +0.01% 
  |   5.56%|   1.07%| 1   | 5 |
| TPCH(60) | TPCH-Q15 | parquet / none / none | 8.45   | 8.46|   -0.20% 
  |   0.40%|   0.38%| 1   | 5 |
| TPCH(60) | TPCH-Q4  | parquet / none / none | 5.57   | 5.59|   -0.41% 
  |   0.43%|   0.80%| 1   | 5 |
| TPCH(60) | TPCH-Q6  | parquet / none / none | 3.16   | 3.17|   -0.45% 
  |   0.78%|   1.70%| 1   | 5 |
| TPCH(60) | TPCH-Q5  | parquet / none / none | 7.41   | 7.47|   -0.92% 
  |   0.71%|   1.06%| 1   | 5 |
| TPCH(60) | TPCH-Q9  | parquet / none / none | 33.45  | 33.78   |   -0.99% 
  |   1.15%|   0.85%| 1   | 5 |
| TPCH(60) | TPCH-Q11 | parquet / none / none | 2.00   | 2.03|   -1.34% 
  |   1.71%|   2.24%| 1   | 5 |
| TPCH(60) | TPCH-Q2  | parquet / none / none | 4.71   | 4.79|   -1.60% 
  |   1.49%|   1.95%| 1   | 5 |
| TPCH(60) | TPCH-Q18 | parquet / none / none | 46.48  | 47.71   |   -2.58% 
  |   1.04%|   0.38%| 1   | 5 |
| TPCH(60) | TPCH-Q14 | parquet / none / none | 5.85   | 6.02|   -2.84% 
  |   0.44%|   0.70%| 1   | 5 |
| TPCH(60) | TPCH-Q22 | parquet / none / none | 6.51   | 6.76|   -3.71% 
  |   2.29%|   2.42%| 1   | 5 |
| TPCH(60) | TPCH-Q19 | parquet / none / none | 7.27   | 7.63|   -4.69% 
  |   1.33%|   0.78%| 1   | 5 |
| TPCH(60) | TPCH-Q10 | parquet / none / none | 13.19  | 13.84   |   -4.73% 
  |   0.42%|   1.44%| 1   | 5 |
| TPCH(60) | TPCH-Q13 | parquet / none / none | 21.95  | 23.12   |   -5.03% 
  |   0.25%|   1.19%| 1   | 5 |
| TPCH(60) | TPCH-Q16 | parquet / none / none | 5.29   | 5.57|   -5.04% 
  |   0.85%|   0.78%| 1   | 5 |
| TPCH(60) | TPCH-Q7  | parquet / none / none | 42.05  | 44.33   |   -5.16% 
  |   2.07%|   2.28%| 1   | 5 |
| TPCH(60) | TPCH-Q12 | parquet / none / none | 19.77  | 21.00   |   -5.87% 
  |   8.14%|   5.09%| 1   | 5 |
| TPCH(60) | TPCH-Q3  | parquet / none / none | 11.46  | 12.32   |   -6.94% 
  |   0.76%|   0.53%| 1   | 5 |
| TPCH(60) | TPCH-Q17 | parquet / none / none | 40.09  | 49.28   |   
-18.64%  |   2.09%|   0.67%| 1   | 5 |
| TPCH(60) | TPCH-Q8  | parquet / none / none | 10.63  | 13.47   | I 
-21.08%  | * 12.34% * | * 21.09% * | 1   | 5 |
+--+--+---++-++++-+---+

+---+---+-++++
| Workload  | File Format   | Avg (s) | Delta(Avg) | GeoMean(s) 
| Delta(GeoMean) |
+---+---+-++++
| TARGETED-PERF(60) | parquet / none / none | 22.38   | -1.24% |

[Impala-ASF-CR] IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet

2017-09-17 Thread Pranay Singh (Code Review) 
Pranay Singh has uploaded a new patch set (#3).

Change subject: IMPALA-5525 Extend TestScannersFuzzing to test uncompressed 
parquet
..

IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet

test_scanners_fuzz.py currently tests compressed parquet but
does not test uncompressed parquet. This fix adds a new test
case for uncompressed parquet.

Change-Id: I760de7203a51cf82b16016fa8043cadc7c8325bc
---
M tests/query_test/test_scanners_fuzz.py
1 file changed, 59 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/8056/3
-- 
To view, visit http://gerrit.cloudera.org:8080/8056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I760de7203a51cf82b16016fa8043cadc7c8325bc
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Pranay Singh

[Impala-ASF-CR] IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet

2017-09-17 Thread Pranay Singh (Code Review) 
Pranay Singh has uploaded a new patch set (#5).

Change subject: IMPALA-5525 Extend TestScannersFuzzing to test uncompressed 
parquet
..

IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet

test_scanners_fuzz.py currently tests compressed parquet but
does not test uncompressed parquet. This fix adds a new test
case for uncompressed parquet.

Change-Id: I760de7203a51cf82b16016fa8043cadc7c8325bc
---
M tests/query_test/test_scanners_fuzz.py
1 file changed, 59 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/8056/5
-- 
To view, visit http://gerrit.cloudera.org:8080/8056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I760de7203a51cf82b16016fa8043cadc7c8325bc
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Pranay Singh

[Impala-ASF-CR] IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet

2017-09-17 Thread Pranay Singh (Code Review) 
Pranay Singh has uploaded a new patch set (#4).

Change subject: IMPALA-5525 Extend TestScannersFuzzing to test uncompressed 
parquet
..

IMPALA-5525 Extend TestScannersFuzzing to test uncompressed parquet

test_scanners_fuzz.py currently tests compressed parquet but
does not test uncompressed parquet. This fix adds a new test
case for uncompressed parquet.

Change-Id: I760de7203a51cf82b16016fa8043cadc7c8325bc
---
M tests/query_test/test_scanners_fuzz.py
1 file changed, 59 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/8056/4
-- 
To view, visit http://gerrit.cloudera.org:8080/8056
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I760de7203a51cf82b16016fa8043cadc7c8325bc
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Pranay Singh