[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

[Ishaan Joshi (Code Review)]

Ishaan Joshi has posted comments on this change.

Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5877/7/tests/conftest.py
File tests/conftest.py:

Line 317:   try:
With a yield fixture, py.test treats everything after the yield as teardown, so 
you probably don't need the finally. Additionally, if you're at 2.10 or above, 
you don't even need the yield fixture marker.

Ref: 
http://doc.pytest.org/en/latest/fixture.html#fixture-finalization-executing-teardown-code


-- 
To view, visit http://gerrit.cloudera.org:8080/5877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9df71480a165f4ce21ae3edab6ce7227fbf76f77
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Ishaan Joshi 
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Mostafa Mokhtar 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4510: Selectively filter args for metric verification tests

[Ishaan Joshi (Code Review)]

Ishaan Joshi has posted comments on this change.

Change subject: IMPALA-4510: Selectively filter args for metric verification 
tests
..


Patch Set 5: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I069172f44c1307d55f85779cdb01fecc0ba1799e
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Ishaan Joshi 
Gerrit-Reviewer: Michael Brown 
Gerrit-HasComments: No