[Impala-ASF-CR](asf-site) Add "Effective Coding Practices" doc to site

[Tim Armstrong (Code Review)]

Tim Armstrong has abandoned this change.

Change subject: Add "Effective Coding Practices" doc to site
..


Abandoned

will add to wiki

-- 
To view, visit http://gerrit.cloudera.org:8080/4961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I21fdce898a71be836b658e0c914e05a6868d6263
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR](asf-site) Add "Effective Coding Practices" doc to site

[Henry Robinson (Code Review)]

Henry Robinson has posted comments on this change.

Change subject: Add "Effective Coding Practices" doc to site
..


Patch Set 2:

I'm happy with this content going up, but I feel it should be a wiki page - 
there's no reason this should be considered immutable, and may evolve as time 
goes on.

-- 
To view, visit http://gerrit.cloudera.org:8080/4961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21fdce898a71be836b658e0c914e05a6868d6263
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) Add "Effective Coding Practices" doc to site

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change.

Change subject: Add "Effective Coding Practices" doc to site
..


Patch Set 2:

I can see it being a blog post. Mainly I didn't think it fit on the wiki since 
it should be a static document. How would you feel about that, Henry?

-- 
To view, visit http://gerrit.cloudera.org:8080/4961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21fdce898a71be836b658e0c914e05a6868d6263
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) Add "Effective Coding Practices" doc to site

[Tim Armstrong (Code Review)]

Tim Armstrong has uploaded a new patch set (#2).

Change subject: Add "Effective Coding Practices" doc to site
..

Add "Effective Coding Practices" doc to site

This is a useful document that had floated around internally at
Cloudera. It would be useful to have as a reference doc on the website
as a guide for new and old contributors.

Change-Id: I21fdce898a71be836b658e0c914e05a6868d6263
---
A coding-practices.html
1 file changed, 339 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/4961/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I21fdce898a71be836b658e0c914e05a6868d6263
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Henry Robinson 

[Impala-ASF-CR](asf-site) Add "Effective Coding Practices" doc to site

[Henry Robinson (Code Review)]

Henry Robinson has posted comments on this change.

Change subject: Add "Effective Coding Practices" doc to site
..


Patch Set 1:

Can you word-wrap the file so it's possible to review? Thanks!

-- 
To view, visit http://gerrit.cloudera.org:8080/4961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21fdce898a71be836b658e0c914e05a6868d6263
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Henry Robinson 
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) Add "Effective Coding Practices" doc to site

[Tim Armstrong (Code Review)]

Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4961

Change subject: Add "Effective Coding Practices" doc to site
..

Add "Effective Coding Practices" doc to site

This is a useful document that had floated around internally at
Cloudera. It would be useful to have as a reference doc on the website
as a guide for new and old contributors.

Change-Id: I21fdce898a71be836b658e0c914e05a6868d6263
---
A coding-practices.html
1 file changed, 227 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/4961/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I21fdce898a71be836b658e0c914e05a6868d6263
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Tim Armstrong