[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
..


Patch Set 9:

A reminder to us both: the first blog post should change the Blog header link 
to /blog/

-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
..


Patch Set 9: Code-Review+2 Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[David Knupp (Code Review)]

David Knupp has uploaded a new patch set (#9).

Change subject: Initial commit of the blog section of the Impala ASF website.
..

Initial commit of the blog section of the Impala ASF website.

Note: a sample version of the site is up and running at:

   http://dknupp.github.io/blog/

The blog site is generated using Nikola. Nikola is only being used
to manage the blog in this patch, but could easily be used to manage
the other pages as well. It may take a fair bit of tweaking to the
settings and Jinja templates to make everything work properly if Nikola
is to be used for non-blog pages -- a job for when more cycles are
generally available.

The README gives a pretty complete description of the workflow for
adding content to the blog. The formatted README file can be seen at:

https://github.com/dknupp/dknupp.github.io/tree/master/nikola_site_generator

Comments on blog posts is being handled via Disqus. Other than that,
not much effort was spent in setting up some of the typical bloggish
bells and whistles - e.g. RSS/ATOM feeds, etc. Fancier bits can come
later.

Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
---
A .gitignore
A blog/2017/index.html
A blog/archive.html
A blog/assets/css/additional_styles.css
A blog/assets/css/bootstrap-responsive.min.css
A blog/assets/css/bootstrap.min.css
A blog/assets/css/code.css
A blog/assets/css/ipython.min.css
A blog/assets/css/ipython.min.css.map
A blog/assets/css/nikola_ipython.css
A blog/assets/css/rst.css
A blog/assets/css/theme.css
A blog/assets/images/incubator.png
A blog/assets/js/fancydates.js
A blog/assets/js/html5.js
A blog/assets/js/moment-with-locales.min.js
A blog/assets/xml/atom.xsl
A blog/assets/xml/rss.xsl
A blog/categories/index.html
A blog/index.html
A blog/posts/impala-blog-coming-soon/index.html
A blog/posts/impala-blog-coming-soon/index.md
A blog/robots.txt
A blog/sitemap.xml
A blog/sitemapindex.xml
A nikola_site_generator/README.md
A nikola_site_generator/conf.py
A nikola_site_generator/posts/blog-coming-soon.md
A nikola_site_generator/requirements.txt
A nikola_site_generator/themes/impala-theme/assets/css/additional_styles.css
A 
nikola_site_generator/themes/impala-theme/assets/css/bootstrap-responsive.min.css
A nikola_site_generator/themes/impala-theme/assets/css/bootstrap.min.css
A nikola_site_generator/themes/impala-theme/assets/images/incubator.png
A nikola_site_generator/themes/impala-theme/engine
A nikola_site_generator/themes/impala-theme/parent
A nikola_site_generator/themes/impala-theme/templates/base.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_footer.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_header.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_helper.tmpl
A nikola_site_generator/themes/impala-theme/templates/comments_helper.tmpl
A 
nikola_site_generator/themes/impala-theme/templates/comments_helper_disqus.tmpl
A nikola_site_generator/themes/impala-theme/templates/index.tmpl
A nikola_site_generator/themes/impala-theme/templates/index_helper.tmpl
A nikola_site_generator/themes/impala-theme/templates/post.tmpl
A nikola_site_generator/themes/impala-theme/templates/post_header.tmpl
A nikola_site_generator/themes/impala-theme/templates/post_helper.tmpl
46 files changed, 4,273 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/5667/9
-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[David Knupp (Code Review)]

David Knupp has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
..


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5667/8//COMMIT_MSG
Commit Message:

Line 25: Not a lot of effort was spent in setting up the typical bloggish bells
> long line
Done


http://gerrit.cloudera.org:8080/#/c/5667/4/nikola_site_generator/README.md
File nikola_site_generator/README.md:

PS4, Line 44: (blog_env) $ pip install -r requirements.txt
> Can you add a note to that effect?
Done


Line 74: .. slug: my-new-post
> Can you add a note to that effect?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: Yes

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
..


Patch Set 8:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5667/8//COMMIT_MSG
Commit Message:

Line 25: Comments on blog posts is being handled via Disqus. Other than that, 
not a
long line


http://gerrit.cloudera.org:8080/#/c/5667/4/nikola_site_generator/README.md
File nikola_site_generator/README.md:

PS4, Line 44: packages listed in the ```requirements.txt``
> You'd probably have to sudo it, but yeah.
Can you add a note to that effect?


Line 74: You shoud have an empty dated template now that you can fill in.
> The slug is the human-readable last portion of the permalink for a post. E.
Can you add a note to that effect?


-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: Yes

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[David Knupp (Code Review)]

David Knupp has uploaded a new patch set (#8).

Change subject: Initial commit of the blog section of the Impala ASF website.
..

Initial commit of the blog section of the Impala ASF website.

Note: a sample version of the site is up and running at:

   http://dknupp.github.io/blog/

The blog site is generated using Nikola. Nikola is only being used
to manage the blog in this patch, but could easily be used to manage
the other pages as well. It may take a fair bit of tweaking to the
settings and Jinja templates to make everything work properly if Nikola
is to be used for non-blog pages -- a job for when more cycles are
generally available.

The README gives a pretty complete description of the workflow for
adding content to the blog. The formatted README file can be seen at:

https://github.com/dknupp/dknupp.github.io/tree/master/nikola_site_generator

Comments on blog posts is being handled via Disqus. Other than that, not a
lot of effort was spent in setting up some of the typical bloggish
bells and whistles - e.g. RSS/ATOM feeds, etc. Fancier bits can come
later.

Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
---
A .gitignore
A blog/2017/index.html
A blog/archive.html
A blog/assets/css/additional_styles.css
A blog/assets/css/bootstrap-responsive.min.css
A blog/assets/css/bootstrap.min.css
A blog/assets/css/code.css
A blog/assets/css/ipython.min.css
A blog/assets/css/ipython.min.css.map
A blog/assets/css/nikola_ipython.css
A blog/assets/css/rst.css
A blog/assets/css/theme.css
A blog/assets/images/incubator.png
A blog/assets/js/fancydates.js
A blog/assets/js/html5.js
A blog/assets/js/moment-with-locales.min.js
A blog/assets/xml/atom.xsl
A blog/assets/xml/rss.xsl
A blog/categories/index.html
A blog/index.html
A blog/posts/impala-blog-coming-soon/index.html
A blog/posts/impala-blog-coming-soon/index.md
A blog/robots.txt
A blog/sitemap.xml
A blog/sitemapindex.xml
A nikola_site_generator/README.md
A nikola_site_generator/conf.py
A nikola_site_generator/posts/blog-coming-soon.md
A nikola_site_generator/requirements.txt
A nikola_site_generator/themes/impala-theme/assets/css/additional_styles.css
A 
nikola_site_generator/themes/impala-theme/assets/css/bootstrap-responsive.min.css
A nikola_site_generator/themes/impala-theme/assets/css/bootstrap.min.css
A nikola_site_generator/themes/impala-theme/assets/images/incubator.png
A nikola_site_generator/themes/impala-theme/engine
A nikola_site_generator/themes/impala-theme/parent
A nikola_site_generator/themes/impala-theme/templates/base.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_footer.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_header.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_helper.tmpl
A nikola_site_generator/themes/impala-theme/templates/comments_helper.tmpl
A 
nikola_site_generator/themes/impala-theme/templates/comments_helper_disqus.tmpl
A nikola_site_generator/themes/impala-theme/templates/index.tmpl
A nikola_site_generator/themes/impala-theme/templates/index_helper.tmpl
A nikola_site_generator/themes/impala-theme/templates/post.tmpl
A nikola_site_generator/themes/impala-theme/templates/post_header.tmpl
A nikola_site_generator/themes/impala-theme/templates/post_helper.tmpl
46 files changed, 4,266 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/5667/8
-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[David Knupp (Code Review)]

David Knupp has uploaded a new patch set (#7).

Change subject: Initial commit of the blog section of the Impala ASF website.
..

Initial commit of the blog section of the Impala ASF website.

Note: a sample version of the site is up and running at:

   http://dknupp.github.io/blog/

The blog site is generated using Nikola. Nikola is only being used
to manage the blog in this patch, but could easily be used to manage
the other pages as well. It may take a fair bit of tweaking to the
settings and Jinja templates to make everything work properly if Pelican
is to be used for non-blog pages -- a job for when more cycles are
generally available.

The README gives a pretty complete description of the workflow for
adding content to the blog. The formatted README file can be seen at:

https://github.com/dknupp/dknupp.github.io/tree/master/nikola_site_generator

Not a lot of effort was spent in setting up the typical bloggish bells
and whistles - e.g. RSS/ATOM feeds, comments section etc. Fancier bits
can come later.

Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
---
A .gitignore
A blog/2017/index.html
A blog/archive.html
A blog/assets/css/additional_styles.css
A blog/assets/css/bootstrap-responsive.min.css
A blog/assets/css/bootstrap.min.css
A blog/assets/css/code.css
A blog/assets/css/ipython.min.css
A blog/assets/css/ipython.min.css.map
A blog/assets/css/nikola_ipython.css
A blog/assets/css/rst.css
A blog/assets/css/theme.css
A blog/assets/images/incubator.png
A blog/assets/js/fancydates.js
A blog/assets/js/html5.js
A blog/assets/js/moment-with-locales.min.js
A blog/assets/xml/atom.xsl
A blog/assets/xml/rss.xsl
A blog/categories/index.html
A blog/index.html
A blog/posts/impala-blog-coming-soon/index.html
A blog/posts/impala-blog-coming-soon/index.md
A blog/robots.txt
A blog/sitemap.xml
A blog/sitemapindex.xml
A nikola_site_generator/README.md
A nikola_site_generator/conf.py
A nikola_site_generator/posts/blog-coming-soon.md
A nikola_site_generator/requirements.txt
A nikola_site_generator/themes/impala-theme/assets/css/additional_styles.css
A 
nikola_site_generator/themes/impala-theme/assets/css/bootstrap-responsive.min.css
A nikola_site_generator/themes/impala-theme/assets/css/bootstrap.min.css
A nikola_site_generator/themes/impala-theme/assets/images/incubator.png
A nikola_site_generator/themes/impala-theme/engine
A nikola_site_generator/themes/impala-theme/parent
A nikola_site_generator/themes/impala-theme/templates/base.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_footer.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_header.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_helper.tmpl
A nikola_site_generator/themes/impala-theme/templates/comments_helper.tmpl
A 
nikola_site_generator/themes/impala-theme/templates/comments_helper_disqus.tmpl
A nikola_site_generator/themes/impala-theme/templates/index.tmpl
A nikola_site_generator/themes/impala-theme/templates/index_helper.tmpl
A nikola_site_generator/themes/impala-theme/templates/post.tmpl
A nikola_site_generator/themes/impala-theme/templates/post_header.tmpl
A nikola_site_generator/themes/impala-theme/templates/post_helper.tmpl
46 files changed, 4,266 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/5667/7
-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[David Knupp (Code Review)]

David Knupp has uploaded a new patch set (#6).

Change subject: Initial commit of the blog section of the Impala ASF website.
..

Initial commit of the blog section of the Impala ASF website.

Note: a sample version of the site is up and running at:

   http://dknupp.github.io/blog/

The blog site is generated using Nikola. Nikola is only being used
to manage the blog in this patch, but could easily be used to manage
the other pages as well. It may take a fair bit of tweaking to the
settings and Jinja templates to make everything work properly if Pelican
is to be used for non-blog pages -- a job for when more cycles are
generally available.

The README gives a pretty complete description of the workflow for
adding content to the blog. The formatted README file can be seen at:

https://github.com/dknupp/dknupp.github.io/tree/master/nikola_site_generator

Not a lot of effort was spent in setting up the typical bloggish bells
and whistles - e.g. RSS/ATOM feeds, comments section etc. Fancier bits
can come later.

Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
---
A .gitignore
A blog/2017/index.html
A blog/archive.html
A blog/assets/css/additional_styles.css
A blog/assets/css/bootstrap-responsive.min.css
A blog/assets/css/bootstrap.min.css
A blog/assets/css/code.css
A blog/assets/css/ipython.min.css
A blog/assets/css/ipython.min.css.map
A blog/assets/css/nikola_ipython.css
A blog/assets/css/rst.css
A blog/assets/css/theme.css
A blog/assets/images/incubator.png
A blog/assets/js/fancydates.js
A blog/assets/js/html5.js
A blog/assets/js/moment-with-locales.min.js
A blog/assets/xml/atom.xsl
A blog/assets/xml/rss.xsl
A blog/categories/index.html
A blog/index.html
A blog/posts/impala-blog-coming-soon/index.html
A blog/posts/impala-blog-coming-soon/index.md
A blog/robots.txt
A blog/sitemap.xml
A blog/sitemapindex.xml
A nikola_site_generator/README.md
A nikola_site_generator/conf.py
A nikola_site_generator/posts/blog-coming-soon.md
A nikola_site_generator/requirements.txt
A nikola_site_generator/themes/impala-theme/assets/css/additional_styles.css
A 
nikola_site_generator/themes/impala-theme/assets/css/bootstrap-responsive.min.css
A nikola_site_generator/themes/impala-theme/assets/css/bootstrap.min.css
A nikola_site_generator/themes/impala-theme/assets/images/incubator.png
A nikola_site_generator/themes/impala-theme/engine
A nikola_site_generator/themes/impala-theme/parent
A nikola_site_generator/themes/impala-theme/templates/base.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_footer.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_header.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_helper.tmpl
A nikola_site_generator/themes/impala-theme/templates/comments_helper.tmpl
A 
nikola_site_generator/themes/impala-theme/templates/comments_helper_disqus.tmpl
A nikola_site_generator/themes/impala-theme/templates/index.tmpl
A nikola_site_generator/themes/impala-theme/templates/index_helper.tmpl
A nikola_site_generator/themes/impala-theme/templates/post.tmpl
A nikola_site_generator/themes/impala-theme/templates/post_header.tmpl
A nikola_site_generator/themes/impala-theme/templates/post_helper.tmpl
46 files changed, 4,274 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/5667/6
-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[David Knupp (Code Review)]

David Knupp has uploaded a new patch set (#5).

Change subject: Initial commit of the blog section of the Impala ASF website.
..

Initial commit of the blog section of the Impala ASF website.

Note: a sample version of the site is up and running at:

   http://dknupp.github.io/blog/

The blog site is generated using Nikola. Nikola is only being used
to manage the blog in this patch, but could easily be used to manage
the other pages as well. It may take a fair bit of tweaking to the
settings and Jinja templates to make everything work properly if Pelican
is to be used for non-blog pages -- a job for when more cycles are
generally available.

The README gives a pretty complete description of the workflow for
adding content to the blog. The formatted README file can be seen at:

https://github.com/dknupp/dknupp.github.io/tree/master/nikola_site_generator

Not a lot of effort was spent in setting up the typical bloggish bells
and whistles - e.g. RSS/ATOM feeds, comments section etc. Fancier bits
can come later.

Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
---
A .gitignore
A blog/2017/index.html
A blog/archive.html
A blog/assets/css/additional_styles.css
A blog/assets/css/bootstrap-responsive.min.css
A blog/assets/css/bootstrap.min.css
A blog/assets/css/code.css
A blog/assets/css/ipython.min.css
A blog/assets/css/ipython.min.css.map
A blog/assets/css/nikola_ipython.css
A blog/assets/css/rst.css
A blog/assets/css/theme.css
A blog/assets/images/incubator.png
A blog/assets/js/fancydates.js
A blog/assets/js/html5.js
A blog/assets/js/moment-with-locales.min.js
A blog/assets/xml/atom.xsl
A blog/assets/xml/rss.xsl
A blog/categories/index.html
A blog/index.html
A blog/posts/impala-blog-coming-soon/index.html
A blog/posts/impala-blog-coming-soon/index.md
A blog/robots.txt
A blog/sitemap.xml
A blog/sitemapindex.xml
A nikola_site_generator/README.md
A nikola_site_generator/conf.py
A nikola_site_generator/posts/blog-coming-soon.md
A nikola_site_generator/requirements.txt
A nikola_site_generator/themes/impala-theme/assets/css/additional_styles.css
A 
nikola_site_generator/themes/impala-theme/assets/css/bootstrap-responsive.min.css
A nikola_site_generator/themes/impala-theme/assets/css/bootstrap.min.css
A nikola_site_generator/themes/impala-theme/assets/images/incubator.png
A nikola_site_generator/themes/impala-theme/engine
A nikola_site_generator/themes/impala-theme/parent
A nikola_site_generator/themes/impala-theme/templates/base.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_footer.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_header.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_helper.tmpl
A nikola_site_generator/themes/impala-theme/templates/comments_helper.tmpl
A 
nikola_site_generator/themes/impala-theme/templates/comments_helper_disqus.tmpl
A nikola_site_generator/themes/impala-theme/templates/index.tmpl
A nikola_site_generator/themes/impala-theme/templates/index_helper.tmpl
A nikola_site_generator/themes/impala-theme/templates/post.tmpl
A nikola_site_generator/themes/impala-theme/templates/post_header.tmpl
A nikola_site_generator/themes/impala-theme/templates/post_helper.tmpl
46 files changed, 4,236 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/5667/5
-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[David Knupp (Code Review)]

David Knupp has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
..


Patch Set 4:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/5667/4/nikola_site_generator/README.md
File nikola_site_generator/README.md:

Line 18: You will need to install a few python packages to work with Nikola. 
It's up to you whether you
> Can you word wrap at 90 characters like in the Java and C++ source code?
Done


PS4, Line 44: (blog_env) $ pip install -r requirements.txt
> This is the only line I need if I don't wish to use a virtualenv, right?
You'd probably have to sudo it, but yeah.


Line 74: .. slug: my-new-post
> What is a slug?
The slug is the human-readable last portion of the permalink for a post. E.g., 
if my blog post is titled "Apache Kudu and Apache Impala (Incubating): The 
Integration Roadmap", I might want to have the slug be something like 
"kudu-impala-integration-roadmap", making the permalink to the article: 
http://impala.apache.org/blog/posts/kudu-impala-integration-roadmap/.


PS4, Line 110: ``TEASER_END```
> mismatched number of backticks
Done


PS4, Line 163: browser
> I think I can also just point my browser at the .html files with "file:///.
Apparently so. In my experience, it's usually better to run a simple 
development server, but maybe that's because I've done more with dynamically 
generated sites. In this case, it seems not to matter.


-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: Yes

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
..


Patch Set 4:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/5667/4/nikola_site_generator/README.md
File nikola_site_generator/README.md:

Line 18: You will need to install a few python packages to work with Nikola. 
It's up to you whether you
Can you word wrap at 90 characters like in the Java and C++ source code?


PS4, Line 44: (blog_env) $ pip install -r requirements.txt
This is the only line I need if I don't wish to use a virtualenv, right?


Line 74: .. slug: my-new-post
What is a slug?


PS4, Line 110: ``TEASER_END```
mismatched number of backticks


PS4, Line 163: browser
I think I can also just point my browser at the .html files with 
"file:////space-poetry.html", yes?


-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: Yes

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[David Knupp (Code Review)]

David Knupp has uploaded a new patch set (#4).

Change subject: Initial commit of the blog section of the Impala ASF website.
..

Initial commit of the blog section of the Impala ASF website.

Note: a sample version of the site is up and running at:

   http://dknupp.github.io/blog/

The blog site is generated using Nikola. Nikola is only being used
to manage the blog in this patch, but could easily be used to manage
the other pages as well. It may take a fair bit of tweaking to the
settings and Jinja templates to make everything work properly if Pelican
is to be used for non-blog pages -- a job for when more cycles are
generally available.

The README gives a pretty complete description of the workflow for
adding content to the blog. The formatted README file can be seen at:

https://github.com/dknupp/dknupp.github.io/tree/master/nikola_site_generator

Not a lot of effort was spent in setting up the typical bloggish bells
and whistles - e.g. RSS/ATOM feeds, comments section etc. Fancier bits
can come later.

Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
---
A .gitignore
A blog/2017/index.html
A blog/archive.html
A blog/assets/css/additional_styles.css
A blog/assets/css/bootstrap-responsive.min.css
A blog/assets/css/bootstrap.min.css
A blog/assets/css/code.css
A blog/assets/css/ipython.min.css
A blog/assets/css/ipython.min.css.map
A blog/assets/css/nikola_ipython.css
A blog/assets/css/rst.css
A blog/assets/css/theme.css
A blog/assets/images/incubator.png
A blog/assets/js/fancydates.js
A blog/assets/js/html5.js
A blog/assets/js/moment-with-locales.min.js
A blog/assets/xml/atom.xsl
A blog/assets/xml/rss.xsl
A blog/categories/index.html
A blog/index.html
A blog/posts/impala-blog-coming-soon/index.html
A blog/posts/impala-blog-coming-soon/index.md
A blog/robots.txt
A blog/sitemap.xml
A blog/sitemapindex.xml
A nikola_site_generator/README.md
A nikola_site_generator/conf.py
A nikola_site_generator/posts/blog-coming-soon.md
A nikola_site_generator/requirements.txt
A nikola_site_generator/themes/impala-theme/assets/css/additional_styles.css
A 
nikola_site_generator/themes/impala-theme/assets/css/bootstrap-responsive.min.css
A nikola_site_generator/themes/impala-theme/assets/css/bootstrap.min.css
A nikola_site_generator/themes/impala-theme/assets/images/incubator.png
A nikola_site_generator/themes/impala-theme/engine
A nikola_site_generator/themes/impala-theme/parent
A nikola_site_generator/themes/impala-theme/templates/base.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_footer.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_header.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_helper.tmpl
A nikola_site_generator/themes/impala-theme/templates/comments_helper.tmpl
A 
nikola_site_generator/themes/impala-theme/templates/comments_helper_disqus.tmpl
A nikola_site_generator/themes/impala-theme/templates/index.tmpl
A nikola_site_generator/themes/impala-theme/templates/index_helper.tmpl
A nikola_site_generator/themes/impala-theme/templates/post.tmpl
A nikola_site_generator/themes/impala-theme/templates/post_header.tmpl
A nikola_site_generator/themes/impala-theme/templates/post_helper.tmpl
46 files changed, 4,194 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/5667/4
-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
..


Patch Set 3:

> > There's probably no reason not to. I went ahead and pushed a
 > > version with comments to my personal github repo so you can see
 > > what it's like.
 > >
 > > https://dknupp.github.io/blog/
 > 
 > This shows a number of strange strings in my Chrome on Linux,
 > including:
 > 
 > …
 > 
 > •
 > 
 > ›

I don't see them on my laptop

-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
..


Patch Set 3:

> There's probably no reason not to. I went ahead and pushed a
 > version with comments to my personal github repo so you can see
 > what it's like.
 > 
 > https://dknupp.github.io/blog/

This shows a number of strange strings in my Chrome on Linux, including:

…

•

›

-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[David Knupp (Code Review)]

David Knupp has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
..


Patch Set 3:

There's probably no reason not to. I went ahead and pushed a version with 
comments to my personal github repo so you can see what it's like.

https://dknupp.github.io/blog/

-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[David Knupp (Code Review)]

David Knupp has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
..


Patch Set 3:

A couple -- Isso and Disqus. Disqus seemed the best so far. Isso didn't even 
render properly.

-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
..


Patch Set 3:

Have you had a chance to test this with a commenting system?

-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[David Knupp (Code Review)]

David Knupp has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5667/3/blog/assets/js/html5.js
File blog/assets/js/html5.js:

Line 2:  HTML5 Shiv v3.7.0 | @afarkas @jdalton @jon_neal @rem | MIT/GPL2 
Licensed
> https://issues.apache.org/jira/browse/LEGAL-285
FYI:

"IMO yes see [1] you can just select the MIT license. Given that your probably 
not bundling this in a release it probably doesn't matter."

https://issues.apache.org/jira/browse/LEGAL-285


-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: Yes

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[David Knupp (Code Review)]

David Knupp has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5667/3/blog/assets/js/html5.js
File blog/assets/js/html5.js:

Line 2:  HTML5 Shiv v3.7.0 | @afarkas @jdalton @jon_neal @rem | MIT/GPL2 
Licensed
> https://issues.apache.org/jira/browse/LEGAL-284?jql=project%20%3D%20LEGAL t
https://issues.apache.org/jira/browse/LEGAL-285

Also, note wording here:

https://github.com/aFarkas/html5shiv/blob/master/MIT%20and%20GPL2%20licenses.md


-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: Yes

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[David Knupp (Code Review)]

David Knupp has abandoned this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
..


Abandoned

Abandoned in lieu of https://gerrit.cloudera.org/5667

-- 
To view, visit http://gerrit.cloudera.org:8080/4944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iaa578a70237fcc97589c667c17a70d3d6dad5ae1
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[David Knupp (Code Review)]

David Knupp has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5667

Change subject: Initial commit of the blog section of the Impala ASF website.
..

Initial commit of the blog section of the Impala ASF website.

Note: a sample version of the site is up and running at:

   http://dknupp.github.io/blog/

The blog site is generated using Nikola. Nikola is only being used
to manage the blog in this patch, but could easily be used to manage
the other pages as well. It may take a fair bit of tweaking to the
settings and Jinja templates to make everything work properly if Pelican
is to be used for non-blog pages -- a job for when more cycles are
generally available.

The README gives a pretty complete description of the workflow for
adding content to the blog. The formatted README file can be seen at:

https://github.com/dknupp/dknupp.github.io/tree/master/nikola_site_generator

Not a lot of effort was spent in setting up the typical bloggish bells
and whistles - e.g. RSS/ATOM feeds, comments section etc. Fancier bits
can come later.

Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
---
A .gitignore
A blog/2017/index.html
A blog/archive.html
A blog/assets/css/additional_styles.css
A blog/assets/css/bootstrap-responsive.min.css
A blog/assets/css/bootstrap.min.css
A blog/assets/css/code.css
A blog/assets/css/ipython.min.css
A blog/assets/css/ipython.min.css.map
A blog/assets/css/nikola_ipython.css
A blog/assets/css/rst.css
A blog/assets/css/theme.css
A blog/assets/images/incubator.png
A blog/assets/js/fancydates.js
A blog/assets/js/html5.js
A blog/assets/js/moment-with-locales.min.js
A blog/assets/xml/atom.xsl
A blog/assets/xml/rss.xsl
A blog/categories/index.html
A blog/index.html
A blog/posts/impala-blog-coming-soon/index.html
A blog/posts/impala-blog-coming-soon/index.md
A blog/robots.txt
A blog/sitemap.xml
A blog/sitemapindex.xml
A nikola_site_generator/README.md
A nikola_site_generator/conf.py
A nikola_site_generator/posts/blog-coming-soon.md
A nikola_site_generator/requirements.txt
A nikola_site_generator/themes/impala-theme/assets/css/additional_styles.css
A 
nikola_site_generator/themes/impala-theme/assets/css/bootstrap-responsive.min.css
A nikola_site_generator/themes/impala-theme/assets/css/bootstrap.min.css
A nikola_site_generator/themes/impala-theme/assets/images/incubator.png
A nikola_site_generator/themes/impala-theme/engine
A nikola_site_generator/themes/impala-theme/parent
A nikola_site_generator/themes/impala-theme/templates/base.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_footer.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_header.tmpl
A nikola_site_generator/themes/impala-theme/templates/base_helper.tmpl
A nikola_site_generator/themes/impala-theme/templates/index.tmpl
A nikola_site_generator/themes/impala-theme/templates/index_helper.tmpl
A nikola_site_generator/themes/impala-theme/templates/post.tmpl
A nikola_site_generator/themes/impala-theme/templates/post_header.tmpl
A nikola_site_generator/themes/impala-theme/templates/post_helper.tmpl
44 files changed, 4,061 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/5667/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4944/1/pelicanconf.py
File pelicanconf.py:

Line 1: #!/usr/bin/env python
> I wasn't sure what to do about this. I noticed that while some of our third
The licenses in the master branch are spelled out in 
https://github.com/apache/incubator-impala/blob/master/LICENSE.txt

I suspect AGPL would prevent us form using Pelican unless we author all of the 
templates ourselves:

https://www.apache.org/legal/resolved

We had to take to comments out of our Doxygen file, for instance, because they 
were included in Doxygen source files and not given an Apache-compatible 
license.

Does Pelican license the templates differently?


-- 
To view, visit http://gerrit.cloudera.org:8080/4944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa578a70237fcc97589c667c17a70d3d6dad5ae1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: Yes

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[David Knupp (Code Review)]

David Knupp has uploaded a new patch set (#2).

Change subject: Initial commit of the blog section of the Impala ASF website.
..

Initial commit of the blog section of the Impala ASF website.

Note: a sample version of the site is up and running at:

   http://dknupp.github.io

The blog site is generated using Pelican. Pelican is only being used
to manage the blog in this patch, but could easily be used to manage
the other pages as well. It may take a fair bit of tweaking to the
settings and Jinja templates to make everything work properly if Pelican
is to be used for non-blog pages -- a job for when more cycles are
generally available.

The README gives a pretty complete description of the workflow for
adding content to the blog. The formatted README file can be seen at:

   https://github.com/dknupp/dknupp.github.io/tree/master/blog

Not a lot of effort was spent in setting up the typical bloggish bells
and whistles - e.g. category pages, themes, comments section etc.
Although there are some theme files included (templates), most are
unused for now. This is just pretty bare bones stuff. The fancy bits
can come later.

There were some minor edits to existing pages to get links working, but
mostly this is new stuff.

Change-Id: Iaa578a70237fcc97589c667c17a70d3d6dad5ae1
---
A .gitignore
A blog/README.md
A blog/impala-blog-coming-soon.html
A blog/index.html
A blog_content/article.md
M bylaws.html
M community.html
M downloads.html
M impala-docs.html
M index.html
M overview.html
A pelicanconf.py
A requirements.txt
A themes/impala_asf_site_theme/templates/archives.html
A themes/impala_asf_site_theme/templates/article.html
A themes/impala_asf_site_theme/templates/author.html
A themes/impala_asf_site_theme/templates/authors.html
A themes/impala_asf_site_theme/templates/base.html
A themes/impala_asf_site_theme/templates/categories.html
A themes/impala_asf_site_theme/templates/category.html
A themes/impala_asf_site_theme/templates/index.html
A themes/impala_asf_site_theme/templates/page.html
A themes/impala_asf_site_theme/templates/pagination.html
A themes/impala_asf_site_theme/templates/period_archives.html
A themes/impala_asf_site_theme/templates/tag.html
A themes/impala_asf_site_theme/templates/tags.html
A themes/impala_asf_site_theme/templates/translations.html
27 files changed, 989 insertions(+), 56 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/4944/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa578a70237fcc97589c667c17a70d3d6dad5ae1
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: David Knupp 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[David Knupp (Code Review)]

David Knupp has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
..


Patch Set 1:

(18 comments)

http://gerrit.cloudera.org:8080/#/c/4944/1//COMMIT_MSG
Commit Message:

PS1, Line 16: work properly
> "work properly if Pelican is to be used for non-blog pages -- a job"
Done


PS1, Line 25: comments section
> This is presumably not possible with a static site generator without disqus
Exactly. Disqus seems to be a popular approach.


http://gerrit.cloudera.org:8080/#/c/4944/1/Makefile
File Makefile:

Line 1: PY?=python
> This deserves comments.
To get this up quickly for people to start adding articles, my approach was to 
just do the bare bones, default creation of a Pelican site, and not invest too 
much time in tweaking or pruning it. I didn't want to hastily delete something, 
and if/when we decide to spend more time on the site later, have to then 
re-spawn or re-fetch a file that had been removed earlier.

By default, you get this Makefile and the publishconf.py file when you create a 
new site. We actually don't use ANY of it, so I haven't touched a single line. 
I'll go ahead and delete them.


http://gerrit.cloudera.org:8080/#/c/4944/1/blog/README.md
File blog/README.md:

Line 5: 
> extra blank line?
Done


PS1, Line 20:  path/to/venv
> What is this path? How do I find it?
Ah. It can be any path you want it to be. This is the canonical way that a 
typical python developer works with virtual environments. You use the 
virtualenv tool to create a new virtual environment some place that makes sense 
to you, which you can then activate and deactivate as needed. It's common to 
have multiple isolated environments for different projects, that may each have 
different versions of common libs, or even different versions of the python 
executable. 

E.g, if you run:

   $ source $IMPALA_HOME/infra/python/env/bin/activate
   (env) $

then anywhere you are, whenever you invoke plain ol' python, you're actually 
using the executable inside infra/python/env/bin/ that we're accustomed to 
invoking indirectly via the 'impala-python' wrapper.

   (env) $ which python
   /home/dknupp/Impala/infra/python/env/bin/python

I've updated the README to provide more information about using virtualenv.


PS1, Line 24: (impala_blog)
> What is this?
See updated README.


Line 32: Articles are stored as markdown files in the ```blog_content/``` 
directory, and follow a specific template. The name of the file is not 
important, as long as it's unique. You sould probably create this file on a new 
working branch in the repo.
> Long line, here and below
Done


Line 108: Don't forget to ```deactivate``` your virtualenv when you're done 
working on the blog.
> How?
See updated README.


http://gerrit.cloudera.org:8080/#/c/4944/1/pelicanconf.py
File pelicanconf.py:

Line 1: #!/usr/bin/env python
> licence header, please
I wasn't sure what to do about this. I noticed that while some of our third 
party code includes a license header:

https://github.com/apache/incubator-impala/blob/master/www/bootstrap/js/bootstrap.js

Some of our third party code doesn't:

https://github.com/apache/incubator-impala/blob/master/shell/ext-py/prettytable-0.7.1/setup.py

Can you tell me explicitly what to put here? (FYI, Pelican has the AGPL 
license: https://github.com/getpelican/pelican/blob/master/LICENSE.)


Line 3: from __future__ import unicode_literals
> Why?
This is code that many developers put at the beginning of their python files to 
ease transition from 2 to 3. Python 3 has several backward-breaking changes. 
The standard list of __future__ imports actually includes more. There's also 
absolute_import, division, and print_function. (Aside: if we ever have to 
support Python 3 in Impala, we may be somewhat screwed. For starters, I see a 
lot print statements liberally scattered throughout our code base that will all 
raise exceptions under python 3.x.)

I didn't actually put this line in this file. When the file was auto-spawned, 
it was there. All I did in this file was provide meaningful values for a few of 
the settings. For more specific info on this line, see 
http://blog.getpelican.com/pelicans-unified-codebase.html for more info.


Line 5: AUTHOR = u'Impala Dev'
> Does this need to be customized?
More than it is?  The docs said to make this setting the "default author." Blog 
posts will still respect the Author: field in markdown files. I think it only 
gets used of we don't specify a blog author, or if we explicitly use {{AUTHOR}} 
on one of the template files.


Line 22: # Blogroll
> These could be removed or more clearly explained
Boilerplate that came when this file was spawned. (A lot of blogs have a 
blogroll.) Removed.


Line 32: DEFAULT_PAGINATION = 100
> 100 posts per page?
Oops. I think that was supposed to be 10. How about 10?


Line 38: # Uncomment following line if you want document-relative 

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
..


Patch Set 1:

(19 comments)

http://gerrit.cloudera.org:8080/#/c/4944/1//COMMIT_MSG
Commit Message:

This is a large commit, so I may take a few rounds to review all of it.


PS1, Line 16: work properly
"work properly if Pelican is to be used for non-blog pages -- a job"


PS1, Line 25: comments section
This is presumably not possible with a static site generator without disqus or 
embedding Facebook comments or something with JS?


http://gerrit.cloudera.org:8080/#/c/4944/1/Makefile
File Makefile:

Line 1: PY?=python
This deserves comments.

Also, I assume it was not written by you (given the many make options we don't 
use). If so, it needs a license header.


http://gerrit.cloudera.org:8080/#/c/4944/1/blog/README.md
File blog/README.md:

Line 5: 
extra blank line?


PS1, Line 20:  path/to/venv
What is this path? How do I find it?


PS1, Line 24: (impala_blog)
What is this?


Line 32: Articles are stored as markdown files in the ```blog_content/``` 
directory, and follow a specific template. The name of the file is not 
important, as long as it's unique. You sould probably create this file on a new 
working branch in the repo.
Long line, here and below


Line 108: Don't forget to ```deactivate``` your virtualenv when you're done 
working on the blog.
How?


http://gerrit.cloudera.org:8080/#/c/4944/1/pelicanconf.py
File pelicanconf.py:

Line 1: #!/usr/bin/env python
licence header, please


Line 3: from __future__ import unicode_literals
Why?


Line 5: AUTHOR = u'Impala Dev'
Does this need to be customized?


Line 22: # Blogroll
These could be removed or more clearly explained


Line 32: DEFAULT_PAGINATION = 100
100 posts per page?


Line 38: # Uncomment following line if you want document-relative URLs when 
developing
Why not?


http://gerrit.cloudera.org:8080/#/c/4944/1/themes/impala_asf_site_theme/templates/base.html
File themes/impala_asf_site_theme/templates/base.html:

Line 2: 
It would be good if this file mentioned in an HTML comment at the top that the 
HTML is automatically generated and should not be hand-edited.


http://gerrit.cloudera.org:8080/#/c/4944/1/themes/impala_asf_site_theme/templates/gosquared.html
File themes/impala_asf_site_theme/templates/gosquared.html:

Line 1: {% if GOSQUARED_SITENAME %}
What is this all about?


http://gerrit.cloudera.org:8080/#/c/4944/1/themes/impala_asf_site_theme/templates/page.html
File themes/impala_asf_site_theme/templates/page.html:

Line 12:Last updated: {{ page.locale_modified }}
We generally avoid tabs


http://gerrit.cloudera.org:8080/#/c/4944/1/themes/impala_asf_site_theme/templates/tag.html
File themes/impala_asf_site_theme/templates/tag.html:

What is this for?


-- 
To view, visit http://gerrit.cloudera.org:8080/4944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa578a70237fcc97589c667c17a70d3d6dad5ae1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: Yes

[Impala-ASF-CR](asf-site) Initial commit of the blog section of the Impala ASF website.

[David Knupp (Code Review)]

David Knupp has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4944

Change subject: Initial commit of the blog section of the Impala ASF website.
..

Initial commit of the blog section of the Impala ASF website.

Note: a sample version of the site is up and running at:

   http://dknupp.github.io

The blog site is generated using Pelican. Pelican is only being used to
manage the blog in this patch, but could easily be used to manage the
other pages as well. It may take a fair bit of tweaking to the settings
and Jinja templates to make everything work properly -- a job for when
more cycles are generally available.

The README gives a pretty complete description of the workflow for
adding content to the blog. The formatted README file can be seen at:

   https://github.com/dknupp/dknupp.github.io/tree/master/blog

Not a lot of effort was spent in setting up the typical bloggish bells
and whistles - e.g. category pages, themes, comments section etc.
Although there are some theme files included (templates), most are
unused for now. This is just pretty bare bones stuff. The fancy bits
can come later.

There were some minor edits to existing pages to get links working, but
mostly this is new stuff.

Change-Id: Iaa578a70237fcc97589c667c17a70d3d6dad5ae1
---
A .gitignore
A Makefile
A blog/README.md
A blog/impala-blog-coming-soon.html
A blog/index.html
A blog_content/article.md
M bylaws.html
M community.html
M downloads.html
M impala-docs.html
M index.html
M overview.html
A pelicanconf.py
A publishconf.py
A requirements.txt
A themes/impala_asf_site_theme/templates/archives.html
A themes/impala_asf_site_theme/templates/article.html
A themes/impala_asf_site_theme/templates/author.html
A themes/impala_asf_site_theme/templates/authors.html
A themes/impala_asf_site_theme/templates/base.html
A themes/impala_asf_site_theme/templates/categories.html
A themes/impala_asf_site_theme/templates/category.html
A themes/impala_asf_site_theme/templates/gosquared.html
A themes/impala_asf_site_theme/templates/index.html
A themes/impala_asf_site_theme/templates/page.html
A themes/impala_asf_site_theme/templates/pagination.html
A themes/impala_asf_site_theme/templates/period_archives.html
A themes/impala_asf_site_theme/templates/tag.html
A themes/impala_asf_site_theme/templates/tags.html
A themes/impala_asf_site_theme/templates/translations.html
30 files changed, 1,125 insertions(+), 56 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/4944/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa578a70237fcc97589c667c17a70d3d6dad5ae1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple