[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-21 Thread John Russell (Code Review) 
John Russell has posted comments on this change.

Change subject: [DOCS] Replace LZO setup instructions with placeholder
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6439/4/docs/topics/impala_txtfile.xml
File docs/topics/impala_txtfile.xml:

PS4, Line 491: 
 :   
 : The download details for the 
impala-lzo package are under construction.
 :   
 : 
After discussion, decided to take out this  too.


-- 
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: Yes

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-21 Thread Laurel Hale (Code Review) 
Laurel Hale has posted comments on this change.

Change subject: [DOCS] Replace LZO setup instructions with placeholder
..


Patch Set 4: Code-Review+1

Patch 4 builds cleanly and the content renders well in the html & pdf output.

-- 
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-21 Thread John Russell (Code Review) 
John Russell has posted comments on this change.

Change subject: [DOCS] Replace LZO setup instructions with placeholder
..


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6439/1/docs/topics/impala_txtfile.xml
File docs/topics/impala_txtfile.xml:

PS1, Line 538: 
> Replace this 'cdh' portion of the filename with a generic placeholder.
Done


http://gerrit.cloudera.org:8080/#/c/6439/2/docs/topics/impala_txtfile.xml
File docs/topics/impala_txtfile.xml:

PS2, Line 562: 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
> IN particular this section and one at the top seem likely to be universal, 
I'm happy either way. With partial instructions left in, Apache Impala users 
might be able to puzzle through the rest of it themselves. I'll put those 
pieces back. It isn't clear to me though exactly how much of the earlier stuff 
is really relevant. (Will Apache Impala users run any apt-get / yum / zypper 
commands at all or would they be building both impala-lzo and hadoop-lzo from 
source?)


-- 
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: Yes

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-21 Thread John Russell (Code Review) 
Hello Laurel Hale,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/6439

to look at the new patch set (#4).

Change subject: [DOCS] Replace LZO setup instructions with placeholder
..

[DOCS] Replace LZO setup instructions with placeholder

An "under construction" banner since non-Cloudera-specific
URLs are not available at this time, and the information
itself may be out of date / inapplicable for Apache Impala
project users.

Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
---
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_txtfile.xml
2 files changed, 9 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/6439/4
-- 
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-20 Thread Laurel Hale (Code Review) 
Laurel Hale has posted comments on this change.

Change subject: [DOCS] Replace LZO setup instructions with placeholder
..


Patch Set 3: Code-Review+1

Builds cleanly and renders well in both html & pdf.

-- 
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-20 Thread Jim Apple (Code Review) 
Jim Apple has posted comments on this change.

Change subject: [DOCS] Replace LZO setup instructions with placeholder
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6439/2/docs/topics/impala_txtfile.xml
File docs/topics/impala_txtfile.xml:

PS2, Line 562: 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
 : 
IN particular this section and one at the top seem likely to be universal, no 
matter which LZO library is used


-- 
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: Yes

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-20 Thread Jim Apple (Code Review) 
Jim Apple has posted comments on this change.

Change subject: [DOCS] Replace LZO setup instructions with placeholder
..


Patch Set 2:

I thought the plan was to leave in as much as possible about LZO?

-- 
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-20 Thread John Russell (Code Review) 
John Russell has posted comments on this change.

Change subject: [DOCS] Replace LZO setup instructions with placeholder
..


Patch Set 3:

Patch set 2 = fix a stray 'cdh' inside the same impala_txtfile page.
Patch set 3 = fix a reference to the old package name including -cdh4 that I 
had genericized elsewhere.

-- 
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-20 Thread John Russell (Code Review) 
John Russell has uploaded a new patch set (#3).

Change subject: [DOCS] Replace LZO setup instructions with placeholder
..

[DOCS] Replace LZO setup instructions with placeholder

An "under construction" banner since non-Cloudera-specific
URLs are not available at this time, and the information
itself may be out of date / inapplicable for Apache Impala
project users.

Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
---
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_txtfile.xml
2 files changed, 4 insertions(+), 121 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/6439/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-20 Thread John Russell (Code Review) 
John Russell has uploaded a new patch set (#2).

Change subject: [DOCS] Replace LZO setup instructions with placeholder
..

[DOCS] Replace LZO setup instructions with placeholder

An "under construction" banner since non-Cloudera-specific
URLs are not available at this time, and the information
itself may be out of date / inapplicable for Apache Impala
project users.

Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
---
M docs/topics/impala_txtfile.xml
1 file changed, 3 insertions(+), 120 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/6439/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-20 Thread John Russell (Code Review) 
John Russell has posted comments on this change.

Change subject: [DOCS] Replace LZO setup instructions with placeholder
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6439/1/docs/topics/impala_txtfile.xml
File docs/topics/impala_txtfile.xml:

PS1, Line 538: cdh4-0.4.15
Replace this 'cdh' portion of the filename with a generic placeholder.


-- 
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Laurel Hale 
Gerrit-HasComments: Yes

[Impala-ASF-CR] [DOCS] Replace LZO setup instructions with placeholder

2017-03-20 Thread John Russell (Code Review) 
John Russell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6439

Change subject: [DOCS] Replace LZO setup instructions with placeholder
..

[DOCS] Replace LZO setup instructions with placeholder

An "under construction" banner since non-Cloudera-specific
URLs are not available at this time, and the information
itself may be out of date / inapplicable for Apache Impala
project users.

Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
---
M docs/topics/impala_txtfile.xml
1 file changed, 1 insertion(+), 118 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/6439/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idea5a28a73287b6b3a023843ddada88204db7b1b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell