[Impala-ASF-CR] Don't overwrite user's .ssh/config file when bootstrapping

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: Don't overwrite user's .ssh/config file when bootstrapping
..


Patch Set 3:

> Build failed: 
> http://ec2-35-161-220-160.us-west-2.compute.amazonaws.com:8080/job/gerrit-verify-dryrun/30/

This was just me testing the verification system

-- 
To view, visit http://gerrit.cloudera.org:8080/4967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d1a56441fcb5a2a2aed043fc1ece866c5d8287a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: No

[Impala-ASF-CR] Don't overwrite user's .ssh/config file when bootstrapping

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: Don't overwrite user's .ssh/config file when bootstrapping
..


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d1a56441fcb5a2a2aed043fc1ece866c5d8287a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: No

[Impala-ASF-CR] Don't overwrite user's .ssh/config file when bootstrapping

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged.

Change subject: Don't overwrite user's .ssh/config file when bootstrapping
..


Don't overwrite user's .ssh/config file when bootstrapping

>From bash's manual page on redirecting with '>'

Redirection of output causes the file whose name results from the
expansion of word to be opened for writing on file descriptor n,
or the standard output (file descriptor 1) if n is not specified.
If the file does not exist it is created; if it does exist it is
truncated to zero size.

Change-Id: I0d1a56441fcb5a2a2aed043fc1ece866c5d8287a
Reviewed-on: http://gerrit.cloudera.org:8080/4967
Reviewed-by: Jim Apple 
Tested-by: Impala Public Jenkins
---
M bin/bootstrap_development.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Jim Apple: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/4967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0d1a56441fcb5a2a2aed043fc1ece866c5d8287a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 

[Impala-ASF-CR] Don't overwrite user's .ssh/config file when bootstrapping

[Dan Hecht (Code Review)]

Dan Hecht has posted comments on this change.

Change subject: Don't overwrite user's .ssh/config file when bootstrapping
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d1a56441fcb5a2a2aed043fc1ece866c5d8287a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: No

[Impala-ASF-CR] Don't overwrite user's .ssh/config file when bootstrapping

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: Don't overwrite user's .ssh/config file when bootstrapping
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4967/1//COMMIT_MSG
Commit Message:

Line 7: Don't overwrite user's .ssh/config file when bootstrapping
> Jira?
It seemed like overkill. Honestly, so does my commit message.


-- 
To view, visit http://gerrit.cloudera.org:8080/4967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d1a56441fcb5a2a2aed043fc1ece866c5d8287a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: Yes

[Impala-ASF-CR] Don't overwrite user's .ssh/config file when bootstrapping

[Michael Brown (Code Review)]

Michael Brown has posted comments on this change.

Change subject: Don't overwrite user's .ssh/config file when bootstrapping
..


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4967/1//COMMIT_MSG
Commit Message:

Line 7: Don't overwrite user's .ssh/config file when bootstrapping
Jira?


-- 
To view, visit http://gerrit.cloudera.org:8080/4967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d1a56441fcb5a2a2aed043fc1ece866c5d8287a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Michael Brown 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: Yes

[Impala-ASF-CR] Don't overwrite user's .ssh/config file when bootstrapping

[Jim Apple (Code Review)]

Jim Apple has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4967

Change subject: Don't overwrite user's .ssh/config file when bootstrapping
..

Don't overwrite user's .ssh/config file when bootstrapping

>From bash's manual page on redirecting with '>'

Redirection of output causes the file whose name results from the
expansion of word to be opened for writing on file descriptor n,
or the standard output (file descriptor 1) if n is not specified.
If the file does not exist it is created; if it does exist it is
truncated to zero size.

Change-Id: I0d1a56441fcb5a2a2aed043fc1ece866c5d8287a
---
M bin/bootstrap_development.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/4967/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d1a56441fcb5a2a2aed043fc1ece866c5d8287a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple