[Impala-ASF-CR] Expose $IMPALA MAVEN OPTIONS for configuring Maven.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8496 ) Change subject: Expose $IMPALA_MAVEN_OPTIONS for configuring Maven. .. Expose $IMPALA_MAVEN_OPTIONS for configuring Maven. With this commit, $IMPALA_MAVEN_OPTIONS is used by bin/mvn-quiet.sh to configure Maven slightly. The default is no extra options. This is handy for giving Maven a settings file with the "-s" flag, to control, for example, repositories and their mirrors. In fact, I considered exposing IMPALA_MAVEN_SETTINGS_FILE explicitly, but decided that the generic option would be as good. It's useful to customize how Maven works, especially to provide a settings file with repository mirrors. Change-Id: I2c62185476fd2388c7cda8884276b79a77370127 Reviewed-on: http://gerrit.cloudera.org:8080/8496 Reviewed-by: Joe McDonnellTested-by: Impala Public Jenkins --- M bin/impala-config.sh M bin/mvn-quiet.sh M testdata/bin/generate-block-ids.sh M testdata/bin/generate-load-nested.sh M testdata/bin/split-hbase.sh 5 files changed, 14 insertions(+), 8 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2c62185476fd2388c7cda8884276b79a77370127 Gerrit-Change-Number: 8496 Gerrit-PatchSet: 5 Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Expose $IMPALA MAVEN OPTIONS for configuring Maven.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8496 ) Change subject: Expose $IMPALA_MAVEN_OPTIONS for configuring Maven. .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c62185476fd2388c7cda8884276b79a77370127 Gerrit-Change-Number: 8496 Gerrit-PatchSet: 4 Gerrit-Owner: Philip ZeyligerGerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 14 Nov 2017 01:29:55 + Gerrit-HasComments: No
[Impala-ASF-CR] Expose $IMPALA MAVEN OPTIONS for configuring Maven.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8496 ) Change subject: Expose $IMPALA_MAVEN_OPTIONS for configuring Maven. .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1462/ -- To view, visit http://gerrit.cloudera.org:8080/8496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c62185476fd2388c7cda8884276b79a77370127 Gerrit-Change-Number: 8496 Gerrit-PatchSet: 4 Gerrit-Owner: Philip ZeyligerGerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 13 Nov 2017 21:59:37 + Gerrit-HasComments: No
[Impala-ASF-CR] Expose $IMPALA MAVEN OPTIONS for configuring Maven.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8496 ) Change subject: Expose $IMPALA_MAVEN_OPTIONS for configuring Maven. .. Patch Set 4: Code-Review+2 Rebase, carry + 2 -- To view, visit http://gerrit.cloudera.org:8080/8496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c62185476fd2388c7cda8884276b79a77370127 Gerrit-Change-Number: 8496 Gerrit-PatchSet: 4 Gerrit-Owner: Philip ZeyligerGerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Mon, 13 Nov 2017 21:58:47 + Gerrit-HasComments: No
[Impala-ASF-CR] Expose $IMPALA MAVEN OPTIONS for configuring Maven.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8496 ) Change subject: Expose $IMPALA_MAVEN_OPTIONS for configuring Maven. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c62185476fd2388c7cda8884276b79a77370127 Gerrit-Change-Number: 8496 Gerrit-PatchSet: 3 Gerrit-Owner: Philip ZeyligerGerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 08 Nov 2017 23:17:52 + Gerrit-HasComments: No
[Impala-ASF-CR] Expose $IMPALA MAVEN OPTIONS for configuring Maven.
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8496 to look at the new patch set (#3). Change subject: Expose $IMPALA_MAVEN_OPTIONS for configuring Maven. .. Expose $IMPALA_MAVEN_OPTIONS for configuring Maven. With this commit, $IMPALA_MAVEN_OPTIONS is used by bin/mvn-quiet.sh to configure Maven slightly. The default is no extra options. This is handy for giving Maven a settings file with the "-s" flag, to control, for example, repositories and their mirrors. In fact, I considered exposing IMPALA_MAVEN_SETTINGS_FILE explicitly, but decided that the generic option would be as good. It's useful to customize how Maven works, especially to provide a settings file with repository mirrors. Change-Id: I2c62185476fd2388c7cda8884276b79a77370127 --- M bin/impala-config.sh M bin/mvn-quiet.sh M testdata/bin/generate-block-ids.sh M testdata/bin/generate-load-nested.sh M testdata/bin/split-hbase.sh 5 files changed, 14 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/8496/3 -- To view, visit http://gerrit.cloudera.org:8080/8496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2c62185476fd2388c7cda8884276b79a77370127 Gerrit-Change-Number: 8496 Gerrit-PatchSet: 3 Gerrit-Owner: Philip ZeyligerGerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] Expose $IMPALA MAVEN OPTIONS for configuring Maven.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8496 ) Change subject: Expose $IMPALA_MAVEN_OPTIONS for configuring Maven. .. Patch Set 1: We call mvn in a few other places, e.g. testdata/bin/split-hbase.sh, testdata/bin/generate-load-nested.sh, testdata/bin/generate-block-ids.sh. Should those also be updated? -- To view, visit http://gerrit.cloudera.org:8080/8496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c62185476fd2388c7cda8884276b79a77370127 Gerrit-Change-Number: 8496 Gerrit-PatchSet: 1 Gerrit-Owner: Philip ZeyligerGerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 08 Nov 2017 18:49:36 + Gerrit-HasComments: No
[Impala-ASF-CR] Expose $IMPALA MAVEN OPTIONS for configuring Maven.
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8496 Change subject: Expose $IMPALA_MAVEN_OPTIONS for configuring Maven. .. Expose $IMPALA_MAVEN_OPTIONS for configuring Maven. With this commit, $IMPALA_MAVEN_OPTIONS is used by bin/mvn-quiet.sh to configure Maven slightly. The default is no extra options. This is handy for giving Maven a settings file with the "-s" flag, to control, for example, repositories and their mirrors. In fact, I considered exposing IMPALA_MAVEN_SETTINGS_FILE explicitly, but decided that the generic option would be as good. It's useful to customize how Maven works, especially to provide a settings file with repository mirrors. Change-Id: I2c62185476fd2388c7cda8884276b79a77370127 --- M bin/impala-config.sh M bin/mvn-quiet.sh 2 files changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/8496/1 -- To view, visit http://gerrit.cloudera.org:8080/8496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2c62185476fd2388c7cda8884276b79a77370127 Gerrit-Change-Number: 8496 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger