[Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module

[Internal Jenkins (Code Review)]

Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-2905: Move QueryResultSet implementations into separate 
module
..


IMPALA-2905: Move QueryResultSet implementations into separate module

This mostly mechanical change moves the definition and implementation of
the Beeswax and HS2-specific result sets into their own module. Result
sets are now uniformly created by one of two factory methods, so the
implementation is decoupled from the client.

Change-Id: I6ab883b62d3ec7012240edf8d56889349e7c0e32
Reviewed-on: http://gerrit.cloudera.org:8080/4736
Reviewed-by: Henry Robinson 
Tested-by: Internal Jenkins
---
M be/src/service/CMakeLists.txt
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
A be/src/service/query-result-set.cc
M be/src/service/query-result-set.h
5 files changed, 503 insertions(+), 419 deletions(-)

Approvals:
  Henry Robinson: Looks good to me, approved
  Internal Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6ab883b62d3ec7012240edf8d56889349e7c0e32
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Internal Jenkins

[Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module

[Internal Jenkins (Code Review)]

Internal Jenkins has posted comments on this change.

Change subject: IMPALA-2905: Move QueryResultSet implementations into separate 
module
..


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ab883b62d3ec7012240edf8d56889349e7c0e32
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Internal Jenkins
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module

[Henry Robinson (Code Review)]

Henry Robinson has posted comments on this change.

Change subject: IMPALA-2905: Move QueryResultSet implementations into separate 
module
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ab883b62d3ec7012240edf8d56889349e7c0e32
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Henry Robinson 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module

[Henry Robinson (Code Review)]

Henry Robinson has posted comments on this change.

Change subject: IMPALA-2905: Move QueryResultSet implementations into separate 
module
..


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4736/2//COMMIT_MSG
Commit Message:

Line 7: IMPALA-2905: Move QueryResultSet implementations into separate module
> Is this the right JIRA? IMPALA-2905 is fixed.
It was suggested in the 2905 review, where half the work was done. Didn't see a 
lot of point making a new JIRA.


http://gerrit.cloudera.org:8080/#/c/4736/2/be/src/service/impala-beeswax-server.cc
File be/src/service/impala-beeswax-server.cc:

PS2, Line 500: (
> nit: extraneous parens.
Done


http://gerrit.cloudera.org:8080/#/c/4736/2/be/src/service/query-result-set.h
File be/src/service/query-result-set.h:

Line 27: #include 
> what for?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ab883b62d3ec7012240edf8d56889349e7c0e32
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Henry Robinson 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module

[Henry Robinson (Code Review)]

Hello Alex Behm, Dan Hecht,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4736

to look at the new patch set (#3).

Change subject: IMPALA-2905: Move QueryResultSet implementations into separate 
module
..

IMPALA-2905: Move QueryResultSet implementations into separate module

This mostly mechanical change moves the definition and implementation of
the Beeswax and HS2-specific result sets into their own module. Result
sets are now uniformly created by one of two factory methods, so the
implementation is decoupled from the client.

Change-Id: I6ab883b62d3ec7012240edf8d56889349e7c0e32
---
M be/src/service/CMakeLists.txt
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
A be/src/service/query-result-set.cc
M be/src/service/query-result-set.h
5 files changed, 503 insertions(+), 419 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/4736/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6ab883b62d3ec7012240edf8d56889349e7c0e32
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 

[Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module

[Dan Hecht (Code Review)]

Dan Hecht has posted comments on this change.

Change subject: IMPALA-2905: Move QueryResultSet implementations into separate 
module
..


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4736/2/be/src/service/impala-beeswax-server.cc
File be/src/service/impala-beeswax-server.cc:

PS2, Line 500: (
nit: extraneous parens.


-- 
To view, visit http://gerrit.cloudera.org:8080/4736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ab883b62d3ec7012240edf8d56889349e7c0e32
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change.

Change subject: IMPALA-2905: Move QueryResultSet implementations into separate 
module
..


Patch Set 2: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4736/2//COMMIT_MSG
Commit Message:

Line 7: IMPALA-2905: Move QueryResultSet implementations into separate module
Is this the right JIRA? IMPALA-2905 is fixed.


http://gerrit.cloudera.org:8080/#/c/4736/2/be/src/service/query-result-set.h
File be/src/service/query-result-set.h:

Line 27: #include 
what for?


-- 
To view, visit http://gerrit.cloudera.org:8080/4736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ab883b62d3ec7012240edf8d56889349e7c0e32
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Alex Behm 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module

[Henry Robinson (Code Review)]

Henry Robinson has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4736

Change subject: IMPALA-2905: Move QueryResultSet implementations into separate 
module
..

IMPALA-2905: Move QueryResultSet implementations into separate module

This mostly mechanical change moves the definition and implementation of
the Beeswax and HS2-specific result sets into their own module. Result
sets are now uniformly created by one of two factory methods, so the
implementation is decoupled from the client.

Change-Id: I6ab883b62d3ec7012240edf8d56889349e7c0e32
---
M be/src/service/CMakeLists.txt
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
A be/src/service/query-result-set.cc
M be/src/service/query-result-set.h
5 files changed, 504 insertions(+), 419 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/4736/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4736
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ab883b62d3ec7012240edf8d56889349e7c0e32
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson