[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4048: Misc. improvements to /sessions .. IMPALA-4048: Misc. improvements to /sessions * Make table searchable and sortable * Fix 'last accessed time' being printed in UTC * Made table contents more compact so that it mostly fits on screen * Clarify summary text re: active and inactive sessions * Include fix in mustache-cpp required to print 64-bit integers correctly (see https://github.com/henryr/cpp-mustache/commit/29768bf0e84f5a1e95e006fc64996d375499dbda) Testing: Visual inspection and manual sorting, searching etc. Change-Id: I14edcb6d60cf031a62c5a20b2d2b4d23248633a3 Reviewed-on: http://gerrit.cloudera.org:8080/4880 Reviewed-by: Thomas Tauber-Marshall Tested-by: Internal Jenkins Reviewed-by: Tim Armstrong --- M be/src/service/impala-hs2-server.cc M be/src/service/impala-http-handler.cc M be/src/service/impala-server.cc M be/src/service/impala-server.h M be/src/thirdparty/mustache/mustache.cc M www/sessions.tmpl 6 files changed, 78 insertions(+), 46 deletions(-) Approvals: Internal Jenkins: Verified Thomas Tauber-Marshall: Looks good to me, but someone else must approve Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/4880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14edcb6d60cf031a62c5a20b2d2b4d23248633a3 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4048: Misc. improvements to /sessions .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14edcb6d60cf031a62c5a20b2d2b4d23248633a3 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4048: Misc. improvements to /sessions .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14edcb6d60cf031a62c5a20b2d2b4d23248633a3 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4048: Misc. improvements to /sessions .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14edcb6d60cf031a62c5a20b2d2b4d23248633a3 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4048: Misc. improvements to /sessions .. IMPALA-4048: Misc. improvements to /sessions * Make table searchable and sortable * Fix 'last accessed time' being printed in UTC * Made table contents more compact so that it mostly fits on screen * Clarify summary text re: active and inactive sessions * Include fix in mustache-cpp required to print 64-bit integers correctly (see https://github.com/henryr/cpp-mustache/commit/29768bf0e84f5a1e95e006fc64996d375499dbda) Testing: Visual inspection and manual sorting, searching etc. Change-Id: I14edcb6d60cf031a62c5a20b2d2b4d23248633a3 --- M be/src/service/impala-hs2-server.cc M be/src/service/impala-http-handler.cc M be/src/service/impala-server.cc M be/src/service/impala-server.h M be/src/thirdparty/mustache/mustache.cc M www/sessions.tmpl 6 files changed, 78 insertions(+), 46 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/4880/3 -- To view, visit http://gerrit.cloudera.org:8080/4880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I14edcb6d60cf031a62c5a20b2d2b4d23248633a3 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions
Henry Robinson has posted comments on this change. Change subject: IMPALA-4048: Misc. improvements to /sessions .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4880/2/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: Line 466: "start_time_sort", session.second->last_accessed_ms, document->GetAllocator()); > session.second->start_time_ms? Oops, thanks. http://gerrit.cloudera.org:8080/#/c/4880/2/be/src/thirdparty/mustache/mustache.cc File be/src/thirdparty/mustache/mustache.cc: Line 281: (*out) << context->GetInt64(); > GetInt()? Done -- To view, visit http://gerrit.cloudera.org:8080/4880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14edcb6d60cf031a62c5a20b2d2b4d23248633a3 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4048: Misc. improvements to /sessions .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4880/2/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: Line 466: "start_time_sort", session.second->last_accessed_ms, document->GetAllocator()); session.second->start_time_ms? http://gerrit.cloudera.org:8080/#/c/4880/2/be/src/thirdparty/mustache/mustache.cc File be/src/thirdparty/mustache/mustache.cc: Line 281: (*out) << context->GetInt64(); GetInt()? -- To view, visit http://gerrit.cloudera.org:8080/4880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14edcb6d60cf031a62c5a20b2d2b4d23248633a3 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-4048: Misc. improvements to /sessions .. IMPALA-4048: Misc. improvements to /sessions * Make table searchable and sortable * Fix 'last accessed time' being printed in UTC * Made table contents more compact so that it mostly fits on screen * Clarify summary text re: active and inactive sessions * Include fix in mustache-cpp required to print 64-bit integers correctly (see https://github.com/henryr/cpp-mustache/commit/29768bf0e84f5a1e95e006fc64996d375499dbda) Change-Id: I14edcb6d60cf031a62c5a20b2d2b4d23248633a3 Testing: Visual inspection and manual sorting, searching etc. --- M be/src/service/impala-hs2-server.cc M be/src/service/impala-http-handler.cc M be/src/service/impala-server.cc M be/src/service/impala-server.h M be/src/thirdparty/mustache/mustache.cc M www/sessions.tmpl 6 files changed, 79 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/4880/2 -- To view, visit http://gerrit.cloudera.org:8080/4880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I14edcb6d60cf031a62c5a20b2d2b4d23248633a3 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson
[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4880 Change subject: IMPALA-4048: Misc. improvements to /sessions .. IMPALA-4048: Misc. improvements to /sessions * Make table searchable and sortable * Fix 'last accessed time' being printed in UTC * Made table contents more compact so that it mostly fits on screen * Clarify summary text re: active and inactive sessions * Include fix in mustache-cpp required to print 64-bit integers correctly (see https://github.com/henryr/cpp-mustache/commit/29768bf0e84f5a1e95e006fc64996d375499dbda) Change-Id: I14edcb6d60cf031a62c5a20b2d2b4d23248633a3 Testing: Visual inspection and manual sorting, searching etc. --- M be/src/service/impala-hs2-server.cc M be/src/service/impala-http-handler.cc M be/src/service/impala-server.cc M be/src/service/impala-server.h M be/src/thirdparty/mustache/mustache.cc M www/sessions.tmpl 6 files changed, 74 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/4880/1 -- To view, visit http://gerrit.cloudera.org:8080/4880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I14edcb6d60cf031a62c5a20b2d2b4d23248633a3 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson
