[Impala-ASF-CR] IMPALA-4050: Support starting webserver specified by hostname

2017-08-18 Thread Tim Armstrong (Code Review) 
Tim Armstrong has abandoned this change.

Change subject: IMPALA-4050: Support starting webserver specified by hostname
..


Abandoned

No response to Henry's comment

-- 
To view, visit http://gerrit.cloudera.org:8080/4185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ibe7424a1c27f24560360219a5a6822b23dcbdce5
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: hewenting 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: hewenting

[Impala-ASF-CR] IMPALA-4050: Support starting webserver specified by hostname

2016-10-20 Thread Dan Hecht (Code Review) 
Dan Hecht has abandoned this change.

Change subject: IMPALA-4050: Support starting webserver specified by hostname
..


Abandoned

It looks like this is redundant with https://gerrit.cloudera.org/#/c/4553/.  
You can restore if that's not the case.

-- 
To view, visit http://gerrit.cloudera.org:8080/4314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I9131c6e47ce8e56eda20e9eb82d68b85de2fa866
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: hewenting 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Henry Robinson

[Impala-ASF-CR] IMPALA-4050: Support starting webserver specified by hostname

2016-10-17 Thread Henry Robinson (Code Review) 
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4050: Support starting webserver specified by hostname
..


Patch Set 2:

Hi - will you have some time to work on this patch, or should we close it out?

-- 
To view, visit http://gerrit.cloudera.org:8080/4185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe7424a1c27f24560360219a5a6822b23dcbdce5
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: hewenting 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: hewenting 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4050: Support starting webserver specified by hostname

2016-09-21 Thread Henry Robinson (Code Review) 
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4050: Support starting webserver specified by hostname
..


Patch Set 1:

I think you've submitted this patch without squashing it - so you've got two 
IMPALA-4050 patches in flight. Can you squash them into one patch and then push 
that to Gerrit?

-- 
To view, visit http://gerrit.cloudera.org:8080/4314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9131c6e47ce8e56eda20e9eb82d68b85de2fa866
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: hewenting 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Henry Robinson 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4050: Support starting webserver specified by hostname

2016-09-21 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change.

Change subject: IMPALA-4050: Support starting webserver specified by hostname
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4314/1//COMMIT_MSG
Commit Message:

Line 9:   Change format in webserver.cc and add test in webserver-test.cc
Please describe the before and after format. I don't really see hoe the format 
changed based on the changes in webserver.cc


http://gerrit.cloudera.org:8080/#/c/4314/1/be/src/util/webserver.cc
File be/src/util/webserver.cc:

Line 238:   stringstream listening_spec;
I don't see how the result of listening_spec has changed.


-- 
To view, visit http://gerrit.cloudera.org:8080/4314
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9131c6e47ce8e56eda20e9eb82d68b85de2fa866
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: hewenting 
Gerrit-Reviewer: Alex Behm 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4050: Support starting webserver specified by hostname

2016-09-19 Thread Henry Robinson (Code Review) 
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4050: Support starting webserver specified by hostname
..


Patch Set 2:

See comments on your other patch - I think you can make the changes requested 
here now.

-- 
To view, visit http://gerrit.cloudera.org:8080/4185
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe7424a1c27f24560360219a5a6822b23dcbdce5
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: hewenting 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: hewenting 
Gerrit-HasComments: No