[Impala-ASF-CR] IMPALA-4441: Divide-by-zero in RuntimeProfile::SummaryStatsCounter::SetStats

[Internal Jenkins (Code Review)]

Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4441: Divide-by-zero in 
RuntimeProfile::SummaryStatsCounter::SetStats
..


IMPALA-4441: Divide-by-zero in RuntimeProfile::SummaryStatsCounter::SetStats

This patch anticipates the case where total_num_values_ can be 0 and
makes sure a divide-by-zero is not possible.

Change-Id: I33f1e6fb45505dce7d79497d1632c5f63a409151
Reviewed-on: http://gerrit.cloudera.org:8080/4975
Reviewed-by: Henry Robinson 
Tested-by: Internal Jenkins
---
M be/src/util/runtime-profile.cc
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Henry Robinson: Looks good to me, approved
  Internal Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I33f1e6fb45505dce7d79497d1632c5f63a409151
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil 

[Impala-ASF-CR] IMPALA-4441: Divide-by-zero in RuntimeProfile::SummaryStatsCounter::SetStats

[Internal Jenkins (Code Review)]

Internal Jenkins has posted comments on this change.

Change subject: IMPALA-4441: Divide-by-zero in 
RuntimeProfile::SummaryStatsCounter::SetStats
..


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33f1e6fb45505dce7d79497d1632c5f63a409151
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4441: Divide-by-zero in RuntimeProfile::SummaryStatsCounter::SetStats

[Henry Robinson (Code Review)]

Henry Robinson has posted comments on this change.

Change subject: IMPALA-4441: Divide-by-zero in 
RuntimeProfile::SummaryStatsCounter::SetStats
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33f1e6fb45505dce7d79497d1632c5f63a409151
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4441: Divide-by-zero in RuntimeProfile::SummaryStatsCounter::SetStats

[Henry Robinson (Code Review)]

Henry Robinson has posted comments on this change.

Change subject: IMPALA-4441: Divide-by-zero in 
RuntimeProfile::SummaryStatsCounter::SetStats
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4975/1/be/src/util/runtime-profile.cc
File be/src/util/runtime-profile.cc:

PS1, Line 1034: DCHECK(total_num_values_ > 0);
I don't quite see the reason for this dcheck. If total_num_values_ becomes < 0, 
we should catch that at the point it happens (rather than here). So in 
SetStats(), I think you should check for total_num_values_ >= 0, and set it to 
0 - or just drop the update completely - if it's not. (Rather than DCHECK - 
because here we're dealing with input from an RPC I think, and it's better to 
be robust where possible in those situations).


-- 
To view, visit http://gerrit.cloudera.org:8080/4975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33f1e6fb45505dce7d79497d1632c5f63a409151
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Henry Robinson 
Gerrit-HasComments: Yes