[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. IMPALA-4609: prefix thread counters in fragment profile This adds a prefix to the counter names so that it's more obvious that the thread counters are aggregates across all fragment threads. Example output for "select * from tpch_parquet.lineitem where l_orderkey < 0": Averaged Fragment F00:(Total: 102.949ms, non-child: 0.000ns, % non-child: 0.00%) split sizes: min: 55.70 MB, max: 69.10 MB, avg: 64.54 MB, stddev: 6.25 MB completion times: min:4s629ms max:5s542ms mean: 5s197ms stddev:404.911ms execution rates: min:12.03 MB/sec max:12.69 MB/sec mean:12.40 MB/sec stddev:281.88 KB/sec num instances: 3 - AverageThreadTokens: 2.00 - BloomFilterBytes: 0 - PeakMemoryUsage: 88.46 MB (92753209) - PerHostPeakMemUsage: 88.46 MB (92755940) - RowsProduced: 0 (0) - TotalNetworkReceiveTime: 0.000ns - TotalNetworkSendTime: 307.000ns - TotalStorageWaitTime: 414.738ms - TotalThreadsInvoluntaryContextSwitches: 62 (62) - TotalThreadsTotalWallClockTime: 10s228ms - TotalThreadsSysTime: 118.666ms - TotalThreadsUserTime: 4s630ms - TotalThreadsVoluntaryContextSwitches: 174 (174) Change-Id: Icb8cfbddc758d06b25a14343310bfd9a932ad1f0 Reviewed-on: http://gerrit.cloudera.org:8080/5392 Reviewed-by: Tim ArmstrongTested-by: Impala Public Jenkins --- M be/src/runtime/runtime-state.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb8cfbddc758d06b25a14343310bfd9a932ad1f0 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb8cfbddc758d06b25a14343310bfd9a932ad1f0 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/94/ -- To view, visit http://gerrit.cloudera.org:8080/5392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb8cfbddc758d06b25a14343310bfd9a932ad1f0 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. Patch Set 4: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/5392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb8cfbddc758d06b25a14343310bfd9a932ad1f0 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. Patch Set 3: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/5392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb8cfbddc758d06b25a14343310bfd9a932ad1f0 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb8cfbddc758d06b25a14343310bfd9a932ad1f0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/91/ -- To view, visit http://gerrit.cloudera.org:8080/5392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb8cfbddc758d06b25a14343310bfd9a932ad1f0 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile
Dan Hecht has posted comments on this change. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb8cfbddc758d06b25a14343310bfd9a932ad1f0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4609: prefix thread counters in fragment profile .. IMPALA-4609: prefix thread counters in fragment profile This adds a prefix to the counter names so that it's more obvious that the thread counters are aggregates across all fragment threads. Example output for "select * from tpch_parquet.lineitem where l_orderkey < 0": Averaged Fragment F00:(Total: 102.949ms, non-child: 0.000ns, % non-child: 0.00%) split sizes: min: 55.70 MB, max: 69.10 MB, avg: 64.54 MB, stddev: 6.25 MB completion times: min:4s629ms max:5s542ms mean: 5s197ms stddev:404.911ms execution rates: min:12.03 MB/sec max:12.69 MB/sec mean:12.40 MB/sec stddev:281.88 KB/sec num instances: 3 - AverageThreadTokens: 2.00 - BloomFilterBytes: 0 - PeakMemoryUsage: 88.46 MB (92753209) - PerHostPeakMemUsage: 88.46 MB (92755940) - RowsProduced: 0 (0) - TotalNetworkReceiveTime: 0.000ns - TotalNetworkSendTime: 307.000ns - TotalStorageWaitTime: 414.738ms - TotalThreadsInvoluntaryContextSwitches: 62 (62) - TotalThreadsTotalWallClockTime: 10s228ms - TotalThreadsSysTime: 118.666ms - TotalThreadsUserTime: 4s630ms - TotalThreadsVoluntaryContextSwitches: 174 (174) Change-Id: Icb8cfbddc758d06b25a14343310bfd9a932ad1f0 --- M be/src/runtime/runtime-state.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/5392/2 -- To view, visit http://gerrit.cloudera.org:8080/5392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icb8cfbddc758d06b25a14343310bfd9a932ad1f0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. Patch Set 1: Unfortunately the naming of the other counters is tied to the naming/nesting in the scan node profile so the change would also be reflected there - were you thinking we would reorganise/rename in the same way there? -- To view, visit http://gerrit.cloudera.org:8080/5392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb8cfbddc758d06b25a14343310bfd9a932ad1f0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-4609: prefix thread counters in fragment profile .. Patch Set 1: How about? - TotalThreadsInvoluntaryContextSwitches: 53 (53) - TotalThreadsVoluntaryContextSwitches: 100 (100) - TotalThreadsWallClockTime: 6s668ms - TotalCpuUserTime: 3s030ms - TotalCpuSysTime: 3s030ms - TotalNetworkReceiveTime: 0.000ns - TotalNetworkSendTime: 151.000ns - TotalStorageWaitTime: 266.419ms -- To view, visit http://gerrit.cloudera.org:8080/5392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb8cfbddc758d06b25a14343310bfd9a932ad1f0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim ArmstrongGerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Mostafa Mokhtar Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4609: prefix thread counters in fragment profile
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5392 Change subject: IMPALA-4609: prefix thread counters in fragment profile .. IMPALA-4609: prefix thread counters in fragment profile This adds a prefix to the counter names so that it's more obvious that the thread counters are aggregates across all fragment threads. Example output for "select * from tpch_parquet.lineitem where l_orderkey < 0": Averaged Fragment F00:(Total: 31.812ms, non-child: 0.000ns, % non-child: 0.00%) split sizes: min: 55.70 MB, max: 69.10 MB, avg: 64.54 MB, stddev: 6.25 MB completion times: min:2s994ms max:3s609ms mean: 3s368ms stddev:267.891ms execution rates: min:18.60 MB/sec max:19.66 MB/sec mean:19.13 MB/sec stddev:445.45 KB/sec num instances: 3 - AllThreadsInvoluntaryContextSwitches: 53 (53) - AllThreadsTotalWallClockTime: 6s688ms - AllThreadsSysTime: 77.333ms - AllThreadsUserTime: 3s030ms - AllThreadsVoluntaryContextSwitches: 100 (100) - AverageThreadTokens: 2.00 - BloomFilterBytes: 0 - PeakMemoryUsage: 88.43 MB (92722687) - PerHostPeakMemUsage: 88.43 MB (92725418) - RowsProduced: 0 (0) - TotalNetworkReceiveTime: 0.000ns - TotalNetworkSendTime: 151.000ns - TotalStorageWaitTime: 266.419ms Change-Id: Icb8cfbddc758d06b25a14343310bfd9a932ad1f0 --- M be/src/runtime/runtime-state.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/5392/1 -- To view, visit http://gerrit.cloudera.org:8080/5392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icb8cfbddc758d06b25a14343310bfd9a932ad1f0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong