[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest 
gutil
..


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5688/9//COMMIT_MSG
Commit Message:

Line 32: a7c3f30 - Remove AMD Opteron Rev E workaround from atomicops
probably worth our taking this patch into kudu gutil as well


-- 
To view, visit http://gerrit.cloudera.org:8080/5688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

[Henry Robinson (Code Review)]

Henry Robinson has posted comments on this change.

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest 
gutil
..


Patch Set 9:

(2 comments)

Thanks for the quick reviews!

http://gerrit.cloudera.org:8080/#/c/5688/9/be/src/util/time.h
File be/src/util/time.h:

Line 36:   return ts.tv_sec * NANOS_PER_SEC + ts.tv_nsec;
> are you sure impala doesn't have a commit that introduced GetMonoTimeNanos(
I think we did add it for MacOS (see 
https://github.com/apache/incubator-impala/commit/aeadd326a982af0f2ac8d55e425248a8bc7babfe),
 and that added GetMonoTimeNanos() for both platforms. I took the view that 
it's easier to maintain Impala-side dependencies for now, and that the MacOS 
port is effectively dead at this point.


http://gerrit.cloudera.org:8080/#/c/5688/9/cmake_modules/kudu_cmake_fns.txt
File cmake_modules/kudu_cmake_fns.txt:

Line 64:   endif()
> what do these two changes do and why are they needed now?
The first change adds custom compile flags to this target. This is needed to 
suppress some spurious warnings.

The second change isn't strictly needed here, but since gutil is the first user 
of ADD_EXPORTABLE_LIBRARY I figured I'd include the fix at the earliest point. 
This allows CMake to properly handle transitive dependencies, so we don't need 
to 'flatten' all the deps of, e.g., kudu_util when linking against it.


-- 
To view, visit http://gerrit.cloudera.org:8080/5688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest 
gutil
..


Patch Set 9:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/420/

-- 
To view, visit http://gerrit.cloudera.org:8080/5688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

[Henry Robinson (Code Review)]

Hello Impala Public Jenkins, Jim Apple, Dan Hecht, Tim Armstrong,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5688

to look at the new patch set (#9).

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest 
gutil
..

IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

Meant to be taken as a whole with the previous commit. This patch makes
the necessary code changes to Impala and the gutil/ library to fix all
compilation errors. Future upgrades to gutil/ should redo the work in
this commit.

* Remove kudu/ include prefix with command:

git grep -l "include \"kudu/" | xargs sed -i 's/include \"kudu\//include
\"/g'

* Change KUDU_GUTIL_* guards to be GUTIL_*

git grep -l KUDU_GUTIL | xargs sed -i 's/KUDU_GUTIL/GUTIL/g'

* Replace glog/logging.h with common/logging.h

git grep -l "glog/logging" | xargs sed -i 's/glog\/logging/common\/logging/g'

* Provide our own implementation of since-removed MonotonicNanos()
* Reinstate COMPILE_FLAGS argument to ADD_EXPORTABLE_LIBRARY,
  used by gutil.
* Replay overwritten parts of following commits:

a7c3f30 - Remove AMD Opteron Rev E workaround from atomicops
54194af - IMPALA-4631: don't use floating point operations for time unit
conversions
152c586 - Improve AtomicInt abstraction and implementation

* Comment out non-compiling deprecated function definitions in numbers.h
* Overwrite changes from 92fafa "Use more efficient gutil implementation
  of Log2Ceiling" in favour of implementing them in Impala code only.
* Couple of misc fixes.

Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
---
M be/src/exec/hash-table.inline.h
M be/src/gutil/atomic_refcount.h
M be/src/gutil/atomicops-internals-x86.cc
M be/src/gutil/atomicops-internals-x86.h
M be/src/gutil/atomicops.h
M be/src/gutil/auxiliary/atomicops-internals-arm-generic.h
M be/src/gutil/auxiliary/atomicops-internals-arm-v6plus.h
M be/src/gutil/auxiliary/atomicops-internals-windows.h
M be/src/gutil/basictypes.h
M be/src/gutil/bind.h
M be/src/gutil/bind_helpers.h
M be/src/gutil/bind_internal.h
M be/src/gutil/bits.cc
M be/src/gutil/bits.h
M be/src/gutil/callback.h
M be/src/gutil/callback_forward.h
M be/src/gutil/callback_internal.cc
M be/src/gutil/callback_internal.h
M be/src/gutil/casts.h
M be/src/gutil/charmap.h
M be/src/gutil/cpu.cc
M be/src/gutil/cycleclock-inl.h
M be/src/gutil/endian.h
M be/src/gutil/fixedarray.h
M be/src/gutil/gscoped_ptr.h
M be/src/gutil/hash/builtin_type_hash.h
M be/src/gutil/hash/city.cc
M be/src/gutil/hash/city.h
M be/src/gutil/hash/hash.cc
M be/src/gutil/hash/hash.h
M be/src/gutil/hash/hash128to64.h
M be/src/gutil/hash/jenkins.cc
M be/src/gutil/hash/jenkins.h
M be/src/gutil/hash/jenkins_lookup2.h
M be/src/gutil/hash/legacy_hash.h
M be/src/gutil/hash/string_hash.h
M be/src/gutil/int128.cc
M be/src/gutil/int128.h
M be/src/gutil/macros.h
M be/src/gutil/manual_constructor.h
M be/src/gutil/map-util.h
M be/src/gutil/mathlimits.cc
M be/src/gutil/once.cc
M be/src/gutil/once.h
M be/src/gutil/paranoid.h
M be/src/gutil/port.h
M be/src/gutil/raw_scoped_refptr_mismatch_checker.h
M be/src/gutil/ref_counted.cc
M be/src/gutil/ref_counted.h
M be/src/gutil/ref_counted_memory.cc
M be/src/gutil/ref_counted_memory.h
M be/src/gutil/singleton.h
M be/src/gutil/spinlock.cc
M be/src/gutil/spinlock.h
M be/src/gutil/spinlock_internal.cc
M be/src/gutil/spinlock_internal.h
M be/src/gutil/spinlock_linux-inl.h
M be/src/gutil/stl_util.h
M be/src/gutil/stringprintf.cc
M be/src/gutil/stringprintf.h
M be/src/gutil/strings/ascii_ctype.cc
M be/src/gutil/strings/charset.cc
M be/src/gutil/strings/charset.h
M be/src/gutil/strings/escaping.cc
M be/src/gutil/strings/escaping.h
M be/src/gutil/strings/fastmem.h
M be/src/gutil/strings/human_readable.cc
M be/src/gutil/strings/human_readable.h
M be/src/gutil/strings/join.cc
M be/src/gutil/strings/join.h
M be/src/gutil/strings/memutil.cc
M be/src/gutil/strings/memutil.h
M be/src/gutil/strings/numbers.cc
M be/src/gutil/strings/numbers.h
M be/src/gutil/strings/serialize.cc
M be/src/gutil/strings/serialize.h
M be/src/gutil/strings/split.cc
M be/src/gutil/strings/split.h
M be/src/gutil/strings/split_internal.h
M be/src/gutil/strings/strcat.cc
M be/src/gutil/strings/strcat.h
M be/src/gutil/strings/string_util-test.cc
M be/src/gutil/strings/stringpiece.cc
M be/src/gutil/strings/stringpiece.h
M be/src/gutil/strings/strip.cc
M be/src/gutil/strings/strip.h
M be/src/gutil/strings/substitute.cc
M be/src/gutil/strings/substitute.h
M be/src/gutil/strings/util.cc
M be/src/gutil/strings/util.h
M be/src/gutil/strtoint.cc
M be/src/gutil/strtoint.h
M be/src/gutil/synchronization_profiling.h
M be/src/gutil/sysinfo.cc
M be/src/gutil/threading/thread_collision_warner.cc
M be/src/gutil/threading/thread_collision_warner.h
M be/src/gutil/type_traits.h
M be/src/gutil/walltime.cc
M be/src/gutil/walltime.h
M be/src/runtime/buffered-tuple-stream-test.cc
M 

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

[Dan Hecht (Code Review)]

Dan Hecht has posted comments on this change.

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest 
gutil
..


Patch Set 8: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest 
gutil
..


Patch Set 8: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest 
gutil
..


Patch Set 8:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/417/

-- 
To view, visit http://gerrit.cloudera.org:8080/5688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

[Henry Robinson (Code Review)]

Hello Impala Public Jenkins, Jim Apple, Tim Armstrong,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5688

to look at the new patch set (#8).

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest 
gutil
..

IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

Meant to be taken as a whole with the previous commit. This patch makes
the necessary code changes to Impala and the gutil/ library to fix all
compilation errors.

* Provide our own implementation of since-removed MonotonicNanos()
* Reinstate COMPILE_FLAGS argument to ADD_EXPORTABLE_LIBRARY,
  used by gutil.
* Comment out non-compiling deprecated function definitions in numbers.h
* Couple of misc fixes.

Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
---
M be/src/exec/hash-table.inline.h
M be/src/gutil/macros.h
M be/src/gutil/strings/numbers.h
M be/src/runtime/buffered-tuple-stream-test.cc
M be/src/runtime/buffered-tuple-stream-v2-test.cc
M be/src/runtime/bufferpool/suballocator.cc
M be/src/runtime/collection-value-builder.h
M be/src/util/bit-util-test.cc
M be/src/util/bit-util.h
M be/src/util/error-util.h
M be/src/util/time.h
M cmake_modules/kudu_cmake_fns.txt
12 files changed, 91 insertions(+), 45 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/5688/8
-- 
To view, visit http://gerrit.cloudera.org:8080/5688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest 
gutil
..


Patch Set 7: Verified-1

Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/416/

-- 
To view, visit http://gerrit.cloudera.org:8080/5688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest 
gutil
..


Patch Set 7:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/416/

-- 
To view, visit http://gerrit.cloudera.org:8080/5688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

[Jim Apple (Code Review)]

Jim Apple has posted comments on this change.

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest 
gutil
..


Patch Set 7: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/5688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

[Henry Robinson (Code Review)]

Hello Jim Apple, Tim Armstrong,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/5688

to look at the new patch set (#7).

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest 
gutil
..

IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

Meant to be taken as a whole with the previous commit. This patch makes
the necessary code changes to Impala and the gutil/ library to fix all
compilation errors.

* Provide our own implementation of since-removed MonotonicNanos()
* Reinstate COMPILE_FLAGS argument to ADD_EXPORTABLE_LIBRARY,
  used by gutil.
* Comment out non-compiling deprecated function definitions in numbers.h
* Couple of misc fixes.

Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
---
M be/src/exec/hash-table.inline.h
M be/src/gutil/macros.h
M be/src/gutil/strings/numbers.h
M be/src/runtime/bufferpool/suballocator.cc
M be/src/runtime/collection-value-builder.h
M be/src/util/bit-util-test.cc
M be/src/util/bit-util.h
M be/src/util/error-util.h
M be/src/util/time.h
M cmake_modules/kudu_cmake_fns.txt
10 files changed, 89 insertions(+), 43 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/5688/7
-- 
To view, visit http://gerrit.cloudera.org:8080/5688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

[Henry Robinson (Code Review)]

Henry Robinson has posted comments on this change.

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest 
gutil
..


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5688/6/be/src/common/atomic.h
File be/src/common/atomic.h:

Line 104: return base::subtle::Release_CompareAndSwap(_, old_val, 
new_val) == old_val;
> It looks like Barrier_CompareAndSwap was added by Dan to gutils in the belo
I reverted to the original (Dan's commit) just to be safe.


http://gerrit.cloudera.org:8080/#/c/5688/6/be/src/util/time.h
File be/src/util/time.h:

PS6, Line 31: 10ll
> nit: Maybe 1'000'000'000LL?
Tried it, but it confused my Emacs' cc-mode (which parsed it as an unterminated 
string). I didn't spend much time trying to fix it.


PS6, Line 40: 1e9
> NANOS_PER_SEC?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

[Henry Robinson (Code Review)]

Henry Robinson has uploaded a new patch set (#6).

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest 
gutil
..

IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

Meant to be taken as a whole with the previous commit. This patch makes
the necessary code changes to Impala and the gutil/ library to fix all
compilation errors.

* Provide our own implementation of since-removed MonotonicNanos()
* Provide our own implementation of since-removed
  Barrier_CompareAndSwap().
* Reinstate COMPILE_FLAGS argument to ADD_EXPORTABLE_LIBRARY,
  used by gutil.
* Comment out non-compiling deprecated function definitions in numbers.h
* Couple of misc fixes.

Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
---
M be/src/common/atomic.h
M be/src/exec/hash-table.inline.h
M be/src/gutil/macros.h
M be/src/gutil/strings/numbers.h
M be/src/runtime/bufferpool/suballocator.cc
M be/src/runtime/collection-value-builder.h
M be/src/util/bit-util-test.cc
M be/src/util/bit-util.h
M be/src/util/error-util.h
M be/src/util/time.h
M cmake_modules/kudu_cmake_fns.txt
11 files changed, 91 insertions(+), 44 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/5688/6
-- 
To view, visit http://gerrit.cloudera.org:8080/5688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Henry Robinson 

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

[Henry Robinson (Code Review)]

Henry Robinson has posted comments on this change.

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest 
gutil
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5688/4/be/src/common/atomic.h
File be/src/common/atomic.h:

Line 103: base::subtle::MemoryBarrier();
Dan Hecht - you might want to take a look at this (Barrier_CompareAndSwap() has 
been removed from gutil).


-- 
To view, visit http://gerrit.cloudera.org:8080/5688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson 
Gerrit-Reviewer: Henry Robinson 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

[Henry Robinson (Code Review)]

Henry Robinson has uploaded a new patch set (#4).

Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest 
gutil
..

IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

Meant to be taken as a whole with the previous commit. This patch makes
the necessary code changes to Impala and the gutil/ library to fix all
compilation errors.

* Provide our own implementation of since-removed MonotonicNanos()
* Provide our own implementation of since-removed
  Barrier_CompareAndSwap().
* Reinstate COMPILE_FLAGS argument to ADD_EXPORTABLE_LIBRARY,
  used by gutil.
* Comment out non-compiling deprecated function definitions in numbers.h
* Couple of misc fixes.

Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
---
M be/src/common/atomic.h
M be/src/exec/hash-table.inline.h
M be/src/gutil/macros.h
M be/src/gutil/strings/numbers.h
M be/src/runtime/bufferpool/suballocator.cc
M be/src/runtime/collection-value-builder.h
M be/src/util/bit-util-test.cc
M be/src/util/error-util.h
M be/src/util/time.h
M cmake_modules/kudu_cmake_fns.txt
10 files changed, 56 insertions(+), 41 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/5688/4
-- 
To view, visit http://gerrit.cloudera.org:8080/5688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson